gnodet commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411695349
##
File path:
sshd-core/src/main/java/org/apache/sshd/common/channel/ChannelAsyncOutputStream.java
##
@@ -107,9 +108,39 @@ protected synchronized void
gnodet commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411695054
##
File path:
sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java
##
@@ -954,7 +954,9 @@ protected IoWriteFuture
gnodet commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411694928
##
File path: sshd-sftp/pom.xml
##
@@ -85,6 +85,18 @@
jzlib
test
+
+org.testcontainers
+
gnodet commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411692176
##
File path:
sshd-sftp/src/test/java/org/apache/sshd/client/subsystem/sftp/SftpTransferTest.java
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache
gnodet commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411689843
##
File path:
sshd-sftp/src/main/java/org/apache/sshd/client/subsystem/sftp/impl/SftpRemotePathChannel.java
##
@@ -524,13 +527,13 @@ protected void
gnodet commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411687971
##
File path:
sshd-sftp/src/main/java/org/apache/sshd/client/subsystem/sftp/impl/SftpRemotePathChannel.java
##
@@ -346,30 +355,19 @@ public long
gnodet commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411688147
##
File path:
sshd-sftp/src/main/java/org/apache/sshd/client/subsystem/sftp/impl/SftpRemotePathChannel.java
##
@@ -410,18 +408,23 @@ public long
gnodet commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411682132
##
File path:
sshd-sftp/src/main/java/org/apache/sshd/client/subsystem/sftp/impl/AbstractSftpClient.java
##
@@ -783,10 +786,6 @@ public void
The plugin is definitely supposed to handle all line endings kind.
I've boot up a windows 10 VM, cloned the git repo, built the whole sshd
project.
modified:
sshd-common/src/main/java/org/apache/sshd/common/cipher/package.html
modified:
Did you delete the whole repo and re-clone it? I have no idea, I don’t use
Windows for anything relating to work.
On Mon, Apr 20, 2020 at 1:49 PM Lyor Goldstein
wrote:
> >> >>
> https://stackoverflow.com/questions/21822650/disable-git-eol-conversions
> >> >> You will probably have to checkout
>> >>
https://stackoverflow.com/questions/21822650/disable-git-eol-conversions
>> >> You will probably have to checkout the repo again.
>> Thx - I'll give it a try...
No good - tried all sort of combinations for .gitconfig and .gitattributes
but none worked quite frustrating - makes no
FliegenKLATSCH commented on issue #122:
URL: https://github.com/apache/mina-sshd/pull/122#issuecomment-616704666
Should be fine now.
Do you already have any plannings regarding the next release (date)?
This is an
>> https://stackoverflow.com/questions/21822650/disable-git-eol-conversions
>> You will probably have to checkout the repo again.
Thx - I'll give it a try...
https://stackoverflow.com/questions/21822650/disable-git-eol-conversions
You will probably have to checkout the repo again.
On Mon, Apr 20, 2020 at 1:23 PM Lyor Goldstein
wrote:
> >> Maven auto format might be converting it back to LF then GIT gets
> confused? Maybe just disable the
>> Maven auto format might be converting it back to LF then GIT gets
confused? Maybe just disable the conversion to CRLF?
How do I do that ?
lgoldstein commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411554606
##
File path: sshd-sftp/pom.xml
##
@@ -85,6 +85,18 @@
jzlib
test
+
+org.testcontainers
+
bsideup commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411495180
##
File path: sshd-sftp/pom.xml
##
@@ -85,6 +85,18 @@
jzlib
test
+
+org.testcontainers
+
Maven auto format might be converting it back to LF then GIT gets
confused? Maybe just disable the conversion to CRLF?
On Mon, Apr 20, 2020 at 11:03 AM Lyor Goldstein
wrote:
> >> I thought GIT does this automatically on Windows.
>
> Not entirely - there are some core settings that control it,
>> I thought GIT does this automatically on Windows.
Not entirely - there are some core settings that control it, but it is not
clear how they affect the behavior. My current setup in .gitconfig is shown
below:
[core]
autocrlf = input
filemode = false
I have been using it so far
I thought GIT does this automatically on Windows.
On Mon, Apr 20, 2020 at 10:30 AM Lyor Goldstein
wrote:
> I have just fetched the latest master branch and built it on my Windows
> machine and am getting as if all files have been changed - the change has
> to do with LF -> CRLF change in all
[
https://issues.apache.org/jira/browse/DIRMINA-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087789#comment-17087789
]
Marcin L commented on DIRMINA-1122:
---
Cool. You commented about the same time I submitted the pull
I have just fetched the latest master branch and built it on my Windows
machine and am getting as if all files have been changed - the change has
to do with LF -> CRLF change in all files. How do we prevent this from
happening? Personally I prefer LF, but let's make sure that building on
Linux or
[
https://issues.apache.org/jira/browse/DIRMINA-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087782#comment-17087782
]
Emmanuel Lécharny commented on DIRMINA-1122:
Actually, no, and I just checked it. Sounds
FliegenKLATSCH commented on issue #119:
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-616590045
Ok, thanks. Changelog might just be misleading.
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SSHD-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lyor Goldstein resolved SSHD-660.
-
Fix Version/s: 2.4.1
Resolution: Fixed
> Add support for authentication using signed
lgoldstein commented on a change in pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411387849
##
File path:
sshd-core/src/main/java/org/apache/sshd/common/channel/ChannelAsyncOutputStream.java
##
@@ -107,9 +108,39 @@ protected synchronized
[
https://issues.apache.org/jira/browse/DIRMINA-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087771#comment-17087771
]
Marcin L commented on DIRMINA-1122:
---
Yes - you probably can. The problem is to support all the
[
https://issues.apache.org/jira/browse/DIRMINA-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087766#comment-17087766
]
Emmanuel Lécharny edited comment on DIRMINA-1122 at 4/20/20, 2:08 PM:
[
https://issues.apache.org/jira/browse/DIRMINA-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087766#comment-17087766
]
Emmanuel Lécharny commented on DIRMINA-1122:
I believe this can be done through your own
[
https://issues.apache.org/jira/browse/DIRMINA-1122?focusedWorklogId=425327=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425327
]
ASF GitHub Bot logged work on DIRMINA-1122:
---
Author: ASF GitHub Bot
the-thing opened a new pull request #26:
URL: https://github.com/apache/mina/pull/26
https://issues.apache.org/jira/projects/DIRMINA/issues/DIRMINA-1122
We found out that it is not possible to set endpoint identification
algorithm while discussing SNI support in quickfixj
Yes, sorry for the noise. I must have used a not clean repo before
building or maybe not rebuild from root, not sure. Anyway, I can confirm
that it's working for me too.
Le lun. 20 avr. 2020 à 15:37, Lyor Goldstein a
écrit :
> >> I think your forgot to commit the changes to a few files:
lgoldstein commented on issue #122:
URL: https://github.com/apache/mina-sshd/pull/122#issuecomment-616559748
Please resolve the conflicts and let me know when you feel it is ready to
merge
This is an automated message from
>> I think your forgot to commit the changes to a few files: KeyUtils,
KeyPairProvider
I don't think so - I have used the cloned repository commits rather that
the PR + the code compiles and passes all tests.
lgoldstein commented on issue #119:
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-616557210
>> Thanks a lot, but it's not only server side support but also client side
(I started with client side actually and had two different commits..).
Sorry - too late now - the
gnodet opened a new pull request #123:
URL: https://github.com/apache/mina-sshd/pull/123
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
snufkinsnorka commented on issue #25:
URL: https://github.com/apache/mina/pull/25#issuecomment-616402730
We want to extend those in order to add ability of moving IoSession
established sockets from processor to processor.
We use this when we want to move connections between different
elecharny commented on issue #25:
URL: https://github.com/apache/mina/pull/25#issuecomment-616378510
Wondering: why would you make those classes extensible ?
This is an automated message from the Apache Git Service.
To
snufkinsnorka opened a new pull request #25:
URL: https://github.com/apache/mina/pull/25
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
39 matches
Mail list logo
