[jira] [Work logged] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?focusedWorklogId=466531&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466531 ] ASF GitHub Bot logged work on SSHD-1050: Author: ASF GitHub Bot

[GitHub] [mina-sshd] tomaswolf commented on pull request #156: [SSHD-1050] Fixed race condition in AuthFuture if exception caught before authentication started

2020-08-04 Thread GitBox
tomaswolf commented on pull request #156: URL: https://github.com/apache/mina-sshd/pull/156#issuecomment-668882088 Sorry, that doesn't change anything. The following sequence is still possible: exceptionCaught: calls authFutureHolder.get(), gets the InitialAuthFuture auth: calls p

[jira] [Work logged] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?focusedWorklogId=466443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466443 ] ASF GitHub Bot logged work on SSHD-1050: Author: ASF GitHub Bot

[GitHub] [mina-sshd] lgoldstein commented on pull request #156: [SSHD-1050] Fixed race condition in AuthFuture if exception caught before authentication started

2020-08-04 Thread GitBox
lgoldstein commented on pull request #156: URL: https://github.com/apache/mina-sshd/pull/156#issuecomment-668817455 A bit complex to my taste - I have pushed a fix for my original commit - basically I am using an `AtomicReference` instead of `volatile` to manage the replacement of the curr

[GitHub] [mina-sshd] tomaswolf commented on pull request #156: [SSHD-1050] Fixed race condition in AuthFuture if exception caught before authentication started

2020-08-04 Thread GitBox
tomaswolf commented on pull request #156: URL: https://github.com/apache/mina-sshd/pull/156#issuecomment-668803523 I've pushed https://github.com/tomaswolf/mina-sshd/commit/3f15c6dbcce1dae0c88cae5b2ad0c2f07ebbc43e in https://github.com/tomaswolf/mina-sshd/tree/SSHD-1050 . It's a follow-up

[jira] [Work logged] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?focusedWorklogId=466433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466433 ] ASF GitHub Bot logged work on SSHD-1050: Author: ASF GitHub Bot

[jira] [Work logged] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?focusedWorklogId=466193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466193 ] ASF GitHub Bot logged work on SSHD-1050: Author: ASF GitHub Bot

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #156: [SSHD-1050] Fixed race condition in AuthFuture if exception caught before authentication started

2020-08-04 Thread GitBox
lgoldstein commented on a change in pull request #156: URL: https://github.com/apache/mina-sshd/pull/156#discussion_r465005694 ## File path: sshd-core/src/main/java/org/apache/sshd/client/session/ClientSessionImpl.java ## @@ -124,8 +123,19 @@ public AuthFuture auth() throws IO

[jira] [Work logged] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?focusedWorklogId=466179&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466179 ] ASF GitHub Bot logged work on SSHD-1050: Author: ASF GitHub Bot

[GitHub] [mina-sshd] tomaswolf commented on a change in pull request #156: [SSHD-1050] Fixed race condition in AuthFuture if exception caught before authentication started

2020-08-04 Thread GitBox
tomaswolf commented on a change in pull request #156: URL: https://github.com/apache/mina-sshd/pull/156#discussion_r464964829 ## File path: sshd-core/src/main/java/org/apache/sshd/client/session/ClientSessionImpl.java ## @@ -124,8 +123,19 @@ public AuthFuture auth() throws IOE

[jira] [Commented] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread Lyor Goldstein (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170642#comment-17170642 ] Lyor Goldstein commented on SSHD-1050: -- [~wolft] see https://github.com/apache/mina-s

[jira] [Work logged] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?focusedWorklogId=466094&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466094 ] ASF GitHub Bot logged work on SSHD-1050: Author: ASF GitHub Bot

[GitHub] [mina-sshd] lgoldstein opened a new pull request #156: [SSHD-1050] Fixed race condition in AuthFuture if exception caught before authentication started

2020-08-04 Thread GitBox
lgoldstein opened a new pull request #156: URL: https://github.com/apache/mina-sshd/pull/156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread Lyor Goldstein (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170616#comment-17170616 ] Lyor Goldstein commented on SSHD-1050: -- Actually, I think I have an idea - working on

[jira] [Commented] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread Thomas Wolf (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170615#comment-17170615 ] Thomas Wolf commented on SSHD-1050: --- {quote}If an exception occurs while the old instanc

[jira] [Assigned] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread Lyor Goldstein (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyor Goldstein reassigned SSHD-1050: Assignee: Lyor Goldstein > Race condition between early exceptions and AuthFuture > ---

[jira] [Work started] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread Lyor Goldstein (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on SSHD-1050 started by Lyor Goldstein. > Race condition between early exceptions and AuthFuture > --

[jira] [Comment Edited] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread Lyor Goldstein (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170600#comment-17170600 ] Lyor Goldstein edited comment on SSHD-1050 at 8/4/20, 7:13 AM: -

[jira] [Commented] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread Lyor Goldstein (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170600#comment-17170600 ] Lyor Goldstein commented on SSHD-1050: -- Found it - the {{ClientAuthUserService}} crea

[jira] [Commented] (SSHD-1050) Race condition between early exceptions and AuthFuture

2020-08-04 Thread Lyor Goldstein (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170599#comment-17170599 ] Lyor Goldstein commented on SSHD-1050: -- Actually this whole code is strange - the way