[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #237: [SSHD-1283] Added configuration property to control whether ScpShell is enabled

tomaswolf commented on code in PR #237: URL: https://github.com/apache/mina-sshd/pull/237#discussion_r938746368 ## sshd-common/src/main/java/org/apache/sshd/common/config/PreferredAuthConfigEntry.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [mina-sshd] tomaswolf commented on pull request #237: [SSHD-1283] Added configuration property to control whether ScpShell is enabled

tomaswolf commented on PR #237: URL: https://github.com/apache/mina-sshd/pull/237#issuecomment-1206375362 BTW: I think we should have a new release 2.9.1 with only the fixes for Java 8 (SSHD-1281/SSHD-1285), with anything else in a later release. In particular new features should not be in

[GitHub] [mina-sshd] lgoldstein commented on a diff in pull request #237: [SSHD-1283] Added configuration property to control whether ScpShell is enabled

lgoldstein commented on code in PR #237: URL: https://github.com/apache/mina-sshd/pull/237#discussion_r938794190 ## sshd-common/src/main/java/org/apache/sshd/common/config/PreferredAuthConfigEntry.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [mina-sshd] lgoldstein commented on pull request #237: [SSHD-1283] Added configuration property to control whether ScpShell is enabled

lgoldstein commented on PR #237: URL: https://github.com/apache/mina-sshd/pull/237#issuecomment-1206440348 >> BTW: I think we should have a new release 2.9.1 with only the fixes for Java 8 (SSHD-1281/SSHD-1285), with anything else in a later release. In particular new features should not be

[GitHub] [mina-sshd] lgoldstein commented on pull request #237: [SSHD-1283] Added configuration property to control whether ScpShell is enabled

lgoldstein commented on PR #237: URL: https://github.com/apache/mina-sshd/pull/237#issuecomment-1206441258 >> Perhaps I'm missing something (can only review this in the Github Web UI right now), but I don't see any use of this list. No, you are not missing anything - I am still thinki

[GitHub] [mina-sshd] lgoldstein commented on pull request #237: [SSHD-1283] Added configuration property to control whether ScpShell is enabled

lgoldstein commented on PR #237: URL: https://github.com/apache/mina-sshd/pull/237#issuecomment-1206442013 >> This doesn't appear to be a non-standard option. Normal OpenSSH allows overriding any config setting via "-o" on the command-line, and PreferredAuthentications is a standard SSH con

[GitHub] [mina-sshd] lgoldstein commented on pull request #237: [SSHD-1283] Added configuration property to control whether ScpShell is enabled

lgoldstein commented on PR #237: URL: https://github.com/apache/mina-sshd/pull/237#issuecomment-1206442337 >> I don't see any connection between commit https://github.com/apache/mina-sshd/commit/4e2f817c1eff380d083cf43df5d1aec6d8830564 and SSHD-1281. Please fix that typo in the commit messa

[jira] [Created] (SSHD-1288) Infinite loop in org.apache.sshd.sftp.client.impl.SftpInputStreamAsync#doRead

Ivan Fiorentini created SSHD-1288: - Summary: Infinite loop in org.apache.sshd.sftp.client.impl.SftpInputStreamAsync#doRead Key: SSHD-1288 URL: https://issues.apache.org/jira/browse/SSHD-1288 Project:

[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #237: [SSHD-1283] Added configuration property to control whether ScpShell is enabled

tomaswolf commented on code in PR #237: URL: https://github.com/apache/mina-sshd/pull/237#discussion_r938932950 ## sshd-common/src/main/java/org/apache/sshd/common/config/PreferredAuthConfigEntry.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [mina-sshd] lgoldstein commented on a diff in pull request #237: [SSHD-1283] Added configuration property to control whether ScpShell is enabled

lgoldstein commented on code in PR #237: URL: https://github.com/apache/mina-sshd/pull/237#discussion_r939481418 ## sshd-common/src/main/java/org/apache/sshd/common/config/PreferredAuthConfigEntry.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF)