Re: Please help code review

Hi Jonathan, what is the pb you are having with GH ? Can't connect? Can't access to the mina-sshd repo? On 2022/09/07 12:32, Jonathan Valliere wrote: Emmanuel do you have a link somewhere how to fix my connection to Apache on GitHub? On Wed, Sep 7, 2022 at 4:29 AM Edward Zheng wrote: Hi g

Re: Please help code review

I don’t know how to connect my personal account to my Apache permissions for Apache repos. On Thu, Sep 8, 2022 at 3:25 AM Emmanuel Lécharny wrote: > Hi Jonathan, > > what is the pb you are having with GH ? Can't connect? Can't access to > the mina-sshd repo? > > On 2022/09/07 12:32, Jonathan Val

[GitHub] [mina-sshd] tomaswolf commented on pull request #242: Fix: close session when timeout during connect

tomaswolf commented on PR #242: URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1240757939 As far as I see what happens is that the asynchronous connection attempt succeeds after the timeout. I'd move the timeout flag and the `isTimeout()` method to `DefaultSshFuture`.

Re: Please help code review

On 08.09.22 13:11 , Jonathan Valliere wrote: I don’t know how to connect my personal account to my Apache permissions for Apache repos. IIRC all I had to do was enter my GitHub account name in the Apache account info at https://id.apache.org/ . It may take a few hours to take effect. See ht

[jira] [Commented] (SSHD-1285) 2.9.0 release broken on Java 8

[ https://issues.apache.org/jira/browse/SSHD-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601899#comment-17601899 ] Thomas Wolf commented on SSHD-1285: --- It should be there now. See [https://search.maven.

[jira] [Comment Edited] (SSHD-1285) 2.9.0 release broken on Java 8

[ https://issues.apache.org/jira/browse/SSHD-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601899#comment-17601899 ] Thomas Wolf edited comment on SSHD-1285 at 9/8/22 4:02 PM: --- It s

[jira] [Assigned] (SSHD-1294) Default SshClient FD leak because Selector not closed

[ https://issues.apache.org/jira/browse/SSHD-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wolf reassigned SSHD-1294: - Assignee: Thomas Wolf > Default SshClient FD leak because Selector not closed > -

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #243: [SSHD-1294] Close MinaServiceFactory instances properly

tomaswolf opened a new pull request, #243: URL: https://github.com/apache/mina-sshd/pull/243 Ensure that the IoProcessor pool is disposed, otherwise a selector may not get closed, leading to a file handle leak. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Work logged] (SSHD-1294) Default SshClient FD leak because Selector not closed

[ https://issues.apache.org/jira/browse/SSHD-1294?focusedWorklogId=807141&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807141 ] ASF GitHub Bot logged work on SSHD-1294: Author: ASF GitHub Bot

[jira] [Commented] (SSHD-1294) Default SshClient FD leak because Selector not closed

[ https://issues.apache.org/jira/browse/SSHD-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601955#comment-17601955 ] Thomas Wolf commented on SSHD-1294: --- [PR 243|https://github.com/apache/mina-sshd/pull/24

[jira] [Commented] (SSHD-1292) Connection problem with Rebex Buru SFTP Server

[ https://issues.apache.org/jira/browse/SSHD-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601969#comment-17601969 ] Thomas Wolf commented on SSHD-1292: --- It's not possible for me to deduce anything about p

[GitHub] [mina-sshd] onyas commented on pull request #242: Fix: close session when timeout during connect

onyas commented on PR #242: URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1241396817 Hi, @tomaswolf Thank you for your insights, and I updated the code according to your suggestions. Please help review. Thanks. -- This is an automated message from the Apache Git

[jira] [Commented] (SSHD-1285) 2.9.0 release broken on Java 8

[ https://issues.apache.org/jira/browse/SSHD-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602085#comment-17602085 ] Allan BURDAJEWICZ commented on SSHD-1285: - Thanks! > 2.9.0 release broken on Java

[GitHub] [mina-sshd] tomaswolf merged pull request #243: [SSHD-1294] Close MinaServiceFactory instances properly

tomaswolf merged PR #243: URL: https://github.com/apache/mina-sshd/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.

[jira] [Work logged] (SSHD-1294) Default SshClient FD leak because Selector not closed

[ https://issues.apache.org/jira/browse/SSHD-1294?focusedWorklogId=807269&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807269 ] ASF GitHub Bot logged work on SSHD-1294: Author: ASF GitHub Bot

[jira] [Resolved] (SSHD-1294) Default SshClient FD leak because Selector not closed

[ https://issues.apache.org/jira/browse/SSHD-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wolf resolved SSHD-1294. --- Fix Version/s: 2.9.2 Resolution: Fixed > Default SshClient FD leak because Selector not closed

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #244: [SSHD-822] Enable more tests for the Netty and MINA I/O back-ends

tomaswolf opened a new pull request, #244: URL: https://github.com/apache/mina-sshd/pull/244 This series of commits enables most tests for all I/O back-ends. For the details, see the individual commit messages. There are two new very minor features; see CHANGES.md. -- This is an au

[jira] [Assigned] (SSHD-822) Research intermittent failure in unit tests using various I/O service factories

[ https://issues.apache.org/jira/browse/SSHD-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wolf reassigned SSHD-822: Assignee: Thomas Wolf > Research intermittent failure in unit tests using various I/O service > fac

[jira] [Work logged] (SSHD-822) Research intermittent failure in unit tests using various I/O service factories

[ https://issues.apache.org/jira/browse/SSHD-822?focusedWorklogId=807277&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807277 ] ASF GitHub Bot logged work on SSHD-822: --- Author: ASF GitHub Bot

[jira] [Commented] (SSHD-822) Research intermittent failure in unit tests using various I/O service factories

[ https://issues.apache.org/jira/browse/SSHD-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602148#comment-17602148 ] Thomas Wolf commented on SSHD-822: -- [PR 244|https://github.com/apache/mina-sshd/pull/244]