[PR] Add missing U2F ed25519-sk public key equality methods [mina-sshd]

2024-04-16 Thread via GitHub
lf- opened a new pull request, #486: URL: https://github.com/apache/mina-sshd/pull/486 This fixes a bug where Gerrit Code Review (3.8.2, at least) does not properly admit U2F based SSH keys, and they get rejected mysteriously on authentication. -- This is an automated message from the

Re: [I] Perfomance file transfer [mina-sshd]

2024-04-16 Thread via GitHub
tomaswolf commented on issue #485: URL: https://github.com/apache/mina-sshd/issues/485#issuecomment-2060039475 After some analysis, here's what's going on: transferTo/transferFrom, as well as the FileChannel.write() operations, are _positional_ operations.

Re: [I] Perfomance file transfer [mina-sshd]

2024-04-16 Thread via GitHub
tomaswolf commented on issue #485: URL: https://github.com/apache/mina-sshd/issues/485#issuecomment-2059973935 Interesting: if you change in your code ``` readableChannel.transferTo(0, length, writeableChannel); ``` to ``` writeableChannel.transferFrom(readableChannel, 0,

Re: [I] Perfomance file transfer [mina-sshd]

2024-04-16 Thread via GitHub
tomaswolf commented on issue #485: URL: https://github.com/apache/mina-sshd/issues/485#issuecomment-2059918256 Thank you for this test case. It appears that there is indeed something wrong with the `FileChannel`s. The following is in my tests much faster (and on par with OpenSSH or Jsch):

[I] Perfomance file transfer [mina-sshd]

2024-04-16 Thread via GitHub
Holger-Benz opened a new issue, #485: URL: https://github.com/apache/mina-sshd/issues/485 ### Version 2.12.1 ### Bug description Dear apache support team, we are switching our communication software from the JSCHED sftp library to the apache-mina library.