Re: [FtpServer] Project based on Apache Mina FtpServer

2009-04-08 Thread Andy Thomson
Ashish, I suspect the APIviz maven plugin will get you a long-way's toward producing an over-all diagram. Or at least it will assist in making one, the images it produces are clickable, allowing for a rapid "visual" movement around the various parts of the FTP Server architecture. This would

Re: [jira] Created: (FTPSERVER-189) After the renaming FileObject->FtpFile the method FileSystemView#getFileObject should renamed

2008-10-06 Thread Andy Thomson
serialization sans the content. FtpFileObject with an emphasis on the "object" is a pretty good description of it. Andy Andrea Francia wrote: Niklas Gustavsson wrote: On 10/6/08, Andy Thomson <[EMAIL PROTECTED]> wrote: In my opinion, I would leave the FileObject as-is, if

Re: [jira] Created: (FTPSERVER-189) After the renaming FileObject->FtpFile the method FileSystemView#getFileObject should renamed

2008-10-05 Thread Andy Thomson
really causing issues, make changes in a local copy. I suspect though, that as the world moves to more object-based storage, the local changes will be a major problem. It's not just a simple name change, it's what it represents :-). ... my two-cents worth Andy Thomson

FTPSERVER - Spring configuration

2008-06-09 Thread Andy Thomson
Niklas, Does it make sense to move or make the FTPServerNamespaceHandler registration entries to the configuration file? Then this class simply becomes a parser looping through the "namespace" entries and registering them? The "db-user-manager" caught my eye in there, as it will likely go aw

Re: FTPSERVER - Make User interface more basic

2008-06-08 Thread Andy Thomson
free beer, oh wait, we're suppose to give that to them for the nice security package :-). Andy Niklas Gustavsson wrote: On Tue, Jun 3, 2008 at 10:55 PM, Andy Thomson <[EMAIL PROTECTED]> wrote: Niklas, What do you think about making User more basic, ie, more abst

FTPSERVER - re: User

2008-06-03 Thread Andy Thomson
Niklas, In the last comment about the User, disregard the example, it's wrong, no way to cast that way. Don't know what I was thinking. The idea of having a simplified User still holds true. Just don't follow that example :-). Andy

FTPSERVER - Make User interface more basic

2008-06-03 Thread Andy Thomson
MyVirtualUser myUser (MyVirtualUser) user; if (myUser.getEnabled) { MySession session = myUser.getSession(); int uid = myUser.getUid(); ... } } What do you think, just keep the User interface very basic, one method only? Andy Thomson

Re: FTPSERVER - Proposal to add additional SITE command functionality

2008-06-03 Thread Andy Thomson
l re-submit the patches based on the top-level project, just saves some extra command-line work. I should add some test case(s) too. Andy Thomson

Re: [ftpserver] compilation problems

2008-06-02 Thread Andy Thomson
(clazz)) { selected.add(authorities[i]); } } return selected.toArray(new Authority[0]); } Just add the '? extends' in the parameter field. Once that is done, try to rebuild, it should be okay. Andy Thomson Edgar Poce wrote: Hi I'm trying to embed ftpserver

Re: FTPSERVER - Proposal to add additional SITE command functionality

2008-06-02 Thread Andy Thomson
o the CommandFactory interface? All commands have to use that interface in any case. Not sure what impact the above will have on Spring-based configuration format, have to investigate it. On the surface it appears there will not be any issues [hopefully not famous last words]. Andy Thomson N

FTPSERVER - Proposal to add additional SITE command functionality

2008-06-01 Thread Andy Thomson
. All of them have additional methods added, and one implements the CommandFactory. Keep in mind there are many ways to achieve this, the code supplied here is just one approach. Comments? Suggestions? Thank you, Andy Thomson --- Attached is a compressed tar file that contains the p

Re: (FTPSERVER-119) STOR command should not eat exceptions when closing stream

2008-05-08 Thread Andy Thomson
le that the data transfer may have completed successfully, but the close failed do to some other non-data related issue. finally { failure = IoUtils.close(outStream); } if ( failure ) { // 550 - your data is hosed, er, an exception was detected ... } else { } Niklas? Da

Re: (FTPSERVER-119) STOR command should not eat exceptions when closing stream

2008-05-08 Thread Andy Thomson
rver is finished with the FileObject. The close() is just giving the FileObject an opportunity to do some house-cleaning if it wants to. Andy Thomson Frank van der Kleij wrote: Hi Andy, I don't think it's conceptually clean to close the file object before the stream is closed, it&#x

Re: (FTPSERVER-119) STOR command should not eat exceptions when closing stream

2008-05-07 Thread Andy Thomson
he command-level is call the FileObject.close() first, then the stream close. Andy Thomson Frank van der Kleij wrote: Thanks for commenting on the issue. The close on the file object seems a good idea in general but for me it won't do the trick. The Apache VFS API does provide for clos

Re: [jira] Created: (FTPSERVER-133) Profile leaking file handles

2008-05-06 Thread Andy Thomson
tream area. Andy Thomson Niklas Gustavsson (JIRA) wrote: Profile leaking file handles Key: FTPSERVER-133 URL: https://issues.apache.org/jira/browse/FTPSERVER-133 Project: FtpServer Issue Type:

FTPSERVER - configuration changes?

2008-05-01 Thread Andy Thomson
ode in the class, it's plain Java. --- Not sure how to introduce all of this into the ftp server project. I suspect it will be a very popular addition, maybe not for the user manager, but for the generic database ability, and EJB3 capabilities. Andy Thomson

Re: (FTPSERVER-119) STOR command should not eat exceptions when closing stream

2008-05-01 Thread Andy Thomson
: public class STOR extends AbstractCommand { ... try { // access or allocate the file object file = session.getFileSystemView().getFileObject(fileName); // open the file file.open(); } catch (Exception) { // do something } ... } Andy Thomson

Re: (FTPSERVER-119) STOR command should not eat exceptions when closing stream

2008-05-01 Thread Andy Thomson
FileObject. 4. Add a corresponding open() in IOUtils. 5. Any specific errors can now be handled locally. 6. Is lower-level logging at the command implementation required due to [5]? Comments? Andy Thomson David M. Lloyd wrote: Just an observation. First, anything that has a "void close() throws

Re: (FTPSERVER-119) STOR command should not eat exceptions when closing stream

2008-04-30 Thread Andy Thomson
Frank, The better solution is to add support for close() and open(). I added file open() and close() to the ftplet.FileObject interface. This is to better support a virtual file system. For the native file system this does not make too much sense, but for others it does. The open() and close(