[jira] [Commented] (SSHD-1109) Replace log4j with logback as the slf4j logger implementation for tests

2020-12-09 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246742#comment-17246742 ] Matt Sicker commented on SSHD-1109: --- Why not Log4j2 instead? Simpler to upgrade to, and there's support

[jira] [Commented] (SSHD-1091) Java Module support

2020-11-17 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233938#comment-17233938 ] Matt Sicker commented on SSHD-1091: --- There's a ton of overlap in code for SSH clients and servers as

[jira] [Commented] (SSHD-1091) Java Module support

2020-11-12 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230865#comment-17230865 ] Matt Sicker commented on SSHD-1091: --- If it's anything like our experience in Log4j, full JPMS support

[jira] [Commented] (SSHD-704) Add support for curve25519-sha...@libssh.org key exchange

2020-11-01 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224292#comment-17224292 ] Matt Sicker commented on SSHD-704: -- Well, that turned out to be a red herring. My ultimate problem turned

[jira] [Commented] (SSHD-704) Add support for curve25519-sha...@libssh.org key exchange

2020-10-31 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224175#comment-17224175 ] Matt Sicker commented on SSHD-704: -- After comparing the attached Java files with my attempt from last

[jira] [Commented] (SSHD-704) Add support for curve25519-sha...@libssh.org key exchange

2020-10-25 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220379#comment-17220379 ] Matt Sicker commented on SSHD-704: -- I've done some testing, and it seems that both the Java 11 version of

[jira] [Commented] (SSHD-704) Add support for curve25519-sha...@libssh.org key exchange

2020-10-25 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220326#comment-17220326 ] Matt Sicker commented on SSHD-704: -- Note there's a draft RFC for standardizing this (along with

[jira] [Commented] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-10-24 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220208#comment-17220208 ] Matt Sicker commented on SSHD-1017: --- It seems like I've figured out how to implement this using

[jira] [Commented] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-10-24 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220132#comment-17220132 ] Matt Sicker commented on SSHD-1017: --- I found [your PR|https://github.com/mwiede/jsch/pull/17] over

[jira] [Commented] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-10-19 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216920#comment-17216920 ] Matt Sicker commented on SSHD-1017: --- Ha, indeed, the JDK cipher implementations are overly strict about

[jira] [Commented] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-10-19 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216833#comment-17216833 ] Matt Sicker commented on SSHD-1017: --- Oh yes, that makes sense. I read through the OpenSSH source code a

[jira] [Comment Edited] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-10-19 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216817#comment-17216817 ] Matt Sicker edited comment on SSHD-1017 at 10/19/20, 3:29 PM: -- I'd expect any

[jira] [Commented] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-10-19 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216817#comment-17216817 ] Matt Sicker commented on SSHD-1017: --- I'd expect any production implementation to work like the public

[jira] [Commented] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-10-19 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216781#comment-17216781 ] Matt Sicker commented on SSHD-1017: --- Yeah, I had similar problems. Can this work with the Poly1305 Mac

[jira] [Commented] (SSHD-506) Add support for aes128/256-gcm ciphers

2020-10-13 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213172#comment-17213172 ] Matt Sicker commented on SSHD-506: -- I'd imagine that's probably because AES/GCM would normally start

[jira] [Commented] (SSHD-1060) Do not store logger level in fields

2020-08-19 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180539#comment-17180539 ] Matt Sicker commented on SSHD-1060: --- If you used the lambda logger methods (log4j-api or slf4j-api 2.x),

[jira] [Comment Edited] (SSHD-1004) Disable weak security settings

2020-07-03 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151069#comment-17151069 ] Matt Sicker edited comment on SSHD-1004 at 7/3/20, 5:59 PM: See also

[jira] [Commented] (SSHD-1004) Disable weak security settings

2020-07-03 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151069#comment-17151069 ] Matt Sicker commented on SSHD-1004: --- See also https://www.rfc-editor.org/info/rfc4344 which I just found

[jira] [Commented] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-07-03 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151094#comment-17151094 ] Matt Sicker commented on SSHD-1017: --- I took a closer look at the OpenSSH source code again today and

[jira] [Updated] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-07-03 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated SSHD-1017: -- Description: See [protocol

[jira] [Commented] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-06-21 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141526#comment-17141526 ] Matt Sicker commented on SSHD-1017: --- After letting this problem percolate, I think I've figured out the

[jira] [Commented] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-06-20 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141220#comment-17141220 ] Matt Sicker commented on SSHD-1017: --- Oh wait, I see that Bouncycastle even has support for that variant

[jira] [Commented] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-06-20 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141219#comment-17141219 ] Matt Sicker commented on SSHD-1017: --- Potential compatibility problem: it seems like OpenSSH is using the

[jira] [Comment Edited] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-06-20 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141219#comment-17141219 ] Matt Sicker edited comment on SSHD-1017 at 6/20/20, 9:56 PM: - Potential

[jira] [Commented] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-06-20 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141176#comment-17141176 ] Matt Sicker commented on SSHD-1017: --- It looks like all of the Bouncycastle AEAD ciphers can use their

[jira] [Commented] (SSHD-704) Add support for curve25519-sha...@libssh.org key exchange

2020-06-20 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141166#comment-17141166 ] Matt Sicker commented on SSHD-704: -- I just noticed that there's [JEP

[jira] [Created] (SSHD-1017) Add support for chacha20-poly1...@openssh.com

2020-06-14 Thread Matt Sicker (Jira)
Matt Sicker created SSHD-1017: - Summary: Add support for chacha20-poly1...@openssh.com Key: SSHD-1017 URL: https://issues.apache.org/jira/browse/SSHD-1017 Project: MINA SSHD Issue Type: New

[jira] [Commented] (SSHD-704) Add support for curve25519-sha...@libssh.org key exchange

2020-06-14 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135252#comment-17135252 ] Matt Sicker commented on SSHD-704: -- I attempted to use the Weierstrass parameters given in the doc, but

[jira] [Commented] (SSHD-704) Add support for curve25519-sha...@libssh.org key exchange

2020-06-13 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134991#comment-17134991 ] Matt Sicker commented on SSHD-704: -- Found a less academic source for what I'm talking about:

[jira] [Commented] (SSHD-704) Add support for curve25519-sha...@libssh.org key exchange

2020-06-13 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134990#comment-17134990 ] Matt Sicker commented on SSHD-704: -- Though from a theoretical point of view, since there's already an

[jira] [Commented] (SSHD-704) Add support for curve25519-sha...@libssh.org key exchange

2020-06-05 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126869#comment-17126869 ] Matt Sicker commented on SSHD-704: -- It says right there in [https://openjdk.java.net/jeps/324] that it's

[jira] [Commented] (SSHD-704) Add support for curve25519-sha...@libssh.org key exchange

2020-06-04 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126019#comment-17126019 ] Matt Sicker commented on SSHD-704: -- So the only way to support 25519 (or 448) without Java 11 is a

[jira] [Comment Edited] (SSHD-506) Add support for aes128/256-gcm ciphers

2020-05-18 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110430#comment-17110430 ] Matt Sicker edited comment on SSHD-506 at 5/18/20, 4:26 PM: Great timing! I

[jira] [Commented] (SSHD-506) Add support for aes128/256-gcm ciphers

2020-05-18 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110430#comment-17110430 ] Matt Sicker commented on SSHD-506: -- Great timing! I literally just finished doing that. > Add support for

[jira] [Comment Edited] (SSHD-506) Add support for aes128/256-gcm ciphers

2020-05-17 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109606#comment-17109606 ] Matt Sicker edited comment on SSHD-506 at 5/17/20, 6:44 PM: I decided to cheat

[jira] [Commented] (SSHD-506) Add support for aes128/256-gcm ciphers

2020-05-17 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109606#comment-17109606 ] Matt Sicker commented on SSHD-506: -- I decided to cheat a little and go read the source code in OpenSSH. I

[jira] [Commented] (SSHD-506) Add support for aes128/256-gcm ciphers

2020-05-17 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109564#comment-17109564 ] Matt Sicker commented on SSHD-506: -- Yup, it's not as simple an update as some of the other SSH RFCs. Thus,

[jira] [Commented] (SSHD-506) Add support for aes128/256-gcm ciphers

2020-05-17 Thread Matt Sicker (Jira)
[ https://issues.apache.org/jira/browse/SSHD-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109547#comment-17109547 ] Matt Sicker commented on SSHD-506: -- FYI, I'm working on a patch for this as part of some side work I'm