[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

2020-04-21 Thread GitBox
gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412196892 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -954,7 +954,9 @@ protected IoWriteFuture doWritePa

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

2020-04-21 Thread GitBox
gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412193011 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -954,7 +954,9 @@ protected IoWriteFuture doWritePa

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

2020-04-21 Thread GitBox
gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r412193011 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -954,7 +954,9 @@ protected IoWriteFuture doWritePa

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

2020-04-20 Thread GitBox
gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411695349 ## File path: sshd-core/src/main/java/org/apache/sshd/common/channel/ChannelAsyncOutputStream.java ## @@ -107,9 +108,39 @@ protected synchronized void doW

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

2020-04-20 Thread GitBox
gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411695054 ## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ## @@ -954,7 +954,9 @@ protected IoWriteFuture doWritePa

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

2020-04-20 Thread GitBox
gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411694928 ## File path: sshd-sftp/pom.xml ## @@ -85,6 +85,18 @@ jzlib test + +org.testcontainers +

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

2020-04-20 Thread GitBox
gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411692176 ## File path: sshd-sftp/src/test/java/org/apache/sshd/client/subsystem/sftp/SftpTransferTest.java ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Soft

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

2020-04-20 Thread GitBox
gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411689843 ## File path: sshd-sftp/src/main/java/org/apache/sshd/client/subsystem/sftp/impl/SftpRemotePathChannel.java ## @@ -524,13 +527,13 @@ protected void endBlo

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

2020-04-20 Thread GitBox
gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411687971 ## File path: sshd-sftp/src/main/java/org/apache/sshd/client/subsystem/sftp/impl/SftpRemotePathChannel.java ## @@ -346,30 +355,19 @@ public long transferT

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

2020-04-20 Thread GitBox
gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411688147 ## File path: sshd-sftp/src/main/java/org/apache/sshd/client/subsystem/sftp/impl/SftpRemotePathChannel.java ## @@ -410,18 +408,23 @@ public long transferF

[GitHub] [mina-sshd] gnodet commented on a change in pull request #123: SFTP transfer speeds, clean API

2020-04-20 Thread GitBox
gnodet commented on a change in pull request #123: URL: https://github.com/apache/mina-sshd/pull/123#discussion_r411682132 ## File path: sshd-sftp/src/main/java/org/apache/sshd/client/subsystem/sftp/impl/AbstractSftpClient.java ## @@ -783,10 +786,6 @@ public void rename(String