gnodet commented on pull request #166:
URL: https://github.com/apache/mina-sshd/pull/166#issuecomment-695931866
@fengjiajie yes, unfortunately, the test was missing some assumptions. I've
seen it pass when there were errors in the transmission. I've fixed the test
in master.
However,
gnodet commented on pull request #166:
URL: https://github.com/apache/mina-sshd/pull/166#issuecomment-695931866
@fengjiajie yes, unfortunately, the test was missing some assumptions. I've
seen it pass when there were errors in the transmission. I've fixed the test
in master.
However,
gnodet commented on pull request #166:
URL: https://github.com/apache/mina-sshd/pull/166#issuecomment-694707083
Not really. In fact, the test was working better before the partial revert
of SSHD-1003 in
https://github.com/apache/mina-sshd/commit/e512f68e2067723ce85c0f8e6a8642f2773aae9c
-
gnodet commented on pull request #166:
URL: https://github.com/apache/mina-sshd/pull/166#issuecomment-694687259
@fengjiajie it seems this test is failing since
[SSHD-1003](https://issues.apache.org/jira/browse/SSHD-1003).
---
gnodet commented on pull request #166:
URL: https://github.com/apache/mina-sshd/pull/166#issuecomment-694284129
@fengjiajie I'm still waiting for a test before I can commit this PR. Do
you think you could come up with a unit test for the issue ?
--
