jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-667143520
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-665138067
Oh hey, sorry about that. This branch is basically ready at this point as I
got stuck trying to get ChaCha20-Poly1305 to work properly. From what I recall,
I already updated the
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-650583844
Once I’ve figured out the ChaCha part, I think this PR will be ready to go.
I’ll add that cipher in a separate PR, but I’m trying to make the changes
required for both ciphers
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-650477660
While working on SSHD-1017, I discovered a couple refactoring improvements
to add here.
This is an automated
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-647042561
Tested on an RPi4 (arm64), works fine.
This is an automated message from the Apache Git Service.
To respond to the
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-643795423
> I will do so some time soon - does this mean that I can merge this patch
if I am satisfied with it ?
Yes, I think so. I'm a little iffy on the `BaseGCMCipher` name for the
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-643706799
I also tested this with
[dropbear](https://matt.ucc.asn.au/dropbear/dropbear.html) so far, all good.
Also tested with PuTTY (on macOS).
Feel free to test in any other
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-637901360
Found one OSS implementation of the RFC version (disabled by default) in
Erlang OTP. Seems like the ambiguity about requiring a mac with an AEAD cipher
caused OpenSSH to create
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-637256088
Based on what I'm finding online, it does seem like the RFC specifies the
all caps version. I'm going to try adding that as well.
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-637249935
I can't seem to find any official documentation on what the RFC 5647 cipher
names are supposed to be unless they meant to literally use `AEAD_AES_128_GCM`
and `AEAD_AES_256_GCM` as
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-63708
Also tested with FileZilla so far. It even defaulted to selecting
aes256-gcm! Seems to work.
This is an automated
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-637216880
I merged the latest changes from master and did some basic smoketesting
using the following:
Server: OpenSSH_8.1p1, LibreSSL 2.7.3
Command: `./ssh.sh -c
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-633254174
I still need to do some manual integration testing. Thanks for the
suggestions since OpenSSH was the only thing I remembered exists.
This may be on hold for a week or so as
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-632976351
The tests all pass on my machine. I'm not sure what's going on with the
failing one on here.
This is an automated
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-632408690
So it seems I've created an incompatible implementation with OpenSSH at the
moment, but it talks to itself. Still debugging this before this can move
anywhere.
jvz commented on pull request #132:
URL: https://github.com/apache/mina-sshd/pull/132#issuecomment-632271382
Yes, these should be added as defaults once they're working. Based on how
OpenSSH is distributed nowadays, these should the highest priority ciphers.
I've seen ChaCha20 taking
16 matches
Mail list logo
