[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488507#comment-17488507
]
Emmanuel Lécharny commented on DIRMINA-1107:
backported to 2.0 branch
> SslHandler
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845261#comment-16845261
]
Emmanuel Lecharny commented on DIRMINA-1107:
Can we backport the fix to 2.0 ?
> SslHandler
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844809#comment-16844809
]
Jonathan Valliere commented on DIRMINA-1107:
Merged into 2.1.X
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844611#comment-16844611
]
Emmanuel Lecharny commented on DIRMINA-1107:
Great !
Jonathan, I let you merge the branch.
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844606#comment-16844606
]
Guus der Kinderen commented on DIRMINA-1107:
We've replaced our initial fix with what
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843823#comment-16843823
]
Emmanuel Lecharny commented on DIRMINA-1107:
Guus,
I have checked Jonathan's patch on my
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843262#comment-16843262
]
Jonathan Valliere commented on DIRMINA-1107:
The issue with SSL is that the order messages
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842227#comment-16842227
]
Emmanuel Lecharny commented on DIRMINA-1107:
Continuing my archeocodology, here are the
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842072#comment-16842072
]
Emmanuel Lecharny commented on DIRMINA-1107:
Forget about leveraging the {{event}} method:
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841505#comment-16841505
]
Emmanuel Lecharny commented on DIRMINA-1107:
FTR, I just deleted a comment and an attached
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841490#comment-16841490
]
Emmanuel Lecharny commented on DIRMINA-1107:
So here is my first proposed change in
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841103#comment-16841103
]
Guus der Kinderen commented on DIRMINA-1107:
\o/
For what it's worth: since I wrote that
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841096#comment-16841096
]
Emmanuel Lecharny commented on DIRMINA-1107:
Don't worry, we hijacked the thread devising
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841084#comment-16841084
]
Guus der Kinderen commented on DIRMINA-1107:
I'd love to see a solution for the 2.1 branch,
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841071#comment-16841071
]
Emmanuel Lecharny commented on DIRMINA-1107:
Agreed. In any case, that would be quite a
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840626#comment-16840626
]
Jonathan Valliere commented on DIRMINA-1107:
Honestly it doesn't really matter, would have
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840575#comment-16840575
]
Emmanuel Lecharny commented on DIRMINA-1107:
It should never be a filter, that's for sure.
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840551#comment-16840551
]
Jonathan Valliere commented on DIRMINA-1107:
Pretty sure 3.0 design was to integrate SSL
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840518#comment-16840518
]
Emmanuel Lecharny commented on DIRMINA-1107:
We could actually write the fixed size buffer
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840470#comment-16840470
]
Jonathan Valliere commented on DIRMINA-1107:
The only other option than large buffers would
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840433#comment-16840433
]
Emmanuel Lecharny commented on DIRMINA-1107:
Side note: The way encrypted messages are
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840425#comment-16840425
]
Jonathan Valliere commented on DIRMINA-1107:
IMHO only the write mutex is needed to
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840413#comment-16840413
]
Emmanuel Lecharny commented on DIRMINA-1107:
Ok, after having analysed the {{filterWrite}}
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839462#comment-16839462
]
Emmanuel Lecharny commented on DIRMINA-1107:
My point, exactly. We should have the
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839454#comment-16839454
]
Jonathan Valliere commented on DIRMINA-1107:
[~elecharny] Why is there a
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839167#comment-16839167
]
Emmanuel Lecharny commented on DIRMINA-1107:
What I mean is that the
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839151#comment-16839151
]
Guus der Kinderen commented on DIRMINA-1107:
[~elecharny] wrote
{quote} The
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838939#comment-16838939
]
Emmanuel Lecharny commented on DIRMINA-1107:
https://tools.ietf.org/html/rfcThe big problem
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838924#comment-16838924
]
Jonathan Valliere commented on DIRMINA-1107:
I thought there were other commands in TLS
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838921#comment-16838921
]
Emmanuel Lecharny commented on DIRMINA-1107:
Key renegotiation (which has been removed in
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838919#comment-16838919
]
Jonathan Valliere commented on DIRMINA-1107:
[~elecharny] TLS key renegotiation and other
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838918#comment-16838918
]
Emmanuel Lecharny commented on DIRMINA-1107:
@Jonathan what for ? Once the HS is completed,
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838914#comment-16838914
]
Emmanuel Lecharny commented on DIRMINA-1107:
Regarding the multi-threading aspect:
*
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838907#comment-16838907
]
Jonathan Valliere commented on DIRMINA-1107:
Every time you receive a message you have to
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838898#comment-16838898
]
Emmanuel Lecharny commented on DIRMINA-1107:
There are a few bad things done. In the
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838709#comment-16838709
]
Guus der Kinderen commented on DIRMINA-1107:
Thanks for all the feedback!
For what it's
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838707#comment-16838707
]
Jonathan Valliere commented on DIRMINA-1107:
If the same fix can be applied to both
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838682#comment-16838682
]
Emmanuel Lecharny commented on DIRMINA-1107:
I'd rather have this issue cover both
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838675#comment-16838675
]
Jonathan Valliere commented on DIRMINA-1107:
I updated the AFFECTS / FIX VERSION, once
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838673#comment-16838673
]
Jonathan Valliere commented on DIRMINA-1107:
The counter doesn't make any sense since each
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838669#comment-16838669
]
Emmanuel Lecharny commented on DIRMINA-1107:
The pb is that we have 2 queues, and we have
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838662#comment-16838662
]
Guus der Kinderen commented on DIRMINA-1107:
We've found the issue in version 2.1.2.
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838654#comment-16838654
]
Jonathan Valliere commented on DIRMINA-1107:
I'm not exactly sure the real purpose of that
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838647#comment-16838647
]
Emmanuel Lecharny commented on DIRMINA-1107:
Seems like we should include the counter into
[
https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838625#comment-16838625
]
Jonathan Valliere commented on DIRMINA-1107:
What version does this apply to?
> SslHandler
45 matches
Mail list logo
