[jira] [Commented] (SSHD-835) Introduce a Closeable ExecutorService

2018-07-25 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556881#comment-16556881 ] Goldstein Lyor commented on SSHD-835: - {quote} I haven't implemented the ClosingExecutor because

[jira] [Commented] (SSHD-835) Introduce a Closeable ExecutorService

2018-07-25 Thread Guillaume Nodet (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556831#comment-16556831 ] Guillaume Nodet commented on SSHD-835: -- I haven't implemented the `ClosingExecutor` because there's no

[jira] [Commented] (SSHD-835) Introduce a Closeable ExecutorService

2018-07-25 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556142#comment-16556142 ] Goldstein Lyor commented on SSHD-835: - Seems reasonable - although after reviewing the code I would

[jira] [Commented] (SSHD-835) Introduce a Closeable ExecutorService

2018-07-25 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555803#comment-16555803 ] Goldstein Lyor commented on SSHD-835: - [~gnt] I have looked at the code and it seems that most

[jira] [Commented] (SSHD-835) Introduce a Closeable ExecutorService

2018-07-25 Thread Guillaume Nodet (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555817#comment-16555817 ] Guillaume Nodet commented on SSHD-835: -- There are multiple benefits: - remove the need to carry the