Re: Coding stlye guide

2007-05-17 Thread Niklas Therning
Mladen Turk wrote: > Niklas Therning wrote: >> That's one of the reasons why we made this decision IIRC. But maybe it's >> time to reconsider? It sure would be nice to have all source code fixed >> before we release 2.0. >> > > If the decision was made to change the coding style, then IMHO > it's b

Re: Coding stlye guide

2007-05-17 Thread Mladen Turk
Niklas Therning wrote: That's one of the reasons why we made this decision IIRC. But maybe it's time to reconsider? It sure would be nice to have all source code fixed before we release 2.0. If the decision was made to change the coding style, then IMHO it's better to do that sooner then later

Re: Coding stlye guide

2007-05-17 Thread Niklas Therning
Mladen Turk wrote: > Niklas Therning wrote: >>> >>> It would be great if there is some .indent file because >>> I already noticed that there are some files that are >>> starting to break those rules. >>> >> >> Please have a look here: >> http://mina.apache.org/developer-guide.html#DeveloperGuide-Co

Re: Coding stlye guide

2007-05-17 Thread Mladen Turk
Niklas Therning wrote: It would be great if there is some .indent file because I already noticed that there are some files that are starting to break those rules. Please have a look here: http://mina.apache.org/developer-guide.html#DeveloperGuide-CodingConvention Back when MINA was a sub-pro

Re: Coding stlye guide

2007-05-16 Thread Emmanuel Lecharny
Niklas Therning a écrit : Please have a look here: http://mina.apache.org/developer-guide.html#DeveloperGuide-CodingConvention Oh, thanks, Niklas, I didn't found it (was looking into confluence)... Back when MINA was a sub-project of the directory project we used to follow the conventions

Re: Coding stlye guide

2007-05-16 Thread Niklas Therning
Mladen Turk wrote: > Hi, > > Looking at MINA sources I found out that the coding style is > different from what I'm used to. Well, it's personal anyhow, but > it should be important. > > Are there any rules for that? > I have noticed few: > > 1. After each '(' there must be a space. >Exception

Re: Coding stlye guide

2007-05-16 Thread Emmanuel Lecharny
The link I have posted contains pointers to such files, btw. Emmanuel On 5/16/07, Mark Webb <[EMAIL PROTECTED]> wrote: There is a way to import these rules as an xml file into Eclipse. Not sure what everyones IDE of choice is, but I would bet that other IDE's have the same functionality. So

Re: Coding stlye guide

2007-05-16 Thread Mark Webb
There is a way to import these rules as an xml file into Eclipse. Not sure what everyones IDE of choice is, but I would bet that other IDE's have the same functionality. So should we develop a standard and then set up the configuration for different development environments? -- ..Cheers Mark O

Re: Coding stlye guide

2007-05-16 Thread Emmanuel Lecharny
Hi, I am not sure that MINA is still following the Directory project rules (I just don't remember if there were a vote about it or not last year). Anyway, here are the rules MINA used last year : http://cwiki.apache.org/confluence/display/DIRxDEV/Coding+standards Correct me, Trustin, if I'm wr

Coding stlye guide

2007-05-16 Thread Mladen Turk
Hi, Looking at MINA sources I found out that the coding style is different from what I'm used to. Well, it's personal anyhow, but it should be important. Are there any rules for that? I have noticed few: 1. After each '(' there must be a space. Exception is if next char is ')' 2. There must