Re: Dubious code in SslHelper...

2013-05-21 Thread Jeff MAURY
Which branch are you talking about ? trunk or ssl-experiment ? Jeff On Mon, May 20, 2013 at 11:14 AM, Emmanuel Lécharny elecha...@gmail.comwrote: Hi guys, in SslHelper, we do have some code that unwrap the incoming data : private void processUnwrap(AbstractIoSession session,

Re: Dubious code in SslHelper...

2013-05-21 Thread Emmanuel Lécharny
Le 5/21/13 1:19 PM, Jeff MAURY a écrit : Which branch are you talking about ? trunk or ssl-experiment ? Trunk. ssl-experiment is a dead branch. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Re: Dubious code in SslHelper...

2013-05-21 Thread Jeff MAURY
For me, SSL code in trunk is just garbage and we should merge ssl-experiment into trunk Regards Jeff On Tue, May 21, 2013 at 1:27 PM, Emmanuel Lécharny elecha...@gmail.comwrote: Le 5/21/13 1:19 PM, Jeff MAURY a écrit : Which branch are you talking about ? trunk or ssl-experiment ? Trunk.

Re: Dubious code in SslHelper...

2013-05-21 Thread Emmanuel Lécharny
Le 5/21/13 1:32 PM, Jeff MAURY a écrit : For me, SSL code in trunk is just garbage and we should merge ssl-experiment into trunk A... Ok, just do that then ! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com

Dubious code in SslHelper...

2013-05-20 Thread Emmanuel Lécharny
Hi guys, in SslHelper, we do have some code that unwrap the incoming data : private void processUnwrap(AbstractIoSession session, ByteBuffer inBuffer) throws SSLException { // Blind guess : once uncompressed, the resulting buffer will be 3 times bigger ByteBuffer appBuffer =