Re: Fatal Error Handling

2018-02-11 Thread Jonathan Valliere
Look at my patch notes for Christoph’s dispose bug in JIRA DIRMINA-1076I fixed the negative counter problem but want to add a critical check Incase it ever reappears. On Sun, Feb 11, 2018 at 5:15 PM Emmanuel Lécharny wrote: > > > Le 11/02/2018 à 19:14, Jonathan Valliere a écrit : > > There is a

Re: Fatal Error Handling

2018-02-11 Thread Emmanuel Lécharny
Le 11/02/2018 à 19:14, Jonathan Valliere a écrit : > There is a condition in the IoProcessor where the expected Session Count > turns negative. Basically the IoProcessor is now in a Fatal state. What > should happen? Uh oH... The expected Session count should *never* become negative. If it's t

Re: Fatal Error Handling

2018-02-11 Thread Jonathan Valliere
There is a condition in the IoProcessor where the expected Session Count turns negative. Basically the IoProcessor is now in a Fatal state. What should happen? On Sun, Feb 11, 2018 at 12:55 PM Emmanuel Lécharny wrote: > > > Le 11/02/2018 à 15:52, Jonathan Valliere a écrit : > > Hi Team, > > > >

Re: Fatal Error Handling

2018-02-11 Thread Emmanuel Lécharny
Le 11/02/2018 à 15:52, Jonathan Valliere a écrit : > Hi Team, > > What is the standard way in Mina of handing super fatal errors? i.e. > unrecoverable invalid internal state Exception are trapped and probagated to the application through the ExcetionCaught message, the session being closed in

Fatal Error Handling

2018-02-11 Thread Jonathan Valliere
Hi Team, What is the standard way in Mina of handing super fatal errors? i.e. unrecoverable invalid internal state Right now, I added an `assert` statement but that probably isn’t good enough.