Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-20 Thread Guillaume Nodet
It seems mina-core 2.0.19 contains changes that could cause SSL problems in the following camel tests. Any idea ? Guillaume -- Forwarded message - From: Pascal Schumacher Date: mar. 19 juin 2018 à 19:27 Subject: Upgrade to Mina 2.0.19 broke camel-xmpp tests To: d...@camel.apache.

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-20 Thread Emmanuel Lécharny
I'd like to have the following test ran with -Djavax.net.debug=all option set : org.apache.camel.component.xmpp.XmppMultiUserChatTest.testXmppChat There is clearly some SSL weirdness going on... java.lang.RuntimeException: Could not connect to XMPP server: localhost:5222/null Caused by: org.jives

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-20 Thread Guillaume Nodet
Here it is: https://gist.github.com/gnodet/e2f63e474965ba4d02e9625a1c69cbb5 Le mer. 20 juin 2018 à 17:22, Emmanuel Lécharny a écrit : > I'd like to have the following test ran with -Djavax.net.debug=all > option set : > org.apache.camel.component.xmpp.XmppMultiUserChatTest.testXmppChat > > Th

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-20 Thread Emmanuel Lécharny
Le 20/06/2018 à 17:29, Guillaume Nodet a écrit : > Here it is: >https://gist.github.com/gnodet/e2f63e474965ba4d02e9625a1c69cbb5 There is some message : Padded plaintext before ENCRYPTION: len = 240 : 2A 74 62 52 BC 59 24 C5 82 77 DB B3 B6 70 E6 D0 *tbR.Y$..w...p.. 0010: 3C 3F 78 6D

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-20 Thread Lyor Goldstein
I believe CAMEL can simply choose to use mina-core 2.0.18 (since they have the same API) by simply overriding its version in the CAMEL POM. Furthermore, since SSHD does not really need MINA, it can be configured to use NIO2 and thus avoid dragging in the MINA dependency.

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-20 Thread Emmanuel Lécharny
Le 20/06/2018 à 18:09, Lyor Goldstein a écrit : > I believe CAMEL can simply choose to use mina-core 2.0.18 2.0.17. There is an API regression in 2.0.18 which has been solved in 2.0.19. -- Emmanuel Lecharny Symas.com directory.apache.org

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-20 Thread Guillaume Nodet
Le mer. 20 juin 2018 à 18:09, Lyor Goldstein a écrit : > I believe CAMEL can simply choose to use mina-core 2.0.18 (since they have > the same API) by simply overriding its version in the CAMEL POM. > Yeah, I'm not reporting a problem for camel per se, the upgrade has been revert to 2.0.17 and i

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-20 Thread Guillaume Nodet
So I've enabled debug logging which helps a bit. https://gist.github.com/gnodet/04b08b1d19caa67359f352522774a70d I suspect a concurrent access to the byte buffer because the exception should be thrown from the HeapByteBuffer#checkIndex instead of from HeapByteBuffer#get. So I think there is a con

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-20 Thread Emmanuel Lécharny
Le 20/06/2018 à 19:00, Guillaume Nodet a écrit : > So I've enabled debug logging which helps a bit. > https://gist.github.com/gnodet/04b08b1d19caa67359f352522774a70d > > I suspect a concurrent access to the byte buffer because the exception > should be thrown from the HeapByteBuffer#checkIndex

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-21 Thread Guillaume Nodet
It looks like visper is receiving a duplicate message from mina or something like that and thus is closing the session because it assumes a protocol error. The actual location is the following: java.lang.Throwable at org.apache.vysper.xmpp.protocol.ProtocolWorker.processTLSEstablishedInternal(Proto

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-21 Thread Guillaume Nodet
So I can't explain exactly why, but the problem comes from the removal of the following variable: https://github.com/apache/mina/commit/60cb619b6f0a940e7a6b18c060158270c227255b#diff-e3418ff2f83464c155b780cdbfb9e4aaL754 Le jeu. 21 juin 2018 à 10:47, Guillaume Nodet a écrit : > It looks like vi

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-21 Thread Emmanuel Lécharny
Le 21/06/2018 à 12:42, Guillaume Nodet a écrit : > So I can't explain exactly why, but the problem comes from the removal of > the following variable: > > https://github.com/apache/mina/commit/60cb619b6f0a940e7a6b18c060158270c227255b#diff-e3418ff2f83464c155b780cdbfb9e4aaL754 Hmmm... public f

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-21 Thread Guillaume Nodet
Sorry, my link does not work. I pinned it down to the removal of the SslHandler#handshakeStatus variable. Guillaume Le jeu. 21 juin 2018 à 16:43, Emmanuel Lécharny a écrit : > > > Le 21/06/2018 à 12:42, Guillaume Nodet a écrit : > > So I can't explain exactly why, but the problem comes from the

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-21 Thread Emmanuel Lécharny
Le 21/06/2018 à 18:30, Guillaume Nodet a écrit : > Sorry, my link does not work. > I pinned it down to the removal of the SslHandler#handshakeStatus variable. Ok, that makes more sense :-) Can you test a 2.0.19 with this change reverted ? I can easily cut a 2.0.20 fast. (makes me think that m

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-22 Thread Emmanuel Lécharny
Hi Guillaume, I have reverted the change. Can you give it a try ? If it's ok, I can cut a release right away. Thanks ! -- Emmanuel Lecharny Symas.com directory.apache.org pEpkey.asc Description: application/pgp-keys

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-22 Thread Jonathan Valliere
At what point is the SSL going to be redesigned and anyone using it will be forced to update their code? Are we going to continue to support other projects which use internal APIs or variables? Seems like every good idea Emmanuel had was reverted for reasons from “using a private event you should

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-22 Thread Emmanuel Lécharny
Le 22/06/2018 à 14:01, Jonathan Valliere a écrit : > At what point is the SSL going to be redesigned and anyone using it will be > forced to update their code? Sadly, we have thousands of peope using MINA as it is. Mina 3.0 was an effort we started a few years ago to redesign this piece of code

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-22 Thread Jonathan Valliere
I don’t think we should start from a blank page; we could always create a whole new project todo that. I think we will be doing our jobs If we can focus on improving pain points and stability. I don’t have a problem with SSL being a filter; In fact, it is the most flexible way to do it; just need

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-22 Thread Guillaume Nodet
Sorry, I've been on meetings the whole week. I'll give it a try on monday. Le ven. 22 juin 2018 à 10:12, Emmanuel Lécharny a écrit : > Hi Guillaume, > > I have reverted the change. Can you give it a try ? If it's ok, I can > cut a release right away. > > Thanks ! > > -- > Emmanuel Lecharny > > S

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-25 Thread Emmanuel Lécharny
Le 23/06/2018 à 01:40, Guillaume Nodet a écrit : > Sorry, I've been on meetings the whole week. I'll give it a try on monday. Hi Guillaume, any update ? Thanks ! -- Emmanuel Lecharny Symas.com directory.apache.org pEpkey.asc Description: application/pgp-keys

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-29 Thread Guillaume Nodet
Sorry for the delay. I gave it another try and unfortunately, the problem persists with my local build of 2.20-SNAPSHOT. I'll try to find a fix next week. Le mar. 26 juin 2018 à 00:39, Emmanuel Lécharny a écrit : > > > Le 23/06/2018 à 01:40, Guillaume Nodet a écrit : > > Sorry, I've been on meet

Re: Fwd: Upgrade to Mina 2.0.19 broke camel-xmpp tests

2018-06-29 Thread Emmanuel Lécharny
Le 29/06/2018 à 13:10, Guillaume Nodet a écrit : > Sorry for the delay. > I gave it another try and unfortunately, the problem persists with my local > build of 2.20-SNAPSHOT. Ah, crap :/ > I'll try to find a fix next week. Okiedo. What is surprizing is that I fixed the change you pointed, so