Misplaced locking in DefaultIoFuture ?

2008-06-05 Thread Emmanuel Lecharny
Hi guys, I may be wrong, or tired, but while looking at the DefaultIoFuture class (trunk), I discovered that the public IoFuture awaitUninterruptibly() method is using a lock to protect a boolean flag (ready), which will never change, because the only place where this flag is modified is also

Re: Misplaced locking in DefaultIoFuture ?

2008-06-06 Thread Julien Vermillard
On Fri, 06 Jun 2008 01:59:36 +0200 Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: > Hi guys, > > I may be wrong, or tired, but while looking at the DefaultIoFuture > class (trunk), I discovered that the public IoFuture > awaitUninterruptibly() method is using a lock to protect a boolean > flag (rea

Re: Misplaced locking in DefaultIoFuture ?

2008-06-06 Thread Emmanuel Lecharny
btw, is the name 'awaitUninterruptibly' sounds correct to any US native ? Thanks ! Hi, As non us native it's sounding just pretty long to type ;) I would like to precise we accept UK native comments too until it's not about rugby :) Australians, Canadian and Neo-zed's are welcomed

Re: Misplaced locking in DefaultIoFuture ?

2008-06-06 Thread Emmanuel Lecharny
More sleep helps !!! It took me a few seconds this morning to see that there is a lock.wait() in the middle of the awaitXXX method... Julien Vermillard wrote: On Fri, 06 Jun 2008 01:59:36 +0200 Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: Hi guys, I may be wrong, or tired, but while