Re: [PR] Switch to JUnit 5 [mina-sshd]

2024-07-26 Thread via GitHub
tomaswolf commented on code in PR #546: URL: https://github.com/apache/mina-sshd/pull/546#discussion_r1692868168 ## sshd-common/src/test/java/org/apache/sshd/client/auth/password/PasswordIdentityProviderTest.java: ## @@ -69,7 +70,7 @@ public void testMultiProvider() throws IOExc

Re: [PR] Test with jdk 21 [mina-sshd]

2024-07-26 Thread via GitHub
tomaswolf commented on PR #552: URL: https://github.com/apache/mina-sshd/pull/552#issuecomment-2252400130 sshd-ldap is failing. Apache DS appears to be a dead end; see https://github.com/apache/cxf/pull/1042 . -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Switch to JUnit 5 [mina-sshd]

2024-07-26 Thread via GitHub
tomaswolf commented on PR #546: URL: https://github.com/apache/mina-sshd/pull/546#issuecomment-2252323797 It appears that with JUnit5 there needs to be at least one test class in the project itself. sshd-netty has all tests in the sshd-core dependency. sshd-mina worked fine, but sshd-mina d

Re: [PR] Bump slf4j.version from 1.7.32 to 2.0.13 [mina-sshd]

2024-07-26 Thread via GitHub
dependabot[bot] commented on PR #543: URL: https://github.com/apache/mina-sshd/pull/543#issuecomment-2252311174 OK, I won't notify you about version 2.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Bump slf4j.version from 1.7.32 to 2.0.13 [mina-sshd]

2024-07-26 Thread via GitHub
dependabot[bot] closed pull request #543: Bump slf4j.version from 1.7.32 to 2.0.13 URL: https://github.com/apache/mina-sshd/pull/543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Bump slf4j.version from 1.7.32 to 2.0.13 [mina-sshd]

2024-07-26 Thread via GitHub
gnodet commented on PR #543: URL: https://github.com/apache/mina-sshd/pull/543#issuecomment-2252311059 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Bump jgit.version from 5.13.3.202401111512-r to 6.10.0.202406032230-r [mina-sshd]

2024-07-26 Thread via GitHub
tomaswolf commented on PR #549: URL: https://github.com/apache/mina-sshd/pull/549#issuecomment-2252282597 JGit 6 requires Java 11 at runtime. (JGit 7 will require Java 17.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Require JDK 17 at build time (fixes #536) [mina-sshd]

2024-07-26 Thread via GitHub
tomaswolf commented on PR #537: URL: https://github.com/apache/mina-sshd/pull/537#issuecomment-2252266506 Deployment is in master-build.yaml. Does that need the extra maven-setup step now, too? Where is that session.rootDirectory coming from? -- This is an automated message from the Apach

Re: [PR] Bump net.revelc.code.formatter:formatter-maven-plugin from 2.16.0 to 2.24.1 [mina-sshd]

2024-07-26 Thread via GitHub
gnodet merged PR #541: URL: https://github.com/apache/mina-sshd/pull/541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

Re: [PR] Require JDK 17 at build time (fixes #536) [mina-sshd]

2024-07-26 Thread via GitHub
gnodet commented on PR #537: URL: https://github.com/apache/mina-sshd/pull/537#issuecomment-2252215170 > @gnodet: snapshot deployment fails with > > > Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (verify-style) on project sshd: Failed du

Re: [PR] Require JDK 17 at build time (fixes #536) [mina-sshd]

2024-07-26 Thread via GitHub
tomaswolf commented on PR #537: URL: https://github.com/apache/mina-sshd/pull/537#issuecomment-2252203149 @gnodet: snapshot deployment fails with > Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (verify-style) on project sshd: Failed during ch

Re: [PR] Bump net.revelc.code.formatter:formatter-maven-plugin from 2.16.0 to 2.24.1 [mina-sshd]

2024-07-26 Thread via GitHub
gnodet commented on PR #541: URL: https://github.com/apache/mina-sshd/pull/541#issuecomment-2252199470 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump net.revelc.code.formatter:formatter-maven-plugin from 2.16.0 to 2.24.1 [mina-sshd]

2024-07-26 Thread via GitHub
dependabot[bot] commented on PR #541: URL: https://github.com/apache/mina-sshd/pull/541#issuecomment-2252199058 Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratc

Re: [PR] Bump net.revelc.code.formatter:formatter-maven-plugin from 2.16.0 to 2.24.1 [mina-sshd]

2024-07-26 Thread via GitHub
gnodet commented on PR #541: URL: https://github.com/apache/mina-sshd/pull/541#issuecomment-2252198968 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Validate formatting has been done before CI [mina-sshd]

2024-07-26 Thread via GitHub
gnodet merged PR #548: URL: https://github.com/apache/mina-sshd/pull/548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

Re: [I] server host key algorithms = ssh-rsa but still try to encryp the key using rsa-sha2-512 [mina-sshd]

2024-07-26 Thread via GitHub
tomaswolf commented on issue #531: URL: https://github.com/apache/mina-sshd/issues/531#issuecomment-2252188675 Closing this. We cannot do anything about this XFB.Gateway. It appears not to check the announced signature type in the pre-auth request; it only looks whether it knows the announc

Re: [I] server host key algorithms = ssh-rsa but still try to encryp the key using rsa-sha2-512 [mina-sshd]

2024-07-26 Thread via GitHub
tomaswolf closed issue #531: server host key algorithms = ssh-rsa but still try to encryp the key using rsa-sha2-512 URL: https://github.com/apache/mina-sshd/issues/531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Bump org.mockito:mockito-core from 4.2.0 to 5.12.0 [mina-sshd]

2024-07-25 Thread via GitHub
gnodet commented on PR #542: URL: https://github.com/apache/mina-sshd/pull/542#issuecomment-2252092244 Mockito 5.x requires JDK 11, so this is expected to fail when running tests on JDK 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Bump org.mockito:mockito-core from 4.2.0 to 5.12.0 [mina-sshd]

2024-07-25 Thread via GitHub
gnodet commented on PR #542: URL: https://github.com/apache/mina-sshd/pull/542#issuecomment-2252080368 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Bump net.revelc.code.formatter:formatter-maven-plugin from 2.16.0 to 2.24.1 [mina-sshd]

2024-07-25 Thread via GitHub
gnodet commented on PR #541: URL: https://github.com/apache/mina-sshd/pull/541#issuecomment-2252080177 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Require JDK 17 for building [mina-sshd]

2024-07-25 Thread via GitHub
gnodet closed issue #536: Require JDK 17 for building URL: https://github.com/apache/mina-sshd/issues/536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [I] Require JDK 17 for building [mina-sshd]

2024-07-25 Thread via GitHub
gnodet closed issue #536: Require JDK 17 for building URL: https://github.com/apache/mina-sshd/issues/536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] Require JDK 17 at build time (fixes #536) [mina-sshd]

2024-07-25 Thread via GitHub
gnodet merged PR #537: URL: https://github.com/apache/mina-sshd/pull/537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

Re: [VOTE] Release Apache MINA SSHD 2.13.2

2024-07-25 Thread Thomas Wolf
On 25.07.24 20:08 , Gary Gregory wrote: Is there something special I have to do on macOS? Not really. I'm getting a lot of: IllegalState Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration I have Docker Desktop 4.33.0 (160616). The

Re: [PR] Performance optimizations [mina-sshd]

2024-07-25 Thread via GitHub
tomaswolf merged PR #530: URL: https://github.com/apache/mina-sshd/pull/530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.

Re: [I] sftp subsystem ignores process umask when creating directory [mina-sshd]

2024-07-25 Thread via GitHub
tomaswolf commented on issue #535: URL: https://github.com/apache/mina-sshd/issues/535#issuecomment-2251428993 The draft RFCs for SFTP versions 3, 4, and 5 are silent on this matter. For SFTP version 6, the draft RFC says > The server SHOULD NOT apply a 'umask' to the mode bits; but shoul

Re: [VOTE] Release Apache MINA SSHD 2.13.2

2024-07-25 Thread Gary Gregory
Is there something special I have to do on macOS? I'm getting a lot of: IllegalState Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration I have Docker Desktop 4.33.0 (160616). I tested the src zip file. - Can't use "shasum --check ..." s

Re: [VOTE] Release Apache MINA SSHD 2.13.2

2024-07-25 Thread jgenender
+1 Jeff > On Jul 24, 2024, at 11:52 PM, Emmanuel Lécharny wrote: > > My +1 > > On 24/07/2024 23:54, Thomas Wolf wrote: >> On 24.07.24 08:35 , Guillaume Nodet wrote: >>> I've staged a new build which seems to have the problem fixed. >>> However, I haven't changed anything, so I'm not really sur

Re: [PR] Require JDK 17 at build time (fixes #536) [mina-sshd]

2024-07-25 Thread via GitHub
gnodet commented on code in PR #537: URL: https://github.com/apache/mina-sshd/pull/537#discussion_r1691439429 ## pom.xml: ## @@ -137,10 +134,38 @@ -release - -[1.8,1.9) - +toolchains +

Re: [PR] Require JDK 17 at build time (fixes #536) [mina-sshd]

2024-07-25 Thread via GitHub
tomaswolf commented on code in PR #537: URL: https://github.com/apache/mina-sshd/pull/537#discussion_r1691418695 ## pom.xml: ## @@ -137,10 +134,38 @@ -release - -[1.8,1.9) - +toolchains +

Re: [I] Implements global-requests-ok extension [mina-sshd]

2024-07-25 Thread via GitHub
gnodet commented on issue #545: URL: https://github.com/apache/mina-sshd/issues/545#issuecomment-2250218952 > Not sure I agree. I think this expired memo is misguided. RFC 4254 requires parties that do not understand a particular global request to reply with SSH_MSG_REQUEST_FAILURE. A peer

Re: [PR] Bump ant.version from 1.10.12 to 1.10.14 [mina-sshd]

2024-07-25 Thread via GitHub
gnodet merged PR #540: URL: https://github.com/apache/mina-sshd/pull/540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

Re: [PR] Bump com.github.mwiede:jsch from 0.2.17 to 0.2.18 [mina-sshd]

2024-07-25 Thread via GitHub
gnodet merged PR #544: URL: https://github.com/apache/mina-sshd/pull/544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

Re: [PR] Bump slf4j.version from 1.7.32 to 2.0.13 [mina-sshd]

2024-07-25 Thread via GitHub
tomaswolf commented on PR #543: URL: https://github.com/apache/mina-sshd/pull/543#issuecomment-2250092510 slf4j-api should not be changed. We do _not_ want to require library users to use log4j 2. They can, even if we say our minimum required was 1.7.32. -- This is an automated message fr

Re: [I] Implements global-requests-ok extension [mina-sshd]

2024-07-25 Thread via GitHub
tomaswolf commented on issue #545: URL: https://github.com/apache/mina-sshd/issues/545#issuecomment-2250082947 Not sure I agree. I think this expired memo is misguided. RFC 4254 requires parties that do not understand a particular global request to reply with SSH_MSG_REQUEST_FAILURE. A peer

Re: [PR] Add dependabot [mina-sshd]

2024-07-25 Thread via GitHub
gnodet merged PR #538: URL: https://github.com/apache/mina-sshd/pull/538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

Re: [PR] Add dependabot [mina-sshd]

2024-07-25 Thread via GitHub
garydgregory commented on PR #538: URL: https://github.com/apache/mina-sshd/pull/538#issuecomment-2249986095 I would schedule it weekly personally, to make it a bit less noisy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Add dependabot [mina-sshd]

2024-07-25 Thread via GitHub
tomaswolf commented on PR #538: URL: https://github.com/apache/mina-sshd/pull/538#issuecomment-2249979229 No. We'll see how it goes. But we used to get dependabot updates before without this; for instance #457. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Require JDK 11 for building [mina-sshd]

2024-07-25 Thread via GitHub
tomaswolf commented on issue #536: URL: https://github.com/apache/mina-sshd/issues/536#issuecomment-2249775970 You can use JDK 21 in CI, but I would not require it as minimum for building. Still looks more complicated that needed. I'm not at my development machine, so I cannot verify

Re: [I] Require JDK 11 for building [mina-sshd]

2024-07-25 Thread via GitHub
gnodet commented on issue #536: URL: https://github.com/apache/mina-sshd/issues/536#issuecomment-2249734807 > > I'm working on CI. I've set up a `jdk8` profile which removes some plugins that require JDK 11. I don't think toolchains are required here. > > Then we're not really requiri

Re: [VOTE] Release Apache MINA SSHD 2.13.2

2024-07-24 Thread Emmanuel Lécharny
My +1 On 24/07/2024 23:54, Thomas Wolf wrote: On 24.07.24 08:35 , Guillaume Nodet wrote: I've staged a new build which seems to have the problem fixed. However, I haven't changed anything, so I'm not really sure what happened...     https://repository.apache.org/content/repositories/orgapach

Re: [VOTE] Release Apache MINA SSHD 2.13.2

2024-07-24 Thread Thomas Wolf
On 24.07.24 08:35 , Guillaume Nodet wrote: I've staged a new build which seems to have the problem fixed. However, I haven't changed anything, so I'm not really sure what happened... https://repository.apache.org/content/repositories/orgapachemina-1101 Guillaume +1 Sources from https://d

Re: [PR] [SSHD-1161] OpenSSH client certificate publickey authentication [mina-sshd]

2024-07-24 Thread via GitHub
stefan-g commented on PR #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-2248173763 is there a way to validate the host cert-authority manually (same like the knowhost would do)? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [SSHD-1161] OpenSSH client certificate publickey authentication [mina-sshd]

2024-07-24 Thread via GitHub
tomaswolf commented on PR #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-2248125788 Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [SSHD-1161] OpenSSH client certificate publickey authentication [mina-sshd]

2024-07-24 Thread via GitHub
stefan-g commented on PR #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-2248108235 thanks for you answer. your test class helped to get a better understanding and i was able to set up a running client example. Is it right that @cert-authority in knowhost file is not ch

Re: [PR] [SSHD-1161] OpenSSH client certificate publickey authentication [mina-sshd]

2024-07-24 Thread via GitHub
tomaswolf commented on PR #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-2247647699 > what is the status of this feature? https://issues.apache.org/jira/browse/SSHD-1161 has two child issues pointing out some things that should be done on the client side to be fe

Re: [PR] [SSHD-1161] OpenSSH client certificate publickey authentication [mina-sshd]

2024-07-24 Thread via GitHub
stefan-g commented on PR #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-2247448903 what is the status of this feature? https://issues.apache.org/jira/browse/SSHD-1161 is still open. Does client certifcate authentication work on the latest release? -- This is an aut

Re: [VOTE] Release Apache MINA SSHD 2.13.2

2024-07-23 Thread Guillaume Nodet
I've staged a new build which seems to have the problem fixed. However, I haven't changed anything, so I'm not really sure what happened... https://repository.apache.org/content/repositories/orgapachemina-1101 Guillaume Le mar. 23 juil. 2024 à 19:15, Thomas Wolf a écrit : > > On 23.07.24 18:

Re: [VOTE] Release Apache MINA SSHD 2.13.2

2024-07-23 Thread Thomas Wolf
On 23.07.24 18:24 , Guillaume Nodet wrote: Hey, I've staged a candidate release for an SSHD 2.13.2 release. This release contains a single bug fix: * Fix sntrup761x25519-sha512 (https://github.com/apache/mina-sshd/issues/525) Official staging repo: https://dist.apache.org/repos/dist/dev/mina

Re: [I] Require JDK 11 for building [mina-sshd]

2024-07-23 Thread via GitHub
tomaswolf commented on issue #536: URL: https://github.com/apache/mina-sshd/issues/536#issuecomment-2245793633 > I'm working on CI. I've set up a `jdk8` profile which removes some plugins that require JDK 11. I don't think toolchains are required here. Then we're not really requiring

Re: [I] Require JDK 11 for building [mina-sshd]

2024-07-23 Thread via GitHub
gnodet commented on issue #536: URL: https://github.com/apache/mina-sshd/issues/536#issuecomment-2245743326 > This might require changing the CI builds. We still should test on Java 8. Might require maven toolchains. I'm working on CI. I've set up a `jdk8` profile which removes some

Re: [I] Require JDK 11 for building [mina-sshd]

2024-07-23 Thread via GitHub
tomaswolf commented on issue #536: URL: https://github.com/apache/mina-sshd/issues/536#issuecomment-2245728476 This might require changing the CI builds. We still should test on Java 8. Might require maven toolchains. Otherwise fine by me. -- This is an automated message from the A

Re: [I] Require JDK 11 for building [mina-sshd]

2024-07-23 Thread via GitHub
garydgregory commented on issue #536: URL: https://github.com/apache/mina-sshd/issues/536#issuecomment-2245710786 +1 here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Bump org.springframework:spring-core from 5.3.28 to 6.0.15 [mina-sshd]

2024-07-22 Thread via GitHub
dependabot[bot] closed pull request #457: Bump org.springframework:spring-core from 5.3.28 to 6.0.15 URL: https://github.com/apache/mina-sshd/pull/457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump org.springframework:spring-core from 5.3.28 to 6.0.15 [mina-sshd]

2024-07-22 Thread via GitHub
dependabot[bot] commented on PR #457: URL: https://github.com/apache/mina-sshd/pull/457#issuecomment-2244006144 Looks like org.springframework:spring-core is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Bump org.springframework:spring-core from 5.3.28 to 6.0.15 [mina-sshd]

2024-07-22 Thread via GitHub
gnodet commented on PR #457: URL: https://github.com/apache/mina-sshd/pull/457#issuecomment-2244005659 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Performance optimizations [mina-sshd]

2024-07-22 Thread via GitHub
gnodet commented on PR #530: URL: https://github.com/apache/mina-sshd/pull/530#issuecomment-2243951950 > @gnodet: could we do a bug fix release first before merging this? See the [mailing list](https://www.mail-archive.com/dev@mina.apache.org/msg41382.html). Sure, I was assuming you w

Re: [PR] Performance optimizations [mina-sshd]

2024-07-22 Thread via GitHub
tomaswolf commented on PR #530: URL: https://github.com/apache/mina-sshd/pull/530#issuecomment-2243645281 @gnodet: could we do a bug fix release first before merging this? See the [mailing list](https://www.mail-archive.com/dev@mina.apache.org/msg41382.html). -- This is an automated messa

Re: [PR] Performance optimizations [mina-sshd]

2024-07-22 Thread via GitHub
tomaswolf commented on PR #530: URL: https://github.com/apache/mina-sshd/pull/530#issuecomment-2243556103 > I don't think the Java built-in ChaCha20-Poly1305 can be used for SSH. Indeed it cannot, but mainly because the Poly1305 setup is done differently. The IETF version from [RFC 84

Re: [PR] Performance optimizations [mina-sshd]

2024-07-22 Thread via GitHub
tomaswolf commented on PR #530: URL: https://github.com/apache/mina-sshd/pull/530#issuecomment-2242903280 > In chacha20-poly1305, would it make sense to use a different mechanism for `unpackIntLE` and `packIntLE`, such as using `Unsafe` or `VarHandle` ? `VarHandle` doesn't exist in Ja

Re: [PR] Performance optimizations [mina-sshd]

2024-07-21 Thread via GitHub
tomaswolf commented on PR #530: URL: https://github.com/apache/mina-sshd/pull/530#issuecomment-2241789991 Haven't looked at further optimizations. Most of the time is spent in Poly1305.processBlock() anyway. We could continue looking at trying to make this cipher and mac faster, but for now

Re: [PR] Performance optimizations [mina-sshd]

2024-07-21 Thread via GitHub
gnodet commented on PR #530: URL: https://github.com/apache/mina-sshd/pull/530#issuecomment-2241748095 > In chacha20-poly1305, would it make sense to use a different mechanism for `unpackIntLE` and `packIntLE`, such as using `Unsafe` or `VarHandle` ? > > I've also seen that there is a

Re: [PR] Performance optimizations [mina-sshd]

2024-07-21 Thread via GitHub
gnodet commented on PR #530: URL: https://github.com/apache/mina-sshd/pull/530#issuecomment-2241745950 In chacha20-poly1305, would it make sense to use a different mechanism for `unpackIntLE` and `packIntLE`, such as using `Unsafe` or `VarHandle` ? I've also seen that there is a [mult

Re: [I] sftp clients based on the Mina-sshd and JSCH components upload and download files at very different speeds [mina-sshd]

2024-07-21 Thread via GitHub
czldb2 commented on issue #524: URL: https://github.com/apache/mina-sshd/issues/524#issuecomment-2241592988 > What ciphers were used? If you compare JSch with native AES against MINA sshd with ChaCha20-Poly1305, 10% is about to be expected. ![17215643784088](https://github.com/user-attac

Re: [I] sftp clients based on the Mina-sshd and JSCH components upload and download files at very different speeds [mina-sshd]

2024-07-21 Thread via GitHub
tomaswolf commented on issue #524: URL: https://github.com/apache/mina-sshd/issues/524#issuecomment-2241583891 What ciphers were used? If you compare JSch with native AES against MINA sshd with ChaCha20-Poly1305, 10% is about to be expected. -- This is an automated message from the Apache

Re: [I] sftp clients based on the Mina-sshd and JSCH components upload and download files at very different speeds [mina-sshd]

2024-07-21 Thread via GitHub
czldb2 commented on issue #524: URL: https://github.com/apache/mina-sshd/issues/524#issuecomment-2241581503 ![image](https://github.com/user-attachments/assets/330691da-44a4-4256-87c8-20320638adfb) I did 20 initial attempts locally, comparing the optimized code with the pre-optimized cod

Re: [I] Restricting User Access to Specific Directories in Apache SSHD SFTP Server [mina-sshd]

2024-07-20 Thread via GitHub
tomaswolf commented on issue #534: URL: https://github.com/apache/mina-sshd/issues/534#issuecomment-2241266393 1. Version 1.7.0 is very old. 2. We cannot help you debug your code. For instance: did you check that UserManager (seems to be your own code) returns the right user? -- This i

Re: Bugfix Release 2.13.2 for Apache MINA sshd?

2024-07-20 Thread Gary Gregory
Thanks you for the detailed explanation Thomas :) Gary On Sat, Jul 20, 2024, 12:34 PM Thomas Wolf wrote: > On 20.07.24 14:52 , Gary Gregory wrote: > > Could this be achieved via a mock, if only to validate that a regression > > won't happen? > > Assuming we'd want to test that on an XDH instant

Re: Bugfix Release 2.13.2 for Apache MINA sshd?

2024-07-20 Thread Thomas Wolf
On 20.07.24 14:52 , Gary Gregory wrote: Could this be achieved via a mock, if only to validate that a regression won't happen? Assuming we'd want to test that on an XDH instantiated with raw=true calculateK() returns the full 32 bytes of the secret resulting from a curve25519 key agreement even

Re: Bugfix Release 2.13.2 for Apache MINA sshd?

2024-07-20 Thread Gary Gregory
Could this be achieved via a mock, if only to validate that a regression won't happen? Gary On Sat, Jul 20, 2024, 7:09 AM Thomas Wolf wrote: > On 20.07.24 01:46 , Gary Gregory wrote: > > I don't see a matching unit test in [2] so we are asking for a future > > regression IMO... > > This _is_

Re: Bugfix Release 2.13.2 for Apache MINA sshd?

2024-07-20 Thread Thomas Wolf
On 20.07.24 01:46 , Gary Gregory wrote: > I don't see a matching unit test in [2] so we are asking for a future > regression IMO... This _is_ tested. Our tests connect to old OpenSSH, not using this key exchange method, and to new OpenSSH method, where it is used. The problem is that to test thi

Re: Bugfix Release 2.13.2 for Apache MINA sshd?

2024-07-19 Thread Gary Gregory
I don't see a matching unit test in [2] so we are asking for a future regression IMO... Gary On Fri, Jul 19, 2024, 5:34 PM Thomas Wolf wrote: > Could we do a bugfix release 2.13.2 for Apache MINA sshd, > please? > > I know it's only one change, but I think it's worth it. > > In 2.13.0 we had in

Re: [I] server host key algorithms = ssh-rsa but still try to encryp the key using rsa-sha2-512 [mina-sshd]

2024-07-19 Thread via GitHub
tomaswolf commented on issue #531: URL: https://github.com/apache/mina-sshd/issues/531#issuecomment-2238592641 > That's a client bug; it should not have continued with public-key authentication. Split to #533. -- This is an automated message from the Apache Git Service. To respond

Re: [I] GitSshdSessionFactory - why do I need a credentialsProvider if I've configured the SshSessionFactory? [mina-sshd]

2024-07-18 Thread via GitHub
tomaswolf commented on issue #532: URL: https://github.com/apache/mina-sshd/issues/532#issuecomment-2237635271 I don't know why the `GitSshdSession` asks for a password up front. It should set appropriate `FilePasswordProvider` and `UserInteraction` implementations based on the JGit `Creden

Re: [I] sftp clients based on the Mina-sshd and JSCH components upload and download files at very different speeds [mina-sshd]

2024-07-17 Thread via GitHub
czldb2 commented on issue #524: URL: https://github.com/apache/mina-sshd/issues/524#issuecomment-2235000412 > I found a couple of things that could be improved; for details see PR #530. > > While comparing out-of-the-box performance of JSch and sshd is legitimate, one needs to be awar

Re: [I] server host key algorithms = ssh-rsa but still try to encryp the key using rsa-sha2-512 [mina-sshd]

2024-07-17 Thread via GitHub
tomaswolf commented on issue #531: URL: https://github.com/apache/mina-sshd/issues/531#issuecomment-2233678514 > your really only option is to force "ssh-rsa" for connecting to such a server Interestingly, JSch seems to have the same problem with this XFB.Gateway: https://github.com/

Re: [I] server host key algorithms = ssh-rsa but still try to encryp the key using rsa-sha2-512 [mina-sshd]

2024-07-17 Thread via GitHub
tomaswolf commented on issue #531: URL: https://github.com/apache/mina-sshd/issues/531#issuecomment-2233656599 Sorry. I completely missed that the log indeed has a SSH_MSG_USERAUTH_PK_OK reply from the server. Your log is hard to understand; apparently lines with the same time

Re: [I] server host key algorithms = ssh-rsa but still try to encryp the key using rsa-sha2-512 [mina-sshd]

2024-07-17 Thread via GitHub
baiglin commented on issue #531: URL: https://github.com/apache/mina-sshd/issues/531#issuecomment-2233294642 Thanks a lot @tomaswolf ... and for me to understand, sorry for that, From the code logging: processAuthDataRequest(ClientSessionImpl[amadeus@/10.243.2.50:6710])[ssh-connectio

Re: [I] server host key algorithms = ssh-rsa but still try to encryp the key using rsa-sha2-512 [mina-sshd]

2024-07-17 Thread via GitHub
tomaswolf commented on issue #531: URL: https://github.com/apache/mina-sshd/issues/531#issuecomment-2233155209 Actually, I remember now that we ran into this long ago in JGit already. The approach taken there was simply "if you need to connect with RSA keys to legacy servers that don't supp

Re: [I] server host key algorithms = ssh-rsa but still try to encryp the key using rsa-sha2-512 [mina-sshd]

2024-07-17 Thread via GitHub
tomaswolf commented on issue #531: URL: https://github.com/apache/mina-sshd/issues/531#issuecomment-2232628994 BTW: the server is XFB.Gateway. I'm surprised it doesn't support modern signature algorithms. Using the old SHA1-based ssh-rsa signatures is a security risk. The vendor suggests up

Re: [I] server host key algorithms = ssh-rsa but still try to encryp the key using rsa-sha2-512 [mina-sshd]

2024-07-17 Thread via GitHub
tomaswolf commented on issue #531: URL: https://github.com/apache/mina-sshd/issues/531#issuecomment-2232576893 The key exchange worked and did use a ssh-rsa signature. It's the public key authentication that then uses rsa-sha-512 by default first. Apparently the server is configured with [

Re: [I] Performance Disparity Between Apache Mina and JSCH [mina-sshd]

2024-07-16 Thread via GitHub
tomaswolf closed issue #478: Performance Disparity Between Apache Mina and JSCH URL: https://github.com/apache/mina-sshd/issues/478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] Perfomance file transfer [mina-sshd]

2024-07-16 Thread via GitHub
tomaswolf commented on issue #485: URL: https://github.com/apache/mina-sshd/issues/485#issuecomment-2231866043 No reply; closing this. Further performance discussions can be held in issue #524 for now. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Perfomance file transfer [mina-sshd]

2024-07-16 Thread via GitHub
tomaswolf closed issue #485: Perfomance file transfer URL: https://github.com/apache/mina-sshd/issues/485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [I] sftp clients based on the Mina-sshd and JSCH components upload and download files at very different speeds [mina-sshd]

2024-07-16 Thread via GitHub
tomaswolf commented on issue #524: URL: https://github.com/apache/mina-sshd/issues/524#issuecomment-2231648732 I found a couple of things that could be improved; for details see PR #530. While comparing out-of-the-box performance of JSch and sshd is legitimate, one needs to be aware t

Re: [PR] Make the proxy jump resolver a bit more flexible. [mina-sshd]

2024-07-15 Thread via GitHub
tomaswolf commented on PR #477: URL: https://github.com/apache/mina-sshd/pull/477#issuecomment-2230137503 See https://github.com/apache/mina-sshd/blob/master/docs/changes/2.13.0.md. It does mention the issue. (Use 2.13.1. Publishing to Maven Central of 2.13.0 omitted the source bundles.)

Re: [I] The sftp session fails to reuse the clientSession of the ssh session. Procedure [mina-sshd]

2024-07-15 Thread via GitHub
czldb2 closed issue #529: The sftp session fails to reuse the clientSession of the ssh session. Procedure URL: https://github.com/apache/mina-sshd/issues/529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] The sftp session fails to reuse the clientSession of the ssh session. Procedure [mina-sshd]

2024-07-15 Thread via GitHub
czldb2 commented on issue #529: URL: https://github.com/apache/mina-sshd/issues/529#issuecomment-2229776246 > Don't know. Version 1.7.0 is very old. I don't understand what you are asking, and I don't understand why you mention ClientSession when you're implementing a server. Maybe search f

Re: [PR] Make the proxy jump resolver a bit more flexible. [mina-sshd]

2024-07-15 Thread via GitHub
nightman68 commented on PR #477: URL: https://github.com/apache/mina-sshd/pull/477#issuecomment-2229503096 In what release the changes will be included? I can't find this information... -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] init [mina]

2024-07-15 Thread via GitHub
elecharny commented on PR #45: URL: https://github.com/apache/mina/pull/45#issuecomment-2229323694 Rejected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] init [mina]

2024-07-15 Thread via GitHub
elecharny closed pull request #45: init URL: https://github.com/apache/mina/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina

Re: [PR] V2.0.19 note [mina]

2024-07-15 Thread via GitHub
elecharny commented on PR #46: URL: https://github.com/apache/mina/pull/46#issuecomment-2229320516 what's the point in merging 10 years old commits in MINA's trunk, which is way ahead??? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] V2.0.19 note [mina]

2024-07-15 Thread via GitHub
elecharny closed pull request #46: V2.0.19 note URL: https://github.com/apache/mina/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

Re: [I] The sftp session fails to reuse the clientSession of the ssh session. Procedure [mina-sshd]

2024-07-15 Thread via GitHub
tomaswolf commented on issue #529: URL: https://github.com/apache/mina-sshd/issues/529#issuecomment-2229276403 Don't know. Version 1.7.0 is very old. I don't understand what you are asking, and I don't understand why you mention ClientSession when you're implementing a server. Maybe search

Re: [I] sntrup761x25519-sha...@openssh.com KEX causing "incorrect signature" with OpenSSH client [mina-sshd]

2024-07-15 Thread via GitHub
tomaswolf closed issue #525: sntrup761x25519-sha...@openssh.com KEX causing "incorrect signature" with OpenSSH client URL: https://github.com/apache/mina-sshd/issues/525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] GH-525: Fix sntrup761x25519-sha512 [mina-sshd]

2024-07-15 Thread via GitHub
tomaswolf merged PR #528: URL: https://github.com/apache/mina-sshd/pull/528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.

Re: [I] Looking for release date for next release of mina-sshd [mina-sshd]

2024-07-13 Thread via GitHub
tomaswolf commented on issue #487: URL: https://github.com/apache/mina-sshd/issues/487#issuecomment-2226906222 Apache MINA sshd 2.13.1 is released and available in Maven Central. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Looking for release date for next release of mina-sshd [mina-sshd]

2024-07-13 Thread via GitHub
tomaswolf closed issue #487: Looking for release date for next release of mina-sshd URL: https://github.com/apache/mina-sshd/issues/487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] sntrup761x25519-sha...@openssh.com KEX causing "incorrect signature" with OpenSSH client [mina-sshd]

2024-07-11 Thread via GitHub
tomaswolf commented on issue #525: URL: https://github.com/apache/mina-sshd/issues/525#issuecomment-550618 As far as I see all checks for Bouncy Castle and that eddsa library being available are done. There is nothing to do in that respect. _However:_ There is indeed

Re: [I] sntrup761x25519-sha...@openssh.com KEX causing "incorrect signature" with OpenSSH client [mina-sshd]

2024-07-10 Thread via GitHub
JinHeap commented on issue #525: URL: https://github.com/apache/mina-sshd/issues/525#issuecomment-2221940190 i test client need package eddsa-0.3.0.jar at ``` net.i2p.crypto eddsa true ``` you can try like this

<    1   2   3   4   5   6   7   8   9   10   >