Re: use isPrimitive() instead of comparing the string to a list of primitives

2008-02-07 Thread Stivo
There is a first time for everything :) I did, https://issues.apache.org/jira/browse/DIRMINA-529 Greetz, Stivo Maarten Bosteels wrote: > > Could you create a JIRA ticket and attach your patch to it ? > And don't forget to click the radio button that says > 'Grant license to ASF for inclusion

Re: use isPrimitive() instead of comparing the string to a list of primitives

2008-02-07 Thread Maarten Bosteels
Could you create a JIRA ticket and attach your patch to it ? And don't forget to click the radio button that says 'Grant license to ASF for inclusion in ASF works (as per the Apache Software License ยง5)' Thanks Maarten On Feb 7, 2008 10:25 AM, Maarten Bosteels <[EMAIL PROTECTED]> wrote: > Hi Sti

Re: use isPrimitive() instead of comparing the string to a list of primitives

2008-02-07 Thread Maarten Bosteels
Hi Stivo, Thanks for the patch ! I will have a look at it. Maarten On Feb 7, 2008 9:56 AM, Stivo <[EMAIL PROTECTED]> wrote: > > I figured out how to make a patch so here goes. > I ran the maven test with it, and it ran fine. > > Index: C:/Users/Stivo/workspacenew/mina > trunk/core/src/main/java

Re: use isPrimitive() instead of comparing the string to a list of primitives

2008-02-07 Thread Stivo
I figured out how to make a patch so here goes. I ran the maven test with it, and it ran fine. Index: C:/Users/Stivo/workspacenew/mina trunk/core/src/main/java/org/apache/mina/common/IoBuffer.java === --- C:/Users/Stivo/workspacenew/