Re: Releasing a MINA 2.2.0-alpha soon ?

2022-04-04 Thread Emmanuel Lécharny
Ok, tested MINA 2.2.0-SNAPSHOT with FtpServer, Apache LDAP API and Apache Directoryserver, all is good. May we cut a milestone ? On 01/04/2022 18:56, Emmanuel Lécharny wrote: Yu didn't cause any problem. This is just a bug, anybody could have been caught by this one. I didn't expect that the

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-04-04 Thread Emmanuel Lécharny
Hi! whener ‹e do a mvn deploy, the snapshots are deployed to https://repository.apache.org/content/repositories/snapshots/org/apache/mina/mina-core/2.2.0-SNAPSHOT/ It's enough to specify this repository in your parent pom to get it found: ... apache.snapshots Apa

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-04-01 Thread Christoph John
Just a quick question: are the 2.2.0-SNAPSHOT builds continously being uploaded or do you need to trigger this manually? Thanks Am 1. April 2022 18:56:35 MESZ schrieb "Emmanuel Lécharny" : >Yu didn't cause any problem. This is just a bug, anybody could have >been >caught by this one. I didn'

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-04-01 Thread Emmanuel Lécharny
Yu didn't cause any problem. This is just a bug, anybody could have been caught by this one. I didn't expect that the state would be squashed if you apply both NEED and WANT flag, and IMHO, it's a very bad API design from Sun. It was painful to find because I had to go deep into the Java SSL c

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-04-01 Thread Jonathan Valliere
Did I cause that problem because I remember there being a bug request because we weren’t applying the Need and Want from the Impl config. On Fri, Apr 1, 2022 at 10:55 AM Emmanuel Lécharny wrote: > Got it !!! > > What a nasty bug it was... > > The new SslFilter.createEngine() method was doing: >

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-04-01 Thread Emmanuel Lécharny
Got it !!! What a nasty bug it was... The new SslFilter.createEngine() method was doing: protected SSLEngine createEngine(IoSession session, InetSocketAddress addr) { SSLEngine sslEngine = (addr != null) ? sslContext.createSSLEngine(addr.getHostString(), addr.getPort())

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-04-01 Thread Emmanuel Lécharny
Some progress: With MINA 2.1.5, the SSLEngine.SSLConfiguration instance has the clientAuthType set to CLIENT_AUTH_REQUIRED, while in MINA 2.2.0, it's set to CLIENT_AUTH_NONE. That explain why the CertificateRequest is not sent to the client. Now to understand why this flag is improperly set.

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-04-01 Thread Emmanuel Lécharny
Still fighting... When using MINA 2.1.6, I see that the client (FTPSCLient, a java class that is not using MINA) sends a client Certificate to the server after having received a CertificateRequest: javax.net.ssl|FINE|01|main|2022-04-01 09:58:48.544 CEST|CertificateRequest.java:692|Consuming

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-03-31 Thread Emmanuel Lécharny
Ok, pb fixed with an added filter. Now, I still get a NPE while trying to access the peerCertificate from the session, even after the Handshake has been completed... On 30/03/2022 18:02, Emmanuel Lécharny wrote: Hi Jonathan, no, it's just that we try to send a clear text message after having

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-03-30 Thread Emmanuel Lécharny
Yep. But slightly more complicated for me, as I don't exactly know FtpServer code inside out :-) Regardless, that should not forbid us to cut a release. On 30/03/2022 19:30, Jonathan Valliere wrote: Ah so same thing as LDAP where you have to move that clear text message into a part of the filt

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-03-30 Thread Emmanuel Lécharny
... which is not that easy :/ I guess I have to use a dedicated filter once again for that purpose. On 30/03/2022 18:02, Emmanuel Lécharny wrote: Hi Jonathan, no, it's just that we try to send a clear text message after having set the SSLFilter, pretty much as what we had to workaround in Dir

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-03-30 Thread Emmanuel Lécharny
Hi Jonathan, no, it's just that we try to send a clear text message after having set the SSLFilter, pretty much as what we had to workaround in Directory. I'm going to fix that. On 25/03/2022 19:48, Jonathan Valliere wrote: Are you trying to get the peer cert after the filter emits the conne

Re: Releasing a MINA 2.2.0-alpha soon ?

2022-03-25 Thread Jonathan Valliere
Are you trying to get the peer cert after the filter emits the connected after the handshake completes? If you do it too early it won’t populate. On Fri, Mar 25, 2022 at 2:33 PM Emmanuel Lécharny wrote: > Hi! > > following the effort put in rewriting the Sslfilter (and all the inner > code) by J

Releasing a MINA 2.2.0-alpha soon ?

2022-03-25 Thread Emmanuel Lécharny
Hi! following the effort put in rewriting the Sslfilter (and all the inner code) by Jonathan lately, I would like to know if we could mive forward with an alpha version of this work. I have tested it with Apache LDAP API and Apache Directory Server, with success. I still have some work to do