Hi,
Thanks a lot Mark.
Julien
On Sat, 8 Nov 2008 20:33:17 -0500
Mark Webb [EMAIL PROTECTED] wrote:
I just went ahead and fixed the errors.
On Sat, Nov 8, 2008 at 8:30 PM, Mark Webb [EMAIL PROTECTED]
wrote:
Getting compilation errors. Cannot find the TrafficMask class:
Getting compilation errors. Cannot find the TrafficMask class:
/Users/elihusmails/dev/mina/mina-cleaning/core/src/main/java/org/apache/mina/core/filterchain/IoFilter.java:[25,35]
cannot find symbol
symbol : class TrafficMask
location: package org.apache.mina.core.session
I just went ahead and fixed the errors.
On Sat, Nov 8, 2008 at 8:30 PM, Mark Webb [EMAIL PROTECTED] wrote:
Getting compilation errors. Cannot find the TrafficMask class:
/Users/elihusmails/dev/mina/mina-cleaning/core/src/main/java/org/apache/mina/core/filterchain/IoFilter.java:[25,35]
cannot
+1
On Wed, Nov 5, 2008 at 1:16 PM, Maarten Bosteels
[EMAIL PROTECTED] wrote:
+1
On Wed, Nov 5, 2008 at 3:01 PM, Julien Vermillard [EMAIL PROTECTED]wrote:
I would like to propose :
- ignore setTrafficMask events in the filter chain (looks like Mark is
already agreeing)
- remove
On Tue, 04 Nov 2008 18:24:15 +0100
Emmanuel Lecharny [EMAIL PROTECTED] wrote:
Maarten Bosteels wrote:
Wasn't it an attempt to implement throttling ?
I have no idea. The documentation is pretty scarse, it's not used
anywhere but as a parameter passed from method to method, the event
I would like to propose :
- ignore setTrafficMask events in the filter chain (looks like Mark is
already agreeing)
- remove setTrafficMask(..) and keep the following IoSession methods :
suspendRead(), suspendWrite(), resumeRead(), resumeWrite()
which naming is much better and add
+1 to remove it.
On Wed, Nov 5, 2008 at 3:36 AM, Julien Vermillard
[EMAIL PROTECTED] wrote:
On Tue, 04 Nov 2008 18:24:15 +0100
Emmanuel Lecharny [EMAIL PROTECTED] wrote:
Maarten Bosteels wrote:
Wasn't it an attempt to implement throttling ?
I have no idea. The documentation is pretty
+1
On Wed, Nov 5, 2008 at 3:01 PM, Julien Vermillard [EMAIL PROTECTED]wrote:
I would like to propose :
- ignore setTrafficMask events in the filter chain (looks like Mark is
already agreeing)
- remove setTrafficMask(..) and keep the following IoSession methods :
suspendRead(),
Hi,
There is something in MINA who has hook everywhere in the core, it's
traffic mask. As far I understand the concept, the idea is to be able
to block read and/or writes using session.setTrafficMask(...), I never
needed it, and I wonder who use it and for what exactly ?
Julien
signature.asc
Wasn't it an attempt to implement throttling ?
When requests are coming in faster than they're being processed
= set TrafficMask to block reading
= TCP buffers will fill up (OS level)
= TCP will tell sender to slow down
= OOM prevented
when queue of incoming messages gets smaller = resume
Maarten Bosteels wrote:
Wasn't it an attempt to implement throttling ?
I have no idea. The documentation is pretty scarse, it's not used
anywhere but as a parameter passed from method to method, the event
type is never used to create an event ...
When requests are coming in faster than
It was used by Read/WriteThrottlingFilter wich was removed of 2.0 :
http://www.nabble.com/Dropping-traffic-throttling-from-2.0-td16092085.html
as said by Emm look like it's used nowhere is MINA codebase.
As said by Trustin in this mail the remplacement is supposed to be
o.a.m.f.executor.* and no
12 matches
Mail list logo
