Re: [apache/incubator-mxnet] [RFC] Large MXNet source files causing CI build failures (#19688)

2020-12-21 Thread kpuatamazon
A related problem is excessive code generation. Take `np.delete` for example. https://github.com/apache/incubator-mxnet/blob/16e2b15f6e334ca88f29b9c14e55547df2c136fc/src/operator/numpy/np_delete_op-inl.h#L337-L355 That's: - MSHADOW_TYPE_SWITCH: 8 types on CPU and 7 types on GPU. - MXNET_NDIM_S

Re: [apache/incubator-mxnet] [RFC] v1.8.0 release (#18800)

2020-09-07 Thread kpuatamazon
@fhieber wants #19099 supporting the intgemm library so that https://github.com/awslabs/sockeye version 2 (based on MXNet 1.x) can be installed with `pip`. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/apache/incuba

Re: [apache/incubator-mxnet] [RFC] MXNet external operators (#18904)

2020-08-17 Thread kpuatamazon
What about cmake subprojects? As in use MXNet as a subproject of the external library. -- You are receiving this because your review was requested. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-mxnet/pull/18904#issuecomment-674993612

Re: [apache/incubator-mxnet] [RFC] MXNet external operators (#18904)

2020-08-17 Thread kpuatamazon
I think this would be much cleaner if it was a separate directory because: - Version control is much easier. Just update mxnet or `rm -rf` it without extra cruft - This reflects reality much better. Somebody else builds mxnet for `pip` without knowing about my stuff. MXNet ships a docker in wh

Re: [apache/incubator-mxnet] [RFC] MXNet external operators (#18904)

2020-08-17 Thread kpuatamazon
What sort of binary compatibility guarantees does MXNet make for this interface? If the safe option is always to compile at the same time, I don't see much difference from including it in the build? -- You are receiving this because your review was requested. Reply to this email directly or