Re: Use unique_ptr on Executor creation

2017-11-22 Thread Steffen Rochel
-1 (non-binding) I suggest we go with the proposed content and timeline for 1.0. Steffen On Wed, Nov 22, 2017 at 2:58 PM Pedro Larroy wrote: > Hi > > I would like to make a minor change of the cpp package for 1.0 by > returning a unique_ptr when creating Engine. > > This is a C++ idiom that prev

[BUILD FAILED] Branch master build 680

2017-11-22 Thread Apache Jenkins Server
Build for MXNet branch master has broken. Please view the build at https://builds.apache.org/job/incubator-mxnet/job/master/680/

[BUILD FAILED] Branch master build 679

2017-11-22 Thread Apache Jenkins Server
Build for MXNet branch master has broken. Please view the build at https://builds.apache.org/job/incubator-mxnet/job/master/679/

Use unique_ptr on Executor creation

2017-11-22 Thread Pedro Larroy
Hi I would like to make a minor change of the cpp package for 1.0 by returning a unique_ptr when creating Engine. This is a C++ idiom that prevents memory leaks and fixes one leak in the examples. As before it requires explicit delete as the ownership of the pointer is not clear from the API call

[BUILD FAILED] Branch master build 677

2017-11-22 Thread Apache Jenkins Server
Build for MXNet branch master has broken. Please view the build at https://builds.apache.org/job/incubator-mxnet/job/master/677/

[BUILD FAILED] Branch master build 676

2017-11-22 Thread Apache Jenkins Server
Build for MXNet branch master has broken. Please view the build at https://builds.apache.org/job/incubator-mxnet/job/master/676/

[BUILD FAILED] Branch master build 675

2017-11-22 Thread Apache Jenkins Server
Build for MXNet branch master has broken. Please view the build at https://builds.apache.org/job/incubator-mxnet/job/master/675/

[BUILD FAILED] Branch master build 673

2017-11-22 Thread Apache Jenkins Server
Build for MXNet branch master has broken. Please view the build at https://builds.apache.org/job/incubator-mxnet/job/master/673/

[BUILD FAILED] Branch master build 674

2017-11-22 Thread Apache Jenkins Server
Build for MXNet branch master has broken. Please view the build at https://builds.apache.org/job/incubator-mxnet/job/master/674/