[BUILD FAILED] Branch master build 697

2017-11-29 Thread Apache Jenkins Server
Build for MXNet branch master has broken. Please view the build at https://builds.apache.org/job/incubator-mxnet/job/master/697/

Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

2017-11-29 Thread Meghna Baijal
Hello Justin, Henri, Thank you for your input. Justin, Chris ran Apache Rat on MXNet this morning. Several issues found here, in addition to your comments that needed a fix have been addressed in the following 2 PRS - 1. https://github.com/apache/incubator-mxnet/pull/8873/ 2. https://github.com/ap

FYI: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0

2017-11-29 Thread Hen
Sorry, I should have cc'd dev@ on this. -- Forwarded message -- From: Hen Date: Wed, Nov 29, 2017 at 1:59 PM Subject: Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC0 To: gene...@incubator.apache.org Thanks Justin. Some comments inline on ones I don't think need fixing; b

Re: CODEOWNERS file being removed

2017-11-29 Thread Chris Olivier
ok On Wed, Nov 29, 2017 at 1:42 PM, Tianqi Chen wrote: > Codeowner feature is used to automatically trigger the review request for > the people. All the committers are already listed as global owners, which > is consistent with Apache's policy > > Tianqi > > On Wed, Nov 29, 2017 at 1:37 PM, Hen

Re: CODEOWNERS file being removed

2017-11-29 Thread Chris Olivier
If you can push back on Justin, I can keep it. Just not looking forward to going through all of this again just to have it bounced back. On Wed, Nov 29, 2017 at 1:37 PM, Hen wrote: > Was there more discussion than Justin's question about it on general@? > > My memory of CODEOWNERS was that it w

Re: CODEOWNERS file being removed

2017-11-29 Thread Tianqi Chen
Codeowner feature is used to automatically trigger the review request for the people. All the committers are already listed as global owners, which is consistent with Apache's policy Tianqi On Wed, Nov 29, 2017 at 1:37 PM, Hen wrote: > Was there more discussion than Justin's question about it o

Re: CODEOWNERS file being removed

2017-11-29 Thread Hen
Was there more discussion than Justin's question about it on general@? My memory of CODEOWNERS was that it was related to some code review tool, but looking at the history of dev@ I only see: "Can't have changes merged into it until changes to files that have a designated code owner

CODEOWNERS file being removed

2017-11-29 Thread Chris Olivier
Per suggestion from Apache, we are removing CODEOWNERS file from root of mxnet. If there are any objections, please voice them: Here are the contents of rht file: # Owners of Apache MXNet # Global owners *@apache/mxnet-committers # Owners of language bindings R-package/* @thirdwin