Re: Increase indentation limit from 100 to 120 characters

It's probably good to have an example to help with discussion. Here's one that's been bugging us, and highlights why the current line length limit in C++ leads to hard-to-read code: https://github.com/larroy/mxnet/blob/467a79c8b9f3a75ce993302c6d0c858628cb1cdc/tests/cpp/operator/batchnorm_test.cc#L

Re: Commiter access to Jenkins Sevrer

Regarding the proposed permissions, I would like stricter permissions. I think a committer should be able to stop-start-cancel jobs. But I think only admins should be able to create new jobs, otherwise we run the risk of the CI becoming a mess of jobs that nobody owns and maintains. Please let's on

Re: Commiter access to Jenkins Sevrer

I agree with Pedros points. We've got a test-system running at http://jenkins.mxnet-ci-dev.amazon-ml.com and all changes should be tested there before they are deployed to prod. For now, we can move forward as-is and I would kindly ask the committers to check back with me if any changes are require

[DISCUSS] Seeding and determinism on multi-gpu systems.

Hello MXNet devs, I wanted to see what people thought about the follow section of code, which I think has some subtle pros/cons: https://github.com/apache/incubator-mxnet/blob/d2a856a3a2abb4e72edc301b8b821f0b75f30722/src/resource.cc#L188 Tobi (tdomhan) from sockeye pointed it out to me after he s

Re: Increase indentation limit from 100 to 120 characters

For languages like C++ and Java it is hard to stay within 80 columns without resorting to overly terse naming scheme or awkward indentation. 120 really makes a lot of sense for C++ and it seems easier to adopt the same standard throughout the codebase since it may be annoying or difficult to con

Re: [DISCUSS] Seeding and determinism on multi-gpu systems.

Is it explicitly defined somewhere that random number generators should always return a deterministic set of numbers given the same seed, or is that just a side-effect of some hardware not having a better way to generate random numbers so they use a user-defined seed to kick off the randomization s

Re: Increase indentation limit from 100 to 120 characters

+1 on 80 columns being a legacy standard which makes no sense today On Mon, Jan 8, 2018 at 9:45 AM, Barber, Christopher < christopher.bar...@analog.com> wrote: > For languages like C++ and Java it is hard to stay within 80 columns > without resorting to overly terse naming scheme or awkward inden

Re: Increase indentation limit from 100 to 120 characters

I think this code should be refactored instead of increasing the indent. Puting the test codes within 7 nested for loops is hard to read. Maybe we can split it into multiple functions, or create some templates, or try "using mxnet::op::BatchNormV1Prop" In general, I feel 80-column is not a big pro

Re: Increase indentation limit from 100 to 120 characters

BTW, the current limit is 100 loc instead of 80 loc, which is mostly enough Tianqi On Mon, Jan 8, 2018 at 11:12 AM, Mu Li wrote: > I think this code should be refactored instead of increasing the indent. > Puting the test codes within 7 nested for loops is hard to read. Maybe we > can split it

Re: Increase indentation limit from 100 to 120 characters

I don't care that much either way (100 or 120) because I twist my monitors vertically, so I have a lot of lines of code on the screen compared to most people and I am reasonably used to 100 at this point, but there's a lot of points like "our competitor does it this way" and "we've always done it t

Re: Increase indentation limit from 100 to 120 characters

I don't think there is a strong argument in either way and an easy thing is to stay things as it is. I think it is just adoption of mindset or social momentum. Tianqi On Mon, Jan 8, 2018 at 11:35 AM, Chris Olivier wrote: > I don't care that much either way (100 or 120) because I twist my monito

Re: Increase indentation limit from 100 to 120 characters

I read more google codes instead of amazon codes. That's why I used Google for example, not because Google is "our competitor", which term is actually disallowed to say by amazon employees. I think the question is not "there's a good reason *not to* increase", but "why we want to make such a chang

Module maintainers proposal

It has been a while for discussing having maintainers for individual modules. A maintainer for a module will be the main person who reviews and approves PRs contributed to that module. Currently, some maintainers are listed in the file CODEOWNERS

Re: Handling secrets in Jenkins

I suggest to use 2) for simplicity, especially given Jenkins is not very secure in some aspects. I remember about a half year ago I forgot to upgrade the jenkins server in time, someone then installed a coin miner on all slaves.. On Sat, Jan 6, 2018 at 2:23 PM, Marco de Abreu wrote: > Hello, > >

Re: Module maintainers proposal

+1 for adding @CodingCat (Nan Zhu) as owner of Scala package. 2018-01-08 21:58 GMT-08:00 Mu Li : > It has been a while for discussing having maintainers for individual > modules. A maintainer for a module will be the main person who reviews and > approves PRs contributed to that module. > > Curre

Re: Module maintainers proposal

Lgtm Am 09.01.2018 8:24 vorm. schrieb "YiZhi Liu" : > +1 for adding @CodingCat (Nan Zhu) as owner of Scala package. > > 2018-01-08 21:58 GMT-08:00 Mu Li : > > > It has been a while for discussing having maintainers for individual > > modules. A maintainer for a module will be the main person who