RFC: Proposal for merging Julia binding (MXNet.jl) into main repo

2018-02-27 Thread Iblis Lin
Hi, Original discussion is here: https://github.com/apache/incubator-mxnet/pull/8727#issuecomment-368495179 The state quo: Julia binding is hosted in a separated repo `dmlc/MXNet.jl`[1], Julia binding has its own documentation hosting[2] and release cycle[3]. The problem: We ran into libmxnet in

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Nan Zhu
sure, will reflect it when add the content of the vote to the wiki On Tue, Feb 27, 2018 at 2:46 PM, Suneel Marthi wrote: > On Tue, Feb 27, 2018 at 11:44 PM, Marco de Abreu < > marco.g.ab...@googlemail.com> wrote: > > > I don't think the [MODULE NAME] is feasible. A modification in the > backend

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Suneel Marthi
On Tue, Feb 27, 2018 at 11:44 PM, Marco de Abreu < marco.g.ab...@googlemail.com> wrote: > I don't think the [MODULE NAME] is feasible. A modification in the backend > often requires changes in multiple interface languages. I think we should > rather tag the JIRA issues properly. > > But since this

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Marco de Abreu
I don't think the [MODULE NAME] is feasible. A modification in the backend often requires changes in multiple interface languages. I think we should rather tag the JIRA issues properly. But since this is a minor detail, I'll +1 considering the time running out. -Marco On Tue, Feb 27, 2018 at 11:

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Yuan Tang
+1 On Tue, Feb 27, 2018 at 5:31 PM Suneel Marthi wrote: > On Tue, Feb 27, 2018 at 11:23 PM, Nan Zhu wrote: > > > > Any reason u need the [MODULE_NAME] in there > > > > It will help the reviewers to identify what are the interesting PRs to > them > > > > e.g. I am interested in scala package, bu

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Suneel Marthi
On Tue, Feb 27, 2018 at 11:23 PM, Nan Zhu wrote: > > Any reason u need the [MODULE_NAME] in there > > It will help the reviewers to identify what are the interesting PRs to them > > e.g. I am interested in scala package, but > https://github.com/apache/incubator-mxnet/pull/9771, even with a JIRA

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Nan Zhu
> Any reason u need the [MODULE_NAME] in there It will help the reviewers to identify what are the interesting PRs to them e.g. I am interested in scala package, but https://github.com/apache/incubator-mxnet/pull/9771, even with a JIRA id, cannot help me to identify it's a scala part change I may

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Suneel Marthi
On Tue, Feb 27, 2018 at 10:50 PM, Nan Zhu wrote: > Thanks, Suneel! > > the vote still remains sense on its major points > > " > 1. most of PRs should be titled as [MXNET-???][MODULE_NAME] PR short > description, where MXNET-??? is the JIRA ID, MODULE_NAME can be python, > scala, symbol, etc. > A

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Nan Zhu
Thanks, Suneel! the vote still remains sense on its major points " 1. most of PRs should be titled as [MXNET-???][MODULE_NAME] PR short description, where MXNET-??? is the JIRA ID, MODULE_NAME can be python, scala, symbol, etc. 2. only the very tiny fix, e.g. fix a typo, remove some unused varia

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Suneel Marthi
Suggest you see how other projects are doing it - Flink, Kafka or any other project. Yes u r right. When u make a github PR with PR label in title like [Flink-3456] for eg: - that way the corresponding JIRA - Flink-3456 here would be automatically updated. On Tue, Feb 27, 2018 at 10:28 PM, Nan Z

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Nan Zhu
Hi, Suneel, how can we enable it? when we titled JIRA id in pull request, it will synchronized automatically? Best, Nan On Tue, Feb 27, 2018 at 1:23 PM, Suneel Marthi wrote: > All projects on Apache have Jira <---> Github integration in place. > > So its a solved problem - look at Flink, Kafk

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Suneel Marthi
All projects on Apache have Jira <---> Github integration in place. So its a solved problem - look at Flink, Kafka, Mahout, OpenNLP, PredictionIO and every other Apache project - all of them have this working. On Tue, Feb 27, 2018 at 8:35 PM, Steffen Rochel wrote: > Nan - have you looked at p

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Steffen Rochel
Nan - have you looked at plugin's to make the integration and synchronization between Jira and github easier? E.g. https://www.atlassian.com/blog/jira-software/connecting-jira-6-2-github f Ideally one has one button in github to create a Jira and afterwards changes on either github or Jira get sync

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Indhu
+1 to the proposal On Tue, Feb 27, 2018, 9:20 AM Nan Zhu wrote: > ideally, > > users report something fishy in github issue > > when confirmed that it is a bug or something to be improved, we should > create JIRAs > > On Sun, Feb 25, 2018 at 9:31 AM, Chris Olivier > wrote: > > > i believe that

Re: [VOTE] tracking code changes with JIRA by associating pull requests

2018-02-27 Thread Nan Zhu
ideally, users report something fishy in github issue when confirmed that it is a bug or something to be improved, we should create JIRAs On Sun, Feb 25, 2018 at 9:31 AM, Chris Olivier wrote: > i believe that JIRAs are “work items@, while github issues are more like > reporting. at least this