Ah, I see the problem. The real problem is, we shouldn't use diamond include
instead of quotes include for project header, which is cheating cpplint to
consider them as system header. Diamond include should only be used for system
header, including OS header, STL header and host-installed librar
opinions vary. there’s arguments the other way, too, such as an ideal
precompiled header compiler would work best with invariant headers first as
well as template matching order in some cases
On Tue, Jan 8, 2019 at 2:44 PM Pedro Larroy
wrote:
> Hi MXNet community
>
> cpplint seems to complain w
I worked around the case, I saw several cases where project and third
party headers were included with diamond includes instead of quotes.
Agree I think is too much hassle to change the order of includes in
the whole project anyway. But this convention can cause some headers
not to be self sufficie
Hi Pedro,
Interesting topic. Google style does have guidance for this:
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
According to it, the order is,
dir2/foo2.h.
A blank line
C system files.
C++ system files.
A blank line
Other libraries' .h files.
Your project's
Hi MXNet community
cpplint seems to complain when the order of includes is not [own,
system, other]
But the general best practice in C++ is [own, project, 3rd party,
system] for the reasons explained in this stackoverflow answer: (
https://stackoverflow.com/questions/614302/c-header-order )
A
Hi all,
I added a section F in the document that explained the current static-linked
dependencies we used for official release. As there are a few licenses are
under BSD3 and GPL, we need to handle them in our next release. Please take a
look and leave any concerns you may have.
Thanks,
Qing
Congratulation Roshani!
On Tue, Jan 8, 2019 at 8:53 AM Qing Lan wrote:
> Congrats Roshani! Great to have you here!
>
> -Qing
>
> >
> >
> > Congrats Roshani. Well deserved.
> >
> >> On Tue, Jan 8, 2019, 8:29 AM Marco de Abreu wrote:
> >>
> >> Great to have you on board, Roshani!
> >>
> >> -Marc
Congrats Roshani! Great to have you here!
-Qing
>
>
> Congrats Roshani. Well deserved.
>
>> On Tue, Jan 8, 2019, 8:29 AM Marco de Abreu >
>> Great to have you on board, Roshani!
>>
>> -Marco
>>
>> Am Di., 8. Jan. 2019, 15:18 hat Carin Meier
>> geschrieben:
>>
>>> Please join me in welcom
Congrats Roshani. Well deserved.
On Tue, Jan 8, 2019, 8:29 AM Marco de Abreu Great to have you on board, Roshani!
>
> -Marco
>
> Am Di., 8. Jan. 2019, 15:18 hat Carin Meier
> geschrieben:
>
> > Please join me in welcoming Roshani Nagmote as a new committer.
> >
> > She has been active in the pr
Great to have you on board, Roshani!
-Marco
Am Di., 8. Jan. 2019, 15:18 hat Carin Meier
geschrieben:
> Please join me in welcoming Roshani Nagmote as a new committer.
>
> She has been active in the project for quite some time. She has managed the
> 1.3.0 release as well as being involved variou
Dear MXNet community,
I would like to invite you to the regular Apache MXNet (Incubating) User
Group meeting on the 8th of January 2019 [1].
As usually, the meeting will have remote VC, powered by Amazon Chime.
Join the meeting:
https://chime.aws/4899512091
Meeting ID: 4899 51 2091
Best
Anton
Please join me in welcoming Roshani Nagmote as a new committer.
She has been active in the project for quite some time. She has managed the
1.3.0 release as well as being involved various features including the Java
API and ONNX operators.
We are excited to have her onboard as a committer.
Gith
12 matches
Mail list logo