Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc1

2019-06-20 Thread Lai Wei
Hi Anirudh, Thanks for jumping into this quickly, I followed up on the issue. I was meant for sockeye developer/maintainers to help setup nightly tests and raise issues early. Thanks! On Fri, Jun 21, 2019 at 10:10 AM Haibin Lin wrote: > In GluonNLP we are testing with MXNET nightly build for

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc1

2019-06-20 Thread Haibin Lin
In GluonNLP we are testing with MXNET nightly build for each PR, and we did find some MXNet related issue caught by the CI. I recommend other toolkits also add integration tests with MXNet nightly. It helps identify issues early. Best, Haibin On Thu, Jun 20, 2019 at 18:52 Zhao, Patric wrote: >

RE: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc1

2019-06-20 Thread Zhao, Patric
Thanks to raise the issue and we will take a look ASAP. The downstream cases is not in the MXNet CI so it's hard to catch the potential bugs or performance degradation for MXNet developers. In the future, I suggest adding the major downstream test cases, like from sockeye, GluonNLP, GLuonCV,

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc1

2019-06-20 Thread Anirudh Subramanian
Hi Lai, I have opened an issue: https://github.com/apache/incubator-mxnet/issues/15297 I came to know about this issue only today and I have not been monitoring sockeye. I jumped onto this issue to make sure it wasn't caused by the dlpack changes. Also, I don't think sockeye CI checks against

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc1

2019-06-20 Thread Lai Wei
Hi, Could you share which test failed and what’s the crash? How to reproduce it? I was able to install sockeye and run all tests passed. Using python setup.py test I have tested both nightly pip package and 1.5.0.rc1 It would be great to create an issue with reproducible steps and move the

Re: OMP

2019-06-20 Thread Marco de Abreu
As already proposed, I think the easiest way to get a common understanding is if we start with a few docker containers. Pedro, would it be possible for you to wrap your benchmarks into a few containers that will produce your shown results? That way, we can avoid possible misunderstandings and also

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc1

2019-06-20 Thread Anirudh Subramanian
I was able to reproduce a crash with the commit 09202f7f261954383aa387144524d38f83f18d06 but not with the commit a862270beb2d796c1ba311183f7f4a766a18ad6c. Anirudh On Thu, Jun 20, 2019 at 3:53 PM Lai Wei wrote: > Hi Przemyslaw, > > Is there an issue with more details to track the problem? > > >

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc1

2019-06-20 Thread Lai Wei
Hi Przemyslaw, Is there an issue with more details to track the problem? On Fri, Jun 21, 2019 at 6:04 AM Przemysław Trędak wrote: > -1 > > There is a crash in sockeye unit test (python setup.py test) observed > starting with nightly 1.5 build from 6/13 and still occuring in 1.5rc1. I > don't

Re: [VOTE] Release Apache MXNet (incubating) version 1.5.0.rc1

2019-06-20 Thread Przemysław Trędak
-1 There is a crash in sockeye unit test (python setup.py test) observed starting with nightly 1.5 build from 6/13 and still occuring in 1.5rc1. I don't yet have the exact commit that is responsible for it, but it is either a862270beb2d796c1ba311183f7f4a766a18ad6c (dlpack related) or

Re: OMP

2019-06-20 Thread Pedro Larroy
I can confirm that we are linking with two versions of omp, I'm gaining more clarity into this topic, but I have still questions, the facts that I got so far are the folllowing: * #1: We are linking with two versions of omp, intel's omp and llvm openmp when building with MKL enabled. * #2: We

[VOTE] Release Apache MXNet (incubating) version 1.5.0.rc1

2019-06-20 Thread Lai Wei
Dear MXNet community, This is the 3-day vote to release Apache MXNet (incubating) version 1.5.0. Voting on dev@ will start June 19, 23:59:59(PST) and close on June 22, 23:59:59. 1) Link to release notes: https://cwiki.apache.org/confluence/display/MXNET/1.5.0+Release+Notes 2) Link to release