Re: [VOTE] Release Apache MXNet(incubating) version 1.2.0.RC1

2018-05-02 Thread Zheng, Da
I have to agree that the DMLC subrepos do make the development much more difficult sometimes. On 5/2/18, 3:57 AM, "Pedro Larroy" wrote: For me the situation with DMLC is problematic. I often find myself having to fix things in the DMLC subrepos.

Re: [VOTE] Release Apache MXNet(incubating) version 1.2.0.RC1

2018-05-02 Thread Marco de Abreu
Totally agree with Henry and Pedro. On Wed, May 2, 2018 at 12:56 PM, Pedro Larroy wrote: > For me the situation with DMLC is problematic. > > I often find myself having to fix things in the DMLC subrepos. > > * These changes are impossible to test with the MXNet CI

Re: [VOTE] Release Apache MXNet(incubating) version 1.2.0.RC1

2018-05-02 Thread Pedro Larroy
For me the situation with DMLC is problematic. I often find myself having to fix things in the DMLC subrepos. * These changes are impossible to test with the MXNet CI system without doing shenanigans like changing the submodules to my own forks. * Slows down development as fixes need to be

Re: [VOTE] Release Apache MXNet(incubating) version 1.2.0.RC1

2018-04-30 Thread Hen
Naive question - How often does this happen? It should be rare that a project needs to send a PR to a dependency, and much rarer that it blocks a release. It sounds like it’s too coupled a dependency. I suspect the DMLC code situation is going to be a major blocker to any chance of graduating.

Re: [VOTE] Release Apache MXNet(incubating) version 1.2.0.RC1

2018-04-30 Thread Gautam
+1 on merging this "https://github.com/dmlc/mshadow/pull/319 " I am curious how are we tracking the sub-modules's PRs which are really important for MXNet? This PR has been waiting to merge for almost 4 months. On Mon, Apr 30, 2018 at 1:51 AM, Pedro Larroy wrote:

Re: [VOTE] Release Apache MXNet(incubating) version 1.2.0.RC1

2018-04-30 Thread Anirudh
Thanks for raising this, Pedro. Taking a look now. On Mon, Apr 30, 2018 at 1:51 AM, Pedro Larroy wrote: > -1 > > We should merge this and update mshadow before the next release: > https://github.com/dmlc/mshadow/pull/319 so we compile cuda for Volta. > > On Sat,

Re: [VOTE] Release Apache MXNet(incubating) version 1.2.0.RC1

2018-04-30 Thread Pedro Larroy
-1 We should merge this and update mshadow before the next release: https://github.com/dmlc/mshadow/pull/319 so we compile cuda for Volta. On Sat, Apr 28, 2018 at 12:53 AM, Steffen Rochel wrote: > Hi Chris - acknowledge that building the docs is not as good as it

Re: [VOTE] Release Apache MXNet(incubating) version 1.2.0.RC1

2018-04-27 Thread Steffen Rochel
Hi Chris - acknowledge that building the docs is not as good as it should be and needs to be improved. Is it worse compared to 1.1.0 release to consider as release blocker? On Fri, Apr 27, 2018 at 9:53 AM Chris Olivier wrote: > -1 > > Building the docs locally is an

Re: [VOTE] Release Apache MXNet(incubating) version 1.2.0.RC1

2018-04-27 Thread Chris Olivier
-1 Building the docs locally is an absolute nightmare. I haven;t been able to get it to work yet. On Thu, Apr 26, 2018 at 3:36 PM, Marco de Abreu < marco.g.ab...@googlemail.com> wrote: > Hello, > > I'd like to request to pause this vote since I have identified an issue > with our CMakeLists,

[VOTE] Release Apache MXNet(incubating) version 1.2.0.RC1

2018-04-26 Thread Anirudh
Hi all, As part of RC1 release, We have addressed the issue with respect to asymmetric padding in ONNX Import module ( https://github.com/apache/incubator-mxnet/pull/10676). We have also added existing silent failures for MXNet Conv and the incompatibility in behavior for certain use cases