[jira] Commented: (TOBAGO-510) tc:message tag doesn't work with IE

2007-10-08 Thread Helmut Swaczinna (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533085 ] Helmut Swaczinna commented on TOBAGO-510: - Thanks, it works now. tc:message tag doesn't work with IE

Re: [Trinidad] please comment on the following bug

2007-10-08 Thread Andrew Robinson
My recommendation is to change the code and documentation to: - If the component is a naming container, search relative to the parent; otherwise search relative to the component But what if the person does want to search the children? If the parent was used, they would have to refer to

[Trinidad] treeTable improvements + fix

2007-10-08 Thread Cristi Toth
Hi all! I'm currently working on the treeTable rendering / skinning and I some improvements / fixes in mind. First I noticed that the row banding doesn't work right. at each deeper level (expanded node) it resets the banding to 0 meaning the each first child node starts with the first color (no

[Trindiad] breadCrumbs skinning improvement

2007-10-08 Thread Cristi Toth
Hi! I hava an improvement idea on the breadCrumbs skinning. When the orientation is set to vertical, in other applications, the separator is just before the text entry a line corner (like the last node of a tree) But this means that we need to be able to put the separator icon in front of the

[Trinidad] panelTabbed skinning improvement

2007-10-08 Thread Cristi Toth
Hi! The skinning of the pannelTabbed component could be improved so that it can have round cornered tabs (like in most of the applications), similar to navigationPanel with hint=tabs but simpler. My opinion is to have the following selectors: af:panelTabbed:: - beforeCell (-selected) - cell

[Trinidad] tree components skinning improvement

2007-10-08 Thread Cristi Toth
Hi! I already did some work on the tree components: I added the lines to the tree and the capability to skin the expand / collapse icons. But normal trees also have some different icons for each node (next to the expand/collapse icon) In tomahawk, each node has a sting property named 'type'

[Trinidad] skinning TEXT keys documentation missing?

2007-10-08 Thread Cristi Toth
Hi! I'm using skinning to have internationalized components (with my bundle) and I noticed there's absolutely no documentation about this. So you have to look into the renderers to find this info. And in most of them the strings aren't even declared as constants. Is there somewhere a hidden

Re: [Trinidad] panelTabbed skinning improvement

2007-10-08 Thread Andrew Robinson
I have submitted such an issue that keeps the existing tabs and adds the new ones. This way it is backwards compatible. https://issues.apache.org/jira/browse/TRINIDAD-632 On 10/8/07, Cristi Toth [EMAIL PROTECTED] wrote: Hi! The skinning of the pannelTabbed component could be improved so that

Re: [Trinidad] skinning TEXT keys documentation missing?

2007-10-08 Thread Danny Robinson
Cristi, Please can you raise an issue for this. Thanks, D. On 10/8/07, Cristi Toth [EMAIL PROTECTED] wrote: Hi! I'm using skinning to have internationalized components (with my bundle) and I noticed there's absolutely no documentation about this. So you have to look into the renderers to

[jira] Commented: (TRINIDAD-758) failure in parsing of sub menu models (sharedNodes) results in root menu tree not being created. Bad sub menu models should just be skipped.

2007-10-08 Thread Gary Kind (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533196 ] Gary Kind commented on TRINIDAD-758: After code review by Jeanne Waldman, I have attached 2 new patch files

Re: [Trinidad] skinning TEXT keys documentation missing?

2007-10-08 Thread Jeanne Waldman
The hidden documentation is 1. look at the trinidad-skins.xml document in the demo. You'll set bundle-name. 2. The keys are in CoreBundle.xrts. Not documented officially. - Jeanne Danny Robinson wrote: Cristi, Please can you raise an issue for this. Thanks, D. On 10/8/07, Cristi

Re: [Trinidad] please comment on the following bug

2007-10-08 Thread Adam Winer
On 10/8/07, Andrew Robinson [EMAIL PROTECTED] wrote: My recommendation is to change the code and documentation to: - If the component is a naming container, search relative to the parent; otherwise search relative to the component But what if the person does want to search the

Re: [Trinidad] navigationTree not refactored???

2007-10-08 Thread Adam Winer
It's desperately in need of refactoring to extend off of the new TreeRenderer, and not the old 'uix' one. -- Adam On 10/8/07, Cristi Toth [EMAIL PROTECTED] wrote: Hi all! I need I really need the navigationTree and I noticed the renderer is still in the 'uix' package and that the code

[jira] Commented: (TRINIDAD-758) failure in parsing of sub menu models (sharedNodes) results in root menu tree not being created. Bad sub menu models should just be skipped.

2007-10-08 Thread Gary Kind (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533221 ] Gary Kind commented on TRINIDAD-758: Fixed one, minor compile issue. Attached 2 new patch files. failure in

Re: [Trinidad] skinning TEXT keys documentation missing?

2007-10-08 Thread Cristi Toth
Thanks Jeanne, I figured that too and I also look in the renderers. It's not that hard for me, but I'm sure it is for the usual user. On 10/9/07, Jeanne Waldman [EMAIL PROTECTED] wrote: The hidden documentation is 1. look at the trinidad-skins.xml document in the demo. You'll set

[jira] Commented: (TRINIDAD-758) failure in parsing of sub menu models (sharedNodes) results in root menu tree not being created. Bad sub menu models should just be skipped.

2007-10-08 Thread Jeanne Waldman (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533229 ] Jeanne Waldman commented on TRINIDAD-758: - Committed to trunk. This will be in the revision after 1.0.3.

Re: [Trinidad] skinning TEXT keys documentation missing?

2007-10-08 Thread Jeanne Waldman
Yes, this definitely needs documentation. Cristi Toth wrote: Thanks Jeanne, I figured that too and I also look in the renderers. It's not that hard for me, but I'm sure it is for the usual user. On 10/9/07, Jeanne Waldman [EMAIL PROTECTED] wrote: The hidden documentation is 1.

Re: [Trinidad] navigationTree not refactored???

2007-10-08 Thread Cristi Toth
Hi Adam! No problem, I'll do it. But I need to know some start points... i.e. It took me some 1/2 hour to figure that the actual renderer that does the job is the NavigationTreeRenderer from ui.laf.desktop package not the close to useless one from the uix package. Is something from the uix

[jira] Created: (TRINIDAD-759) skinning TEXT keys documentation missing

2007-10-08 Thread Cristi Toth (JIRA)
skinning TEXT keys documentation missing Key: TRINIDAD-759 URL: https://issues.apache.org/jira/browse/TRINIDAD-759 Project: MyFaces Trinidad Issue Type: Bug Components: Documentation,

Re: [Trinidad] navigationTree not refactored???

2007-10-08 Thread Adam Winer
Ah, OK, I see the confusion. The renderer in uix handles the decoding side of things. The renderer in uinode handles just the rendering thing, 'cause it's from an old architecture that didn't have any built-in decoding. Ideally, we'd have one new renderer in core.xhtml that extends TreeRenderer