Re: [DISCUSS] how to get rid of tons of duplicated code

2011-10-23 Thread Jakob Korherr
Hi Mark, +1 - that's exactly what I have been trying to accomplish some time ago (introducing common-shades [1]). Unfortunately, I was not successful back then. However, there is a slight problem with moving all this stuff into MyFaces shared, which I want to point out: code size. If we really

Re: [DISCUSS] how to get rid of tons of duplicated code

2011-10-23 Thread Mark Struberg
With this approach each MyFaces subproject would be able to pick out only the stuff it really needs. This is not needed if we use the maven-shade-plugin minimizeJar option [1] ! With minimizeJar enabled the dependency classes are analyzed and only the classes which really got used will get

Re: [DISCUSS] how to get rid of tons of duplicated code

2011-10-23 Thread Jakob Korherr
Ah, nice! I did not know that. Great stuff :) Regards, Jakob 2011/10/23 Mark Struberg strub...@yahoo.de: With this approach each MyFaces subproject would be able to pick out only the stuff it really needs. This is not needed if we use the maven-shade-plugin minimizeJar option [1] !

[jira] [Commented] (MYFACES-3106) Resources not loaded when using a dynamic ui:inlclude and rendered via ajax

2011-10-23 Thread Luciano Deriu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133682#comment-13133682 ] Luciano Deriu commented on MYFACES-3106: Thanks Leonardo, Does this mean i can

Re: [DISCUSS] how to get rid of tons of duplicated code

2011-10-23 Thread Leonardo Uribe
Hi 2011/10/23 Jakob Korherr jakob.korh...@gmail.com: Hi Mark, +1 - that's exactly what I have been trying to accomplish some time ago (introducing common-shades [1]). Unfortunately, I was not successful back then. It is clear we need to split myfaces-impl into multiple modules. There are

Re: [DISCUSS] how to get rid of tons of duplicated code

2011-10-23 Thread Leonardo Uribe
Hi Ok, let's check the proposal MS So the suggestion is: MS MS 1.) cleanup myfaces-shared. mf-shared has almost no checkstyle rules applied. Yes, sounds good. MS 2.) add unit tests for myfaces-shared. Currently there are not many... Ok, sounds good too. MS 3.) move the shared code parts back

Re: [DISCUSS] how to get rid of tons of duplicated code

2011-10-23 Thread Mark Struberg
I've now read through the old mail archives and understand what the original problem was. But actually I don't think we solved it correctly right now. Of course we solved to original problem, but opened a can of worms causing other problems. The problem as far as I remember has been that

Re: [DISCUSS] how to get rid of tons of duplicated code

2011-10-23 Thread Leonardo Uribe
Hi 2011/10/23 Mark Struberg strub...@yahoo.de: I've now read through the old mail archives and understand what the original problem was. But actually I don't think we solved it correctly right now. Of course we solved to original problem, but opened a can of worms causing other problems.