Compatibility with Servlet API 2.4
--
Key: MYFACES-3374
URL: https://issues.apache.org/jira/browse/MYFACES-3374
Project: MyFaces Core
Issue Type: Task
Reporter: Udo Schnurpfeil
Assignee
Hi Gregor,
This issue seems to be a race condition resulting of the combination
of xerces closing every InputStream it gets and Jetty failing to
handle this.
In the stacktrace you can see that there is a call to
ServletContext.getResource() via ExternalContext. Also you can see
that it currently
Hi!
Currently we have really long and very descriptive variable names in MyFaces.
I personally like that, but due to that we are really often exceeding the 120
character per line.
Thus my question: should we extend this from 120 to 160 characters being
allowed per line?
[+1] yup make 160 the
-1
Am 26.10.2011 14:18, schrieb Mark Struberg:
Hi!
Currently we have really long and very descriptive variable names in MyFaces.
I personally like that, but due to that we are really often exceeding the 120
character per line.
Thus my question: should we extend this from 120 to 160 character
MyFaces can incorrectly determine that Portlets are not supported
-
Key: MYFACES-3375
URL: https://issues.apache.org/jira/browse/MYFACES-3375
Project: MyFaces Core
Issue Type: B
Hello Everyone,
I've opened MYFACES-3375 and would like to propose a solution and receive
some feedback. The proposed solution is as follows:
1) New Class PortletBridgeDetector
- bridgeEnabled() - This method will use the Application Class loader
to determine if a Portlet Bridge Class i
Hi!
checkstyle just found another kind of gems
for example in AbstractAttributeMap.java
private Collection _values;
@Override
public Collection values()
{
return (_values != null) ? _values : (_values = new Values());
}
This code is not thread safe!
_values is n
Hello,
I think I have found a bug, but rather than open an issue I prefer to ask it
here first.
I'm writing a custom version of UIData component extending the default UIData
class. I want to register a DataModelListener in order to be notified on row
index changes.
I have overridden the setVa
ValueExpressions for SelectItems are evaluated too often for checboxes or
radios with spread layout
---
Key: TOMAHAWK-1605
URL: https://issues.apache.org/jira/browse/T
Hi folks!
I see a lot of commented out code which is many years old.
I'm highly in favour to just delete code we don't need anymore!
IF you only temporarily comment out something, then please mark it with
/*X TODO some comment
or
//X TODO some comment
otherwise comments must ONLY be use
+1 since you can always get it back out of svn if you need it.
On Wed, Oct 26, 2011 at 12:08 PM, Mark Struberg wrote:
> Hi folks!
>
>
> I see a lot of commented out code which is many years old.
>
> I'm highly in favour to just delete code we don't need anymore!
>
> IF you only temporarily commen
+1
Am 26.10.2011 18:20, schrieb Mike Kienenberger:
+1 since you can always get it back out of svn if you need it.
On Wed, Oct 26, 2011 at 12:08 PM, Mark Struberg wrote:
Hi folks!
I see a lot of commented out code which is many years old.
I'm highly in favour to just delete code we don't ne
CSS of needs to be refactored
-
Key: TOBAGO-1042
URL: https://issues.apache.org/jira/browse/TOBAGO-1042
Project: MyFaces Tobago
Issue Type: Bug
Affects Versions: 1.5.0-beta-1
Reporter:
Problem with internal dispaching (e.g. to error pages) when using CDI/OWB with
old containers
-
Key: TOBAGO-1043
URL: https://issues.apache.org/jira/browse/TOBAGO-1043
[
https://issues.apache.org/jira/browse/TOBAGO-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136153#comment-13136153
]
Udo Schnurpfeil commented on TOBAGO-1043:
-
I need it for Tomcat 5.5 and WebSphere
[
https://issues.apache.org/jira/browse/TOBAGO-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Udo Schnurpfeil resolved TOBAGO-1043.
-
Resolution: Fixed
> Problem with internal dispaching (e.g. to error pages) when usin
[
https://issues.apache.org/jira/browse/TOBAGO-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Udo Schnurpfeil resolved TOBAGO-1042.
-
Resolution: Fixed
Fix Version/s: 1.5.0-beta-2
> CSS of needs to be refactore
+1
On Wed, Oct 26, 2011 at 7:23 AM, Michael Kurz wrote:
> -1
>
> Am 26.10.2011 14:18, schrieb Mark Struberg:
>
> Hi!
>>
>> Currently we have really long and very descriptive variable names in
>> MyFaces.
>>
>> I personally like that, but due to that we are really often exceeding the
>> 120 char
Hi folks!
I'm down to 24 checkstyle issues (with LineLength=160, otherwise ~600 more)
which are really non-trivial.
A few of them are 'equals() without hashCode()' which are definitely problematic
Then we have a few variable namings which I didn't want to change without
talking to you.
And of c
+1
regards,
gerhard
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
2011/10/26 Michael Kurz
> +1
>
> Am 26.10.2011 18:20, schrieb Mike Kienenberger:
>
> +1 since you can always get it back out
Hi
I'm keeping an eye on the changes done. I don't remember any problem
about 'double lock' on myfaces. Could you please be more specific? In
my understanding everything works as expected.
regards,
Leonardo Uribe
2011/10/26 Mark Struberg :
> Hi folks!
>
> I'm down to 24 checkstyle issues (with
+0
2011/10/26 Grant Smith :
> +1
>
> On Wed, Oct 26, 2011 at 7:23 AM, Michael Kurz wrote:
>>
>> -1
>>
>> Am 26.10.2011 14:18, schrieb Mark Struberg:
>>>
>>> Hi!
>>>
>>> Currently we have really long and very descriptive variable names in
>>> MyFaces.
>>>
>>> I personally like that, but due to tha
Again (think I posted this before already), a very good source for java mem
spec behaviour is the comment of Brian Goetz
http://www.cs.umd.edu/~pugh/java/memoryModel/jsr-133-faq.html
This also explains why you need to declare the field volatile - don't wanna
stress this, but I told this also be
Yes I know that, but where in myfaces we have a problem like that? so
we can discuss it in deep.
2011/10/26 Mark Struberg :
> Again (think I posted this before already), a very good source for java mem
> spec behaviour is the comment of Brian Goetz
>
> http://www.cs.umd.edu/~pugh/java/memoryModel
For example
NavigationHandlerImpl#_navigationCases
I already fixed a few occurrences.
There are also a few other checkstyle errors waiting to get fixed like methods
which are 450 lines long..
Would be cool if you could take a look at it - txs!
LieGrue,
strub
- Original Message -
>
Create abstract test classes that runs MyFaces Core as in a container
-
Key: MYFACES-3376
URL: https://issues.apache.org/jira/browse/MYFACES-3376
Project: MyFaces Core
Issue
[
https://issues.apache.org/jira/browse/MYFACES-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe resolved MYFACES-3376.
-
Resolution: Fixed
Fix Version/s: 2.1.4
2.0.10
> Create ab
Hi
In NavigationHandlerImpl#_navigationCases, that var should be
volatile, but note if it is not nothing happens, just the code will be
executed more times than necessary.
regards,
Leonardo Uribe
2011/10/26 Mark Struberg :
> For example
> NavigationHandlerImpl#_navigationCases
>
> I already fix
This is an argument which I hear often. But it's actually wrong. Let's assume:
Map getX() {
if (x=null) {
synchronized(this) {
if (x=null) {
x=new HashMap();
}
}
}
return x;
}
People argue that the worst what can happen is that x will get created twice.
But
Hi
It is true, but the case we have does not manipulate _navigationCases
directly, instead an new map is created and filled each time and only
before end the synchronized block it is assigned. In this case we
don't have any additional manipulation of _navigationCases after that
too.
regards,
Leon
+1 Be ruthless !
On Wed, Oct 26, 2011 at 11:35 AM, Gerhard Petracek <
gerhard.petra...@gmail.com> wrote:
> +1
>
> regards,
> gerhard
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
>
[
https://issues.apache.org/jira/browse/TRINIDAD-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136720#comment-13136720
]
Pavitra Subramaniam commented on TRINIDAD-2140:
---
Another recommendation i
Hi
There are two classes:
org.apache.myfaces.util.AbstractAttributeMap
and
org.apache.myfaces.util.AbstractThreadSafeAttributeMap
You're right, there is a bug, but apply them please on
AbstractThreadSafeAttributeMap. Note ApplicationMap and SessionMap
wrappers used by ExternalContext inherits
Hi
The problem with this is we are talking about two different things.
The code that detects a portlet environment was designed for:
- JSR-301: Portlet 1.0 Bridge for JavaServer Faces 1.2
- JSR-329: Portlet 2.0 Bridge for JavaServer Faces 1.2
- Portlet 2.0 Bridge for JavaServer Faces 2.0
But wha
The "defaultCommand" of button should have a special markup
---
Key: TOBAGO-1044
URL: https://issues.apache.org/jira/browse/TOBAGO-1044
Project: MyFaces Tobago
Issue Type: Improvement
35 matches
Mail list logo
