Re: [DISCUSS] why do we overcomplicate our code soooo much?

2011-10-29 Thread Mark Struberg
Actually I DID touch the code. Because I helped Jakob with one of the very first versions. Thus I was involved pretty much from the very beginning. Even before the code got imported. Actually I'm also still missing the answers to my technical questions... So, how can we get something

Re: [VOTE] [RESULT] (or so) extend maximum allowed line length from 120 to 160

2011-10-29 Thread Mark Struberg
Hi folks! I actually didn't really count the vote, but as there were a few -1 and a few +0 I'd like to revoke the vote and would say we stick with 120 chars/line. Which means I'll go on and fix the linebreaks in myfaces-core (*sigh*) LieGrue, strub - Original Message - From:

Re: [VOTE] extend maximum allowed line length from 120 to 160

2011-10-29 Thread Michael Kurz
Hi Mark, I can help you on this one - but probably not before Monday or Tuesday. Btw.: Do you already have a settings file for IntelliJ 10.5? regards Michael Am 28.10.2011 20:49, schrieb Mark Struberg: As I said earlier, the 160 char/line proposal was just made because I'm pretty tired of

Re: [VOTE] extend maximum allowed line length from 120 to 160

2011-10-29 Thread Mark Struberg
yes, I can share my current setting. I now fixed most occurrences, but there are a few classes which have 400++ LOC in one method, and I think this should get handled by someone which is more into myfaces-core than I am. I will attach my current config to the wiki. LieGrue, strub -

Re: [VOTE] extend maximum allowed line length from 120 to 160

2011-10-29 Thread Mark Struberg
Since I'm not getting warm with the MoinMoin, I just copied to my peoples account http://people.apache.org/~struberg/apache_myfaces_checkstyle.xml Mac users need to copy it to: ~/Library/Preferences/IntelliJIdea10/codestyles/apache_myfaces_checkstyle.xml Linux users to:

[jira] [Created] (EXTCDI-234) NullPointerException in DefaultWindowContextManager#removeWindowContextIdHolderComponent

2011-10-29 Thread Mark Struberg (Created) (JIRA)
NullPointerException in DefaultWindowContextManager#removeWindowContextIdHolderComponent Key: EXTCDI-234 URL: https://issues.apache.org/jira/browse/EXTCDI-234

[jira] [Resolved] (EXTCDI-234) NullPointerException in DefaultWindowContextManager#removeWindowContextIdHolderComponent

2011-10-29 Thread Mark Struberg (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/EXTCDI-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg resolved EXTCDI-234. -- Resolution: Fixed Fix Version/s: 1.0.2 NullPointerException in