So your vote is:
1. Go back to the old way, just one class.
2. The viewId is not important --> get rid of it.
3. Split ServerSideStateCacheImpl into many classes
Let's try to be concrete, so we can get to a constructive conclusion.
I think both positions are clear, I don't want to waste my time
> 1. Small key size used to store views into session vs go back to the old way.
Take a safe approach. Adding just the hashCode doesn't make it more safe.
Either the full viewId or get rid of it completely if not needed.
> 2. use the hashCode of the viewId vs store the full viewId and do an
> e
> Leonardo said that the viewid algorithm isn't relying on the hash
> code, at which point you changed the topic to inner classes.
The inner class discussion is unrelated. It's just that all the code was hidden
inside a single class. I refactored out 8 of them and dropped 5 others. The
ones I d
My vote is
1. Small key size used to store views into session
2. use the hashCode of the viewId
3. keep the code as is
Leonardo
2012/11/14 Leonardo Uribe :
> Hi
>
> Recently in
>
> https://issues.apache.org/jira/browse/MYFACES-3638
>
> We have found some problems related to how ServerSideStateCa
Hi
1.) How many inner classes do we like to use?
As many as necessary to get the job done. There is already a
checkstyle rule in myfaces that limits the file size to 3000 lines.
Everything below the limit is valid!!!.
2.) hashCode as key
I created an alternate vote to explain this point in dee
Hi
Recently in
https://issues.apache.org/jira/browse/MYFACES-3638
We have found some problems related to how ServerSideStateCacheImpl should
work. In few words, the code in that class deals with all logic
related to server
side state saving, so it is a critical point in MyFaces Core.
We need so
Shoaib Ali Khan created TRINIDAD-2339:
-
Summary: Trinidad on Jboss AS 6. Cannot deploy application because
of syntax error in tld
Key: TRINIDAD-2339
URL: https://issues.apache.org/jira/browse/TRINIDAD-2339
> 1.) How many inner classes do we like to use?
Well, your first item isn't a technical or design issue. It's a style issue.
My preference is that the code be readable, and if these inner classes
are making it less readable, then they should be moved.
So as a general, but not absolute rule,
2012/11/14 Mike Kienenberger :
> Guys,
>
> In my opinion, any time someone feels the need to revert SOMEONE
> ELSE's code without that person's consent, the first step must be to
> have a public discussion on the topic, unless it is an obvious
> immediate security bug.
>
> We shouldn't be seeing re
Guys,
In my opinion, any time someone feels the need to revert SOMEONE
ELSE's code without that person's consent, the first step must be to
have a public discussion on the topic, unless it is an obvious
immediate security bug.
We shouldn't be seeing revert wars, then a discussion.
On Wed, Nov 1
2012/11/14 Mark Struberg :
> That is ONE strategy! There are tons of others. Plus half of your 10++ inner
> classes was waste of code!
>
> If you do it pluggable, then do it for real!
Pluggability is not a concern there. It was done in that way to make
the distinction
between the key stored into
2012/11/14 Mark Struberg :
>
>
>
>
> Leo we HAD that already in production (with an IBM JVM). Does that count?
>
> using the hashCode to speed up caches is perfectly fine. But only for
> _excluding_ matches, Getting the same hashCode doesn't make sure something is
> unique.
>
> Also in the privat
[
https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Struberg reopened MYFACES-3638:
> NPE in ServerSideStateCacheImpl
> ---
>
> K
2012/11/14 Leonardo Uribe :
> Hi
>
> 2012/11/14 Mark Struberg :
>> Leo, there was a reason I removed it.
>>
>>
>> Even after discussing this over 10 mails in a private thread you don't get
>> it it seems. I will open a VOTE about principal design fundamentals and we
>> will act according to this.
Hi!
While working on a few parts of the MyFaces codebase the last few times I saw
increasingly bad style imo. Some of it might be a personal taste, others is
technically funded. Let's start with the design parts
1.) How many inner classes do we like to use?
I found 10++ inner classes per cla
Hi
2012/11/14 Mark Struberg :
> Leo, there was a reason I removed it.
>
>
> Even after discussing this over 10 mails in a private thread you don't get it
> it seems. I will open a VOTE about principal design fundamentals and we will
> act according to this.
>
> Just you be prepated: A HASH IS NO
[
https://issues.apache.org/jira/browse/MYFACES-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Struberg reopened MYFACES-3641:
Assignee: Mark Struberg (was: Leonardo Uribe)
Leo, it's just plain to rely on a h
[
https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe resolved MYFACES-3638.
-
Resolution: Fixed
Fix Version/s: 2.0.16
Fixed and updated 2.0.x branch. 2.2.x an
[
https://issues.apache.org/jira/browse/MYFACES-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe resolved MYFACES-3641.
-
Resolution: Fixed
Fix Version/s: 2.1.10
2.0.16
Assign
Leonardo Uribe created MYFACES-3641:
---
Summary:
ViewDeclarationLanguageFactoryImpl.getViewDeclarationLanguage(String viewId)
should not throw exception if no associate VDL can be found
Key: MYFACES-3641
URL: htt
[
https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe reopened MYFACES-3638:
-
Reopening issue to include solution without refactoring of server side state
saving code.
[
https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Struberg updated MYFACES-3638:
---
Resolution: Fixed
Fix Version/s: 2.1.10
Status: Resolved (was: Patch Avai
[
https://issues.apache.org/jira/browse/TOBAGO-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497005#comment-13497005
]
Hudson commented on TOBAGO-1215:
Integrated in tobago-trunk #907 (See
[https://builds.ap
[
https://issues.apache.org/jira/browse/TOBAGO-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497004#comment-13497004
]
Hudson commented on TOBAGO-1215:
Integrated in tobago-1.5.x #108 (See
[https://builds.ap
[
https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496988#comment-13496988
]
Jakob Korherr commented on MYFACES-3638:
404 should force an immediate responseC
[
https://issues.apache.org/jira/browse/EXTSCRIPT-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Werner Punz resolved EXTSCRIPT-182.
---
Resolution: Fixed
Fix Version/s: 1.0.5-FINAL
1.0.5-SNAPSHOT
done
Werner Punz created MYFACES-3640:
Summary: Create CMS infrastructure
Key: MYFACES-3640
URL: https://issues.apache.org/jira/browse/MYFACES-3640
Project: MyFaces Core
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/MYFACES-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496953#comment-13496953
]
Marcus Büttner commented on MYFACES-3638:
-
After calling dispatcher in JspViewDe
[
https://issues.apache.org/jira/browse/TOBAGO-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Udo Schnurpfeil resolved TOBAGO-1215.
-
Resolution: Fixed
Fix Version/s: 1.6.0
1.6.0-beta-3
29 matches
Mail list logo