[GitHub] [myfaces] tandraschko commented on pull request #192: feat(quarkus): update to quarkus 1.13.0.Final

2021-03-31 Thread GitBox
tandraschko commented on pull request #192: URL: https://github.com/apache/myfaces/pull/192#issuecomment-810832770 @bohmber can you add a jira for tracking? +1 then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #699: build(deps): bump download-maven-plugin from 1.6.1 to 1.6.2

2021-03-31 Thread GitBox
lofwyr14 merged pull request #699: URL: https://github.com/apache/myfaces-tobago/pull/699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (TOBAGO-2073) Auto spacing attribute

2021-03-31 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2073. -- Resolution: Fixed > Auto spacing attribute > -- > > Key: T

[GitHub] [myfaces] melloware commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

2021-03-31 Thread GitBox
melloware commented on pull request #191: URL: https://github.com/apache/myfaces/pull/191#issuecomment-810981894 OK I updated it. to write out "multiple" but what threw me off is the lines above it were this... ```java if (inputFile.isDisabled()) { writer.writeAttribute(HTM

[GitHub] [myfaces] GedMarc commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

2021-03-31 Thread GitBox
GedMarc commented on pull request #191: URL: https://github.com/apache/myfaces/pull/191#issuecomment-810982715 yeah disabled=true doesn't work across all browsers, has to be just "disabled" or "disabled=disabled" -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [myfaces] GedMarc edited a comment on pull request #191: MYFACES-4390: HtmlInputFile multiple support

2021-03-31 Thread GitBox
GedMarc edited a comment on pull request #191: URL: https://github.com/apache/myfaces/pull/191#issuecomment-810982715 yeah disabled=true doesn't work across all browsers, has to be just "disabled" or "disabled=disabled", Multiple is the same, cant be multiple=true, must be multiple=

[GitHub] [myfaces] GedMarc commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

2021-03-31 Thread GitBox
GedMarc commented on pull request #191: URL: https://github.com/apache/myfaces/pull/191#issuecomment-810983661 ref here https://stackoverflow.com/questions/6961526/what-is-the-correct-value-for-the-disabled-attribute Don't use attributes=true for these at all, ever -- This is an a

[GitHub] [myfaces] melloware commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

2021-03-31 Thread GitBox
melloware commented on pull request #191: URL: https://github.com/apache/myfaces/pull/191#issuecomment-810984037 Thanks @GedMarc. So @tandraschko so then the Disabled attribute here is incorrect then. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [myfaces] tandraschko commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

2021-03-31 Thread GitBox
tandraschko commented on pull request #191: URL: https://github.com/apache/myfaces/pull/191#issuecomment-810998847 @melloware would you please add a jira issue and provide a PR? would be great! -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (MYFACES-4390) Faces 4.0: h:inputFile multiple="true"

2021-03-31 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4390. Assignee: (was: Thomas Andraschko) Resolution: Fixed > Faces 4.0: h:inp

[GitHub] [myfaces] tandraschko merged pull request #191: MYFACES-4390: HtmlInputFile multiple support

2021-03-31 Thread GitBox
tandraschko merged pull request #191: URL: https://github.com/apache/myfaces/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[jira] [Commented] (MYFACES-4390) Faces 4.0: h:inputFile multiple="true"

2021-03-31 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312288#comment-17312288 ] Thomas Andraschko commented on MYFACES-4390: Thanks for your contribution -

[GitHub] [myfaces-tobago] henningn opened a new pull request #701: fix(sheet): columnNode

2021-03-31 Thread GitBox
henningn opened a new pull request #701: URL: https://github.com/apache/myfaces-tobago/pull/701 fix tree in sheet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queri

[GitHub] [myfaces-tobago] henningn merged pull request #701: fix(sheet): columnNode

2021-03-31 Thread GitBox
henningn merged pull request #701: URL: https://github.com/apache/myfaces-tobago/pull/701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [myfaces] melloware commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

2021-03-31 Thread GitBox
melloware commented on pull request #191: URL: https://github.com/apache/myfaces/pull/191#issuecomment-811018875 Yep will do! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Created] (MYFACES-4391) Disabled and ReadOnly HTML attributes should not use boolean

2021-03-31 Thread Melloware (Jira)
Melloware created MYFACES-4391: -- Summary: Disabled and ReadOnly HTML attributes should not use boolean Key: MYFACES-4391 URL: https://issues.apache.org/jira/browse/MYFACES-4391 Project: MyFaces Core

[GitHub] [myfaces] melloware opened a new pull request #193: MYFACES-4391: Disabled/Readonly attributes render correct HTML

2021-03-31 Thread GitBox
melloware opened a new pull request #193: URL: https://github.com/apache/myfaces/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (MYFACES-4388) Faces 4.0: rename xmlns.jcp.org taglib URIs

2021-03-31 Thread Melloware (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312410#comment-17312410 ] Melloware commented on MYFACES-4388: Right now we have something like this... {code

[jira] [Comment Edited] (MYFACES-4388) Faces 4.0: rename xmlns.jcp.org taglib URIs

2021-03-31 Thread Melloware (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312410#comment-17312410 ] Melloware edited comment on MYFACES-4388 at 3/31/21, 2:20 PM: ---

[jira] [Commented] (MYFACES-4391) Disabled/ReadOnly HTML attributes should not use boolean

2021-03-31 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312415#comment-17312415 ] Thomas Andraschko commented on MYFACES-4391: should we port this to other b

[GitHub] [myfaces] tandraschko merged pull request #193: MYFACES-4391: Disabled/Readonly attributes render correct HTML

2021-03-31 Thread GitBox
tandraschko merged pull request #193: URL: https://github.com/apache/myfaces/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[jira] [Commented] (MYFACES-4391) Disabled/ReadOnly HTML attributes should not use boolean

2021-03-31 Thread Melloware (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312418#comment-17312418 ] Melloware commented on MYFACES-4391: Probably does this require a "backport" PR to

[jira] [Commented] (MYFACES-4391) Disabled/ReadOnly HTML attributes should not use boolean

2021-03-31 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312426#comment-17312426 ] Thomas Andraschko commented on MYFACES-4391: yep the current "well maintain

[jira] [Commented] (MYFACES-4391) Disabled/ReadOnly HTML attributes should not use boolean

2021-03-31 Thread Bill Lucy (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312427#comment-17312427 ] Bill Lucy commented on MYFACES-4391: Is there a chance this attribute change could

[GitHub] [myfaces] melloware opened a new pull request #194: BackPort 3.0 MYFACES-4391: Disabled/Readonly attributes render correc…

2021-03-31 Thread GitBox
melloware opened a new pull request #194: URL: https://github.com/apache/myfaces/pull/194 …t HTML -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [myfaces] melloware opened a new pull request #195: Backport 2.3-next MYFACES-4391: Disabled/Readonly attributes

2021-03-31 Thread GitBox
melloware opened a new pull request #195: URL: https://github.com/apache/myfaces/pull/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [myfaces] melloware opened a new pull request #196: BackPort 2.3 MYFACES-4391: Disabled/Readonly attributes

2021-03-31 Thread GitBox
melloware opened a new pull request #196: URL: https://github.com/apache/myfaces/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (MYFACES-4391) Disabled/ReadOnly HTML attributes should not use boolean

2021-03-31 Thread Melloware (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312438#comment-17312438 ] Melloware commented on MYFACES-4391: I guess its possible but MyFaces was already d

[jira] [Commented] (MYFACES-4391) Disabled/ReadOnly HTML attributes should not use boolean

2021-03-31 Thread Bill Lucy (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312450#comment-17312450 ] Bill Lucy commented on MYFACES-4391: Okay, thanks for the background. You're right,

[jira] [Created] (MYFACES-4392) Update to quarkus 1.13.0.Final

2021-03-31 Thread Bernd Bohmann (Jira)
Bernd Bohmann created MYFACES-4392: -- Summary: Update to quarkus 1.13.0.Final Key: MYFACES-4392 URL: https://issues.apache.org/jira/browse/MYFACES-4392 Project: MyFaces Core Issue Type: Task

[GitHub] [myfaces] bohmber commented on pull request #192: feat(quarkus): update to quarkus 1.13.0.Final

2021-03-31 Thread GitBox
bohmber commented on pull request #192: URL: https://github.com/apache/myfaces/pull/192#issuecomment-811164760 > @bohmber can you add a jira for tracking? +1 then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [myfaces] bohmber commented on pull request #192: feat(quarkus): update to quarkus 1.13.0.Final

2021-03-31 Thread GitBox
bohmber commented on pull request #192: URL: https://github.com/apache/myfaces/pull/192#issuecomment-811167543 done (MYFACES-4392) Update to quarkus 1.13.0.Final -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [myfaces] bohmber closed pull request #192: feat(quarkus): update to quarkus 1.13.0.Final

2021-03-31 Thread GitBox
bohmber closed pull request #192: URL: https://github.com/apache/myfaces/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c