[
https://issues.apache.org/jira/browse/MYFACES-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616146#comment-17616146
]
Volodymyr Siedlecki commented on MYFACES-4477:
--
Thanks for pointing that out. By the look
volosied commented on code in PR #338:
URL: https://github.com/apache/myfaces/pull/338#discussion_r992928736
##
impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlTextRendererBase.java:
##
@@ -143,7 +143,7 @@ protected void renderOutput(FacesContext facesContext,
volosied commented on code in PR #338:
URL: https://github.com/apache/myfaces/pull/338#discussion_r992929555
##
impl/src/main/java/org/apache/myfaces/application/ViewIdSupport.java:
##
@@ -482,14 +482,7 @@ protected String handleSuffixMapping(FacesContext context,
String
volosied commented on code in PR #338:
URL: https://github.com/apache/myfaces/pull/338#discussion_r992929011
##
impl/src/main/java/org/apache/myfaces/view/facelets/impl/DefaultFaceletFactory.java:
##
@@ -438,6 +438,22 @@ private DefaultFacelet
volosied commented on code in PR #338:
URL: https://github.com/apache/myfaces/pull/338#discussion_r992928736
##
impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlTextRendererBase.java:
##
@@ -143,7 +143,7 @@ protected void renderOutput(FacesContext facesContext,
volosied opened a new pull request, #338:
URL: https://github.com/apache/myfaces/pull/338
https://issues.apache.org/jira/projects/MYFACES/issues/MYFACES-4477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
werpu commented on PR #325:
URL: https://github.com/apache/myfaces/pull/325#issuecomment-1275199172
Will take care of the checkstyle violation tomorrow, I merged the latest
code in from master.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dependabot[bot] opened a new pull request, #3347:
URL: https://github.com/apache/myfaces-tobago/pull/3347
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from
2.14.0-rc1 to 2.14.0-rc2.
Commits
See full diff in
dependabot[bot] opened a new pull request, #3346:
URL: https://github.com/apache/myfaces-tobago/pull/3346
Bumps checkstyle-rules from 18-SNAPSHOT to 19.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #3345:
URL: https://github.com/apache/myfaces-tobago/pull/3345
Bumps checkstyle-rules from 17 to 19.
[![Dependabot compatibility
[
https://issues.apache.org/jira/browse/MYFACES-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615932#comment-17615932
]
Paul Nicolucci commented on MYFACES-4475:
-
[~tandraschko] thoughts on backporting this to 2.3
melloware merged PR #337:
URL: https://github.com/apache/myfaces/pull/337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pnicolucci opened a new pull request, #337:
URL: https://github.com/apache/myfaces/pull/337
https://issues.apache.org/jira/browse/MYFACES-4475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pnicolucci merged PR #336:
URL: https://github.com/apache/myfaces/pull/336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pnicolucci opened a new pull request, #336:
URL: https://github.com/apache/myfaces/pull/336
https://issues.apache.org/jira/browse/MYFACES-4475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
melloware commented on PR #331:
URL: https://github.com/apache/myfaces/pull/331#issuecomment-1274823174
Running build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
werpu commented on PR #331:
URL: https://github.com/apache/myfaces/pull/331#issuecomment-1274818529
I have fixed now the codebase, all tests pass on the new files, one fails on
the old codebase.
For now I have enabled the new faces.js codebase for build and will enable
the standard
pnicolucci merged PR #335:
URL: https://github.com/apache/myfaces/pull/335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pnicolucci opened a new pull request, #335:
URL: https://github.com/apache/myfaces/pull/335
https://issues.apache.org/jira/browse/MYFACES-4475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/MYFACES-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Nicolucci resolved MYFACES-4474.
-
Resolution: Fixed
> jakarta.faces.convert.NumberConverter.setType validation causes a
pnicolucci merged PR #334:
URL: https://github.com/apache/myfaces/pull/334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pnicolucci opened a new pull request, #334:
URL: https://github.com/apache/myfaces/pull/334
https://issues.apache.org/jira/browse/MYFACES-4474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
werpu closed pull request #332: Feature/myfaces 4476
URL: https://github.com/apache/myfaces/pull/332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
werpu commented on PR #332:
URL: https://github.com/apache/myfaces/pull/332#issuecomment-1274660950
closing until i ironed out the last bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
werpu commented on PR #332:
URL: https://github.com/apache/myfaces/pull/332#issuecomment-1274644126
Fixed everything, rat now passes locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pnicolucci commented on PR #333:
URL: https://github.com/apache/myfaces/pull/333#issuecomment-1274643413
bad PR, re working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pnicolucci closed pull request #333: Myfaces 4474 2.3 next
URL: https://github.com/apache/myfaces/pull/333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
pnicolucci opened a new pull request, #333:
URL: https://github.com/apache/myfaces/pull/333
https://issues.apache.org/jira/browse/MYFACES-4474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
werpu commented on PR #332:
URL: https://github.com/apache/myfaces/pull/332#issuecomment-1274561047
this is an overly long comment, I discovered, best is to get that out of
main as well. 5 minutes
--
This is an automated message from the Apache Git Service.
To respond to the message,
werpu commented on PR #332:
URL: https://github.com/apache/myfaces/pull/332#issuecomment-1274560381
rat plugin also fails, I will fix that as well despite not being my code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
melloware commented on PR #332:
URL: https://github.com/apache/myfaces/pull/332#issuecomment-1274555798
rerunning build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
werpu commented on PR #332:
URL: https://github.com/apache/myfaces/pull/332#issuecomment-127471
Problem fixed, there was a merge problem on my side. The affected codebase
is now back in sync with main
--
This is an automated message from the Apache Git Service.
To respond to the
werpu closed pull request #332: Feature/myfaces 4476
URL: https://github.com/apache/myfaces/pull/332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
werpu commented on PR #332:
URL: https://github.com/apache/myfaces/pull/332#issuecomment-1274544279
Seems like a merge problem on my side. I will fix this and reissue the pull
request, sorry for that.
--
This is an automated message from the Apache Git Service.
To respond to the
werpu closed pull request #332: Feature/myfaces 4476
URL: https://github.com/apache/myfaces/pull/332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
werpu commented on PR #332:
URL: https://github.com/apache/myfaces/pull/332#issuecomment-1274540296
I will have a look. Seems like the JSF Mode is referenced still, which of
course does not exist anymore.
Am Di., 11. Okt. 2022 um 13:28 Uhr schrieb Melloware <
***@***.***>:
[
https://issues.apache.org/jira/browse/MYFACES-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615709#comment-17615709
]
Werner Punz commented on MYFACES-4478:
--
Reproducible example: Checkout
melloware commented on PR #332:
URL: https://github.com/apache/myfaces/pull/332#issuecomment-1274535402
Looks like the build is failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/MYFACES-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615708#comment-17615708
]
Melloware commented on MYFACES-4477:
Actually I think it is this issue:
[
https://issues.apache.org/jira/browse/MYFACES-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615704#comment-17615704
]
Melloware commented on MYFACES-4477:
I know that XML escaping was put in to fix a security flaw so
Werner Punz created MYFACES-4478:
Summary: namespace bug for faces 4.0 and composite components
Key: MYFACES-4478
URL: https://issues.apache.org/jira/browse/MYFACES-4478
Project: MyFaces Core
melloware commented on PR #270:
URL: https://github.com/apache/myfaces/pull/270#issuecomment-1274528932
This should be marked for 4.0.0-RC2 since it just recently got merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
werpu opened a new pull request, #332:
URL: https://github.com/apache/myfaces/pull/332
20 Integration tests for the ajax part of myfaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
werpu commented on PR #331:
URL: https://github.com/apache/myfaces/pull/331#issuecomment-1274462126
Sorry, i disovered some issues, I am closing the pr and will reissue it
again later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
werpu closed pull request #331: MYFACES-4476: New Faces.js integration tests
URL: https://github.com/apache/myfaces/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
I just dropped a pull request on the 20 integration tests:
https://github.com/apache/myfaces/pull/331
The tests run automatically from the maven build as usual, but thing is, 19
tests more than before but no aquilian (mocha and and embedded tomcat is
used now)
I pulled the old ajax tests,
werpu opened a new pull request, #331:
URL: https://github.com/apache/myfaces/pull/331
I have ported my set of 20 integration tests, i have used for developing the
jsf.js and faces.ts scripts in an upgraded version which use the newest client
side frameworks for testing.
--
This is
volosied commented on PR #270:
URL: https://github.com/apache/myfaces/pull/270#issuecomment-1274222008
Thanks for looking into this so quick.
Should I mark MYFACE-4387 as fixed in 4.0.0-RC1 then?
> On Jun 10, 2022, at 4:28 PM, Melloware ***@***.***> wrote:
>
>
48 matches
Mail list logo
