[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-09 Thread GitBox
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1309874497 I have an investigative issue to the reported HTMLUnit issue here https://github.com/werpu/jsfs_js_ts/issues/27 For now this is just documentation, I want to see whether HTMLUnit

[jira] [Commented] (MYFACES-4496) Server side Websocket/Push Implementation not working

2022-11-09 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631148#comment-17631148 ] Werner Punz commented on MYFACES-4496: -- Error was on my side, I was using the javax namespace

[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-09 Thread GitBox
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1308981736 > hi, onerror was added here https://issues.apache.org/jira/browse/MYFACES-4415 > > @werpu you do not have `**jakarta**.faces.ENABLE_WEBSOCKET_ENDPOINT` enabled in your app. If you

[jira] [Resolved] (TOBAGO-2024) Add an image-description attribute for image on button

2022-11-09 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2024. -- Fix Version/s: (was: 5.x) Resolution: Won't Fix Use tip attribute to describe the

[jira] [Resolved] (TOBAGO-2166) Label text should be aligned at top

2022-11-09 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2166. -- Resolution: Fixed > Label text should be aligned at top > ---

[GitHub] [myfaces-tobago] henningn merged pull request #3402: fix: label position

2022-11-09 Thread GitBox
henningn merged PR #3402: URL: https://github.com/apache/myfaces-tobago/pull/3402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] milansie commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-09 Thread GitBox
milansie commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1308798406 hi, onerror was added here https://issues.apache.org/jira/browse/MYFACES-4415 @werpu you do not have `**jakarta**.faces.ENABLE_WEBSOCKET_ENDPOINT` enabled in your app. If you

[GitHub] [myfaces-tobago] henningn merged pull request #3401: fix: label position

2022-11-09 Thread GitBox
henningn merged PR #3401: URL: https://github.com/apache/myfaces-tobago/pull/3401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (MYFACES-4496) Server side Websocket/Push Implementation not working

2022-11-09 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631069#comment-17631069 ] Werner Punz edited comment on MYFACES-4496 at 11/9/22 1:18 PM: ---

[jira] [Commented] (MYFACES-4496) Server side Websocket/Push Implementation not working

2022-11-09 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17631069#comment-17631069 ] Werner Punz commented on MYFACES-4496: -- Apparently the entire push api now gets a refactoring:

[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-09 Thread GitBox
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1308715686 Cool thanks waiting for the merge then, after that I will check the issue again, and if fixed can close it. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [myfaces] melloware commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-09 Thread GitBox
melloware commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1308697053 cc @milansie as WebSockets was just refactored with this PR: https://github.com/apache/myfaces/pull/327 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [myfaces] melloware merged pull request #371: MYFACES-4493: Allow Jakarta and JCP namespaces for FacesComponent

2022-11-09 Thread GitBox
melloware merged PR #371: URL: https://github.com/apache/myfaces/pull/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] melloware merged pull request #372: MYFACES-4494: Fix Element Ordering

2022-11-09 Thread GitBox
melloware merged PR #372: URL: https://github.com/apache/myfaces/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] pnicolucci merged pull request #377: MYFACES-4495: Throw NPE when necessary

2022-11-09 Thread GitBox
pnicolucci merged PR #377: URL: https://github.com/apache/myfaces/pull/377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (TOBAGO-2167) Markup small/large for form-components

2022-11-09 Thread Jira
Henning Nöth created TOBAGO-2167: Summary: Markup small/large for form-components Key: TOBAGO-2167 URL: https://issues.apache.org/jira/browse/TOBAGO-2167 Project: MyFaces Tobago Issue Type:

[GitHub] [myfaces] cristof commented on a diff in pull request #366: Fixing localized composite behaviour (3.0.x)

2022-11-09 Thread GitBox
cristof commented on code in PR #366: URL: https://github.com/apache/myfaces/pull/366#discussion_r1017812955 ## api/src/main/java/jakarta/faces/component/UIComponent.java: ## @@ -1842,4 +1841,41 @@ public void setTransient(boolean newTransientValue) } }

[GitHub] [myfaces] cristof commented on a diff in pull request #366: Fixing localized composite behaviour (3.0.x)

2022-11-09 Thread GitBox
cristof commented on code in PR #366: URL: https://github.com/apache/myfaces/pull/366#discussion_r1017812955 ## api/src/main/java/jakarta/faces/component/UIComponent.java: ## @@ -1842,4 +1841,41 @@ public void setTransient(boolean newTransientValue) } }

[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-09 Thread GitBox
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1308521951 Hi I have isolated the problem and filed a bugreport: https://issues.apache.org/jira/browse/MYFACES-4496 If anyone wants to look into this, self running example for demonstrating it

[jira] [Created] (MYFACES-4496) Server side Websocket/Push Implementation not working

2022-11-09 Thread Werner Punz (Jira)
Werner Punz created MYFACES-4496: Summary: Server side Websocket/Push Implementation not working Key: MYFACES-4496 URL: https://issues.apache.org/jira/browse/MYFACES-4496 Project: MyFaces Core

[GitHub] [myfaces] tandraschko commented on a diff in pull request #366: Fixing localized composite behaviour (3.0.x)

2022-11-09 Thread GitBox
tandraschko commented on code in PR #366: URL: https://github.com/apache/myfaces/pull/366#discussion_r1017675637 ## api/src/main/java/jakarta/faces/component/UIComponent.java: ## @@ -1842,4 +1841,41 @@ public void setTransient(boolean newTransientValue) }

[jira] [Created] (TOBAGO-2166) Label text should be aligned at top

2022-11-09 Thread Jira
Henning Nöth created TOBAGO-2166: Summary: Label text should be aligned at top Key: TOBAGO-2166 URL: https://issues.apache.org/jira/browse/TOBAGO-2166 Project: MyFaces Tobago Issue Type:

[GitHub] [myfaces] tandraschko commented on pull request #372: MYFACES-4494: Fix Element Ordering

2022-11-09 Thread GitBox
tandraschko commented on PR #372: URL: https://github.com/apache/myfaces/pull/372#issuecomment-1308394538 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [myfaces] tandraschko commented on pull request #371: MYFACES-4493: Allow Jakarta and JCP namespaces for FacesComponent

2022-11-09 Thread GitBox
tandraschko commented on PR #371: URL: https://github.com/apache/myfaces/pull/371#issuecomment-1308395377 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [myfaces] tandraschko commented on pull request #377: MYFACES-4495: Throw NPE when necessary

2022-11-09 Thread GitBox
tandraschko commented on PR #377: URL: https://github.com/apache/myfaces/pull/377#issuecomment-1308394228 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To