[GitHub] [myfaces] tandraschko commented on pull request #484: MYFACES-4550: throw exception if f:validateWholeBean is misplaced

2023-01-17 Thread GitBox
tandraschko commented on PR #484: URL: https://github.com/apache/myfaces/pull/484#issuecomment-1386601234 Actually this is a exception which already fails in development mode I would not increase the buffer size in general for this -- This is an automated message from the Apache

Re: [jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-17 Thread Werner Punz
Yes atm only the id is updated in the js not the name. However in the new codebase (I have to check the old whether I did the same) it is taken into consideration that the name also can be prefixed! Prefixing the name is a 2 liner, but I kept it deliberately out just not to break anything until

[GitHub] [myfaces] melloware commented on pull request #484: MYFACES-4550: throw exception if f:validateWholeBean is misplaced

2023-01-17 Thread GitBox
melloware commented on PR #484: URL: https://github.com/apache/myfaces/pull/484#issuecomment-1386142188 Just an FYI Mojarra had a similar recent issue about not respecting FACELETS_BUFFER_SIZE. https://github.com/eclipse-ee4j/mojarra/issues/5164 -- This is an automated message from the

[GitHub] [myfaces] volosied commented on pull request #484: MYFACES-4550: throw exception if f:validateWholeBean is misplaced

2023-01-17 Thread GitBox
volosied commented on PR #484: URL: https://github.com/apache/myfaces/pull/484#issuecomment-1386094408 Need to run this against the TCK before merging. Also, the TCK needs to increase the jakarta.faces.FACELETS_BUFFER_SIZE param since we commit the response before the exception. --

[GitHub] [myfaces] volosied opened a new pull request, #484: MYFACES-4550: throw exception if f:validateWholeBean is misplaced

2023-01-17 Thread GitBox
volosied opened a new pull request, #484: URL: https://github.com/apache/myfaces/pull/484 https://issues.apache.org/jira/browse/MYFACES-4550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (MYFACES-4550) f:validateWholeBean must be placed after all validated fields

2023-01-17 Thread Volodymyr Siedlecki (Jira)
Volodymyr Siedlecki created MYFACES-4550: Summary: f:validateWholeBean must be placed after all validated fields Key: MYFACES-4550 URL: https://issues.apache.org/jira/browse/MYFACES-4550

[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-17 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677963#comment-17677963 ] Volodymyr Siedlecki commented on MYFACES-4533: -- Yes, I tried to prefix the name with the

[jira] [Commented] (MYFACES-4489) TCK: Spec3001IT: Abandon Flows

2023-01-17 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677956#comment-17677956 ] Volodymyr Siedlecki commented on MYFACES-4489: -- I have some other issues in progress now,

[jira] [Commented] (MYFACES-4549) Remove reflection hacks as we rely now on never spec versions

2023-01-17 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677915#comment-17677915 ] Volodymyr Siedlecki commented on MYFACES-4549: -- Commits:

[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-17 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677906#comment-17677906 ] Werner Punz commented on MYFACES-4533: -- Yes I need to get everything together on this issue, the

[jira] [Resolved] (MYFACES-4549) Remove reflection hacks as we rely now on never spec versions

2023-01-17 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4549. Resolution: Fixed > Remove reflection hacks as we rely now on never spec

[jira] [Created] (MYFACES-4549) Remove reflection hacks as we rely now on never spec versions

2023-01-17 Thread Thomas Andraschko (Jira)
Thomas Andraschko created MYFACES-4549: -- Summary: Remove reflection hacks as we rely now on never spec versions Key: MYFACES-4549 URL: https://issues.apache.org/jira/browse/MYFACES-4549 Project:

[jira] [Commented] (MYFACES-4547) FacesContext.getCurrentInstance().getELContext().getVariableMapper() returns null

2023-01-17 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677829#comment-17677829 ] Thomas Andraschko commented on MYFACES-4547: yeah, why not Mojarra does the same, shouldnt

[jira] [Commented] (MYFACES-4537) Investigate Inner / Outer Ajax Tags

2023-01-17 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677824#comment-17677824 ] Thomas Andraschko commented on MYFACES-4537: lets close this for now till its a TCK

[jira] [Created] (MYFACES-4548) Set default o.a.m.USE_LAMBDA_METAFACTORY to false

2023-01-17 Thread Paul Nicolucci (Jira)
Paul Nicolucci created MYFACES-4548: --- Summary: Set default o.a.m.USE_LAMBDA_METAFACTORY to false Key: MYFACES-4548 URL: https://issues.apache.org/jira/browse/MYFACES-4548 Project: MyFaces Core

[jira] [Created] (MYFACES-4547) FacesContext.getCurrentInstance().getELContext().getVariableMapper() returns null

2023-01-17 Thread Paul Nicolucci (Jira)
Paul Nicolucci created MYFACES-4547: --- Summary: FacesContext.getCurrentInstance().getELContext().getVariableMapper() returns null Key: MYFACES-4547 URL: https://issues.apache.org/jira/browse/MYFACES-4547

[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-17 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677811#comment-17677811 ] Volodymyr Siedlecki commented on MYFACES-4533: -- I though we would challenge part of the

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-17 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677807#comment-17677807 ] Werner Punz edited comment on MYFACES-4533 at 1/17/23 3:23 PM: --- I will

[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-17 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677807#comment-17677807 ] Werner Punz commented on MYFACES-4533: -- I will take over it tomorrow.   > TCK: Spec 790:

[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-17 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677805#comment-17677805 ] Thomas Andraschko commented on MYFACES-4533: [~werpu] can you check how its implemented and

[jira] [Commented] (MYFACES-4489) TCK: Spec3001IT: Abandon Flows

2023-01-17 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677803#comment-17677803 ] Thomas Andraschko commented on MYFACES-4489: [~volosied]can you take care of this? > TCK:

[jira] [Commented] (MYFACES-4505) TCK: Spec1567IT: Ajax does not execute specified targets in composite component

2023-01-17 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677797#comment-17677797 ] Volodymyr Siedlecki commented on MYFACES-4505: -- Fix:

[jira] [Commented] (MYFACES-4505) TCK: Spec1567IT: Ajax does not execute specified targets in composite component

2023-01-17 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677798#comment-17677798 ] Volodymyr Siedlecki commented on MYFACES-4505: -- Thanks [~tandraschko] ! > TCK:

[jira] [Resolved] (MYFACES-4505) TCK: Spec1567IT: Ajax does not execute specified targets in composite component

2023-01-17 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4505. Resolution: Fixed > TCK: Spec1567IT: Ajax does not execute specified targets in

Re: MyFaces 4.0 LambdaBeanELResolver discussion

2023-01-17 Thread Thomas Andraschko
Doenst also matter for me 2.3-next is no spec compliant anyway ;) Am Di., 17. Jan. 2023 um 14:49 Uhr schrieb Melloware : > I am OK with either you can leave 2.3-next and just change 4.0 if you want. > > > On 1/17/2023 8:46 AM, Paul Nicolucci wrote: > > Thomas, > > Thoughts on changing 2.3-next

Re: MyFaces 4.0 LambdaBeanELResolver discussion

2023-01-17 Thread Melloware
I am OK with either you can leave 2.3-next and just change 4.0 if you want. On 1/17/2023 8:46 AM, Paul Nicolucci wrote: Thomas, Thoughts on changing 2.3-next and 4.0 vs just changing the default for 4.0? Thanks, Paul Nicolucci On Mon, Jan 16, 2023 at 4:42 AM Thomas Andraschko wrote:

Re: MyFaces 4.0 LambdaBeanELResolver discussion

2023-01-17 Thread Paul Nicolucci
Thomas, Thoughts on changing 2.3-next and 4.0 vs just changing the default for 4.0? Thanks, Paul Nicolucci On Mon, Jan 16, 2023 at 4:42 AM Thomas Andraschko < andraschko.tho...@gmail.com> wrote: > for me its ok, so 0.25 ;) > > please also change the default value on the homepage > > Am Sa.,

[GitHub] [myfaces] bohmber commented on pull request #483: build(ci): chromedriver version 109.0.5414.25 contains two files.

2023-01-17 Thread GitBox
bohmber commented on PR #483: URL: https://github.com/apache/myfaces/pull/483#issuecomment-1385358820 @bartoszmajsak thanks a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [myfaces] bartoszmajsak commented on pull request #483: build(ci): chromedriver version 109.0.5414.25 contains two files.

2023-01-17 Thread GitBox
bartoszmajsak commented on PR #483: URL: https://github.com/apache/myfaces/pull/483#issuecomment-1385350575 @bohmber FYI I've just released Drone 3.0.0-alpha.7 with the fix for this very issue. It's already available in official JBoss Repository and should be synced with Maven Central

[jira] [Comment Edited] (MYFACES-4513) TCK Testing Issue 1: Faces 2.2 - Issue2179IT encodeAll not called in Ajax Cycle and custom component

2023-01-17 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677721#comment-17677721 ] Werner Punz edited comment on MYFACES-4513 at 1/17/23 11:29 AM:

[jira] [Comment Edited] (MYFACES-4513) TCK Testing Issue 1: Faces 2.2 - Issue2179IT encodeAll not called in Ajax Cycle and custom component

2023-01-17 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677721#comment-17677721 ] Werner Punz edited comment on MYFACES-4513 at 1/17/23 11:29 AM:

[jira] [Commented] (MYFACES-4513) TCK Testing Issue 1: Faces 2.2 - Issue2179IT encodeAll not called in Ajax Cycle and custom component

2023-01-17 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677721#comment-17677721 ] Werner Punz commented on MYFACES-4513: -- Probably also filed before I switched branches. I will

[jira] [Resolved] (MYFACES-4513) TCK Testing Issue 1: Faces 2.2 - Issue2179IT encodeAll not called in Ajax Cycle and custom component

2023-01-17 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4513. Resolution: Fixed > TCK Testing Issue 1: Faces 2.2 - Issue2179IT encodeAll not

[jira] [Commented] (MYFACES-4513) TCK Testing Issue 1: Faces 2.2 - Issue2179IT encodeAll not called in Ajax Cycle and custom component

2023-01-17 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677715#comment-17677715 ] Werner Punz commented on MYFACES-4513: -- Yes works now

[jira] [Commented] (MYFACES-4513) TCK Testing Issue 1: Faces 2.2 - Issue2179IT encodeAll not called in Ajax Cycle and custom component

2023-01-17 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677702#comment-17677702 ] Thomas Andraschko commented on MYFACES-4513: [~werpu] can you rerun this? it seems to work

[GitHub] [myfaces] bohmber commented on pull request #483: build(ci): chromedriver version 109.0.5414.25 contains two files.

2023-01-17 Thread GitBox
bohmber commented on PR #483: URL: https://github.com/apache/myfaces/pull/483#issuecomment-1385101065 #https://github.com/arquillian/arquillian-extension-drone/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use