Re: [VOTE] Release of MyFaces Core 4.0.0-RC4

2023-01-24 Thread Volodymyr Siedlecki
Melloware & Thomas - Please verify the Quarkus utilities you need are there. I decided to not to include MYFACES-4551 & MYFACES-4550 in this release, so we can have them merged later. I'll review this release and vote later. Best, Volodymyr On 2023/01/25 03:08:29 Volodymyr Siedlecki wrote:

[VOTE] Release Tobago 5.5.0 and checkstyle-rules 21

2023-01-24 Thread Udo Schnurpfeil
Hello, we would like to release: * Tobago 5.5.0 * checkstyle-rules 21 The artifacts were deployed on nexus repository for binary and source packages: * Tobago 5.5.0 [1] & checkstyle-rules 21 [2] The release notes are in Jira: * Tobago 5.5.0 [3] The artifacts are available at the staging

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3699: chore(release): prepare 5.5.1-SNAPSHOT

2023-01-24 Thread via GitHub
lofwyr14 merged PR #3699: URL: https://github.com/apache/myfaces-tobago/pull/3699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] volosied commented on a diff in pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

2023-01-24 Thread via GitHub
volosied commented on code in PR #492: URL: https://github.com/apache/myfaces/pull/492#discussion_r1085984802 ## api/src/main/java/jakarta/faces/component/UISelectOne.java: ## @@ -90,37 +91,43 @@ public void processValidators(FacesContext context) @Override

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3698: chore(release): prepare 5.5.0

2023-01-24 Thread via GitHub
lofwyr14 merged PR #3698: URL: https://github.com/apache/myfaces-tobago/pull/3698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] melloware commented on pull request #502: Fixes for TCK 790 on main

2023-01-24 Thread via GitHub
melloware commented on PR #502: URL: https://github.com/apache/myfaces/pull/502#issuecomment-1402615124 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3692: build(deps-dev): bump selenium-java from 4.7.2 to 4.8.0

2023-01-24 Thread via GitHub
lofwyr14 merged PR #3692: URL: https://github.com/apache/myfaces-tobago/pull/3692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3693: build(deps): bump meecrowave.version from 1.2.14 to 1.2.15

2023-01-24 Thread via GitHub
lofwyr14 merged PR #3693: URL: https://github.com/apache/myfaces-tobago/pull/3693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3695: build(deps-dev): bump selenium-java from 4.7.2 to 4.8.0

2023-01-24 Thread via GitHub
lofwyr14 merged PR #3695: URL: https://github.com/apache/myfaces-tobago/pull/3695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3694: build(deps): bump tomee-maven-plugin from 8.0.13 to 8.0.14

2023-01-24 Thread via GitHub
lofwyr14 merged PR #3694: URL: https://github.com/apache/myfaces-tobago/pull/3694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-24 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680282#comment-17680282 ] Werner Punz commented on MYFACES-4533: -- No worries, I will be assigned to a new project, so my

[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-24 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680277#comment-17680277 ] Volodymyr Siedlecki commented on MYFACES-4533: -- Working on a few other things right now,

[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-24 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680270#comment-17680270 ] Werner Punz commented on MYFACES-4533: -- I have added a pr for main now which adds the fixes from

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-24 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680270#comment-17680270 ] Werner Punz edited comment on MYFACES-4533 at 1/24/23 3:49 PM: --- I have

[GitHub] [myfaces] werpu commented on pull request #502: Fixes for TCK 790 on main

2023-01-24 Thread via GitHub
werpu commented on PR #502: URL: https://github.com/apache/myfaces/pull/502#issuecomment-1402170090 Reopened after fixing a last minute issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [myfaces] tandraschko commented on a diff in pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

2023-01-24 Thread via GitHub
tandraschko commented on code in PR #492: URL: https://github.com/apache/myfaces/pull/492#discussion_r1085476849 ## api/src/main/java/jakarta/faces/component/UISelectOne.java: ## @@ -90,37 +91,43 @@ public void processValidators(FacesContext context) @Override

[GitHub] [myfaces] werpu commented on pull request #502: Fixes for TCK 790 on main

2023-01-24 Thread via GitHub
werpu commented on PR #502: URL: https://github.com/apache/myfaces/pull/502#issuecomment-1402111970 Sorry.. please do not use it yet, I still found a last issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [myfaces] werpu commented on pull request #502: Fixes for TCK 790 on main

2023-01-24 Thread via GitHub
werpu commented on PR #502: URL: https://github.com/apache/myfaces/pull/502#issuecomment-1402112317 closing it for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [myfaces] werpu closed pull request #502: Fixes for TCK 790 on main

2023-01-24 Thread via GitHub
werpu closed pull request #502: Fixes for TCK 790 on main URL: https://github.com/apache/myfaces/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [myfaces] tandraschko commented on pull request #484: MYFACES-4550: throw exception if f:validateWholeBean is misplaced

2023-01-24 Thread via GitHub
tandraschko commented on PR #484: URL: https://github.com/apache/myfaces/pull/484#issuecomment-140211 As i said, i would skip the whole checks on dev stage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: 4.0.RC4?

2023-01-24 Thread Volodymyr Siedlecki
Hi, I will start a release today. Thomas, please review the PRs if you can. If not, I’ll just make a release without them. https://github.com/apache/myfaces/pull/492 https://github.com/apache/myfaces/pull/484 Thanks, Volodymyr On 2023/01/23 18:34:33 Paul Nicolucci wrote: > No

[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-24 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680253#comment-17680253 ] Werner Punz commented on MYFACES-4533: -- I have provided a backport into the old codebase under

[GitHub] [myfaces] werpu commented on pull request #502: Fixes for TCK 790 on main

2023-01-24 Thread via GitHub
werpu commented on PR #502: URL: https://github.com/apache/myfaces/pull/502#issuecomment-1402101255 Do not merge this in util the server side implementation is fixed to be able to deal with namespaces. You can use it as a base for the namespace tck though -- This is an automated

[GitHub] [myfaces] werpu opened a new pull request, #502: Fixes for TCK 790 on main

2023-01-24 Thread via GitHub
werpu opened a new pull request, #502: URL: https://github.com/apache/myfaces/pull/502 Fixes for the old codebase for main, server implementation still pending (need to do someone else) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Resolved] (TOBAGO-2190) Use scss default variables for icons

2023-01-24 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2190. -- Fix Version/s: 5.5.0 Resolution: Fixed > Use scss default variables for icons >

[GitHub] [myfaces-tobago] henningn merged pull request #3697: feat(theme): scss default variables

2023-01-24 Thread via GitHub
henningn merged PR #3697: URL: https://github.com/apache/myfaces-tobago/pull/3697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] henningn merged pull request #3696: feat(theme): scss default variables

2023-01-24 Thread via GitHub
henningn merged PR #3696: URL: https://github.com/apache/myfaces-tobago/pull/3696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (TOBAGO-2190) Use scss default variables for icons

2023-01-24 Thread Jira
Henning Nöth created TOBAGO-2190: Summary: Use scss default variables for icons Key: TOBAGO-2190 URL: https://issues.apache.org/jira/browse/TOBAGO-2190 Project: MyFaces Tobago Issue Type:

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-24 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679785#comment-17679785 ] Werner Punz edited comment on MYFACES-4533 at 1/24/23 8:24 AM: --- Hi... the