[jira] [Commented] (MYFACES-4556) LambdaBeanELResolver#getType should return null if the resolved property is read-only

2023-01-31 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682771#comment-17682771 ] Volodymyr Siedlecki commented on MYFACES-4556: -- [~tandraschko] Can I assign this to you

[jira] [Created] (MYFACES-4556) LambdaBeanELResolver#getType should return null if the resolved property is read-only

2023-01-31 Thread Volodymyr Siedlecki (Jira)
Volodymyr Siedlecki created MYFACES-4556: Summary: LambdaBeanELResolver#getType should return null if the resolved property is read-only Key: MYFACES-4556 URL:

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682560#comment-17682560 ] Werner Punz edited comment on MYFACES-4533 at 1/31/23 8:22 PM: ---

[GitHub] [myfaces] volosied merged pull request #509: SPEC-1558 UIComponent#subscribeToEvent() should not allow duplicate values

2023-01-31 Thread via GitHub
volosied merged PR #509: URL: https://github.com/apache/myfaces/pull/509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] bohmber commented on pull request #509: SPEC-1558 UIComponent#subscribeToEvent() should not allow duplicate values

2023-01-31 Thread via GitHub
bohmber commented on PR #509: URL: https://github.com/apache/myfaces/pull/509#issuecomment-1410874538 Please don't reference the mojarra code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [myfaces] KyleAure opened a new pull request, #509: SPEC-1558 UIComponent#subscribeToEvent() should not allow duplicate values

2023-01-31 Thread via GitHub
KyleAure opened a new pull request, #509: URL: https://github.com/apache/myfaces/pull/509 This issue was previously tracked by https://issues.apache.org/jira/browse/MYFACES-4385 No TCK test was ever written for this change in SPEC documentation, so I wrote a test here:

[GitHub] [myfaces] KyleAure closed pull request #508: FacesConfig#version() cannot return null

2023-01-31 Thread via GitHub
KyleAure closed pull request #508: FacesConfig#version() cannot return null URL: https://github.com/apache/myfaces/pull/508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [myfaces] KyleAure commented on pull request #508: FacesConfig#version() cannot return null

2023-01-31 Thread via GitHub
KyleAure commented on PR #508: URL: https://github.com/apache/myfaces/pull/508#issuecomment-1410622089 Oops looks like it was already fixed yesterday :) Closing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [myfaces] melloware commented on pull request #508: FacesConfig#version() cannot return null

2023-01-31 Thread via GitHub
melloware commented on PR #508: URL: https://github.com/apache/myfaces/pull/508#issuecomment-1410622044 I think @tandraschko already made this fix in 4.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [myfaces] KyleAure opened a new pull request, #508: FacesConfig#version() cannot return null

2023-01-31 Thread via GitHub
KyleAure opened a new pull request, #508: URL: https://github.com/apache/myfaces/pull/508 Related to https://github.com/jakartaee/faces/issues/1784 Mojarra already fixed: https://github.com/eclipse-ee4j/mojarra/pull/5210 We need to return a valid value and not null. Mojarra

[GitHub] [myfaces] tandraschko commented on pull request #502: Fixes for TCK 790 on main

2023-01-31 Thread via GitHub
tandraschko commented on PR #502: URL: https://github.com/apache/myfaces/pull/502#issuecomment-1410552804 TBH im not sure if we should backport it to older branches viewroot namespacing is only used in portlets and no portlet impl uses myfaces so this is only for be TCK compatible and

[GitHub] [myfaces] melloware commented on pull request #502: Fixes for TCK 790 on main

2023-01-31 Thread via GitHub
melloware commented on PR #502: URL: https://github.com/apache/myfaces/pull/502#issuecomment-1410536644 Nice work! I appreciated the persistence! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [myfaces] werpu commented on pull request #502: Fixes for TCK 790 on main

2023-01-31 Thread via GitHub
werpu commented on PR #502: URL: https://github.com/apache/myfaces/pull/502#issuecomment-1410533556 Btw. I already have prepared fixes for master, 2.3-next and 2.3 is still in work, so once we merge this code in, expect a fix for master relatively quickly, 2.3-next and 2.3 need some

[GitHub] [myfaces] werpu commented on pull request #502: Fixes for TCK 790 on main

2023-01-31 Thread via GitHub
werpu commented on PR #502: URL: https://github.com/apache/myfaces/pull/502#issuecomment-1410531014 I left this todo in as point of discussion, see also my last comment on MyFaces 4533! I will fix it as soon as everyone is ok with a strategy on how we optimize it! This is not ready

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682560#comment-17682560 ] Werner Punz edited comment on MYFACES-4533 at 1/31/23 3:04 PM: ---

[GitHub] [myfaces] melloware commented on a diff in pull request #502: Fixes for TCK 790 on main

2023-01-31 Thread via GitHub
melloware commented on code in PR #502: URL: https://github.com/apache/myfaces/pull/502#discussion_r1091945660 ## impl/src/main/java/org/apache/myfaces/renderkit/html/ParamsNamingContainerResolver.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682560#comment-17682560 ] Werner Punz edited comment on MYFACES-4533 at 1/31/23 1:06 PM: ---

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682560#comment-17682560 ] Werner Punz edited comment on MYFACES-4533 at 1/31/23 1:04 PM: ---

[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682560#comment-17682560 ] Werner Punz commented on MYFACES-4533: --

[jira] [Commented] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682551#comment-17682551 ] Werner Punz commented on MYFACES-4533: -- Test Results with my patches in: Faces22 / ajax

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682162#comment-17682162 ] Werner Punz edited comment on MYFACES-4533 at 1/31/23 12:33 PM: I will

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682162#comment-17682162 ] Werner Punz edited comment on MYFACES-4533 at 1/31/23 12:31 PM: I will

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682162#comment-17682162 ] Werner Punz edited comment on MYFACES-4533 at 1/31/23 9:57 AM: --- I will

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682162#comment-17682162 ] Werner Punz edited comment on MYFACES-4533 at 1/31/23 9:56 AM: --- I will

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682162#comment-17682162 ] Werner Punz edited comment on MYFACES-4533 at 1/31/23 9:00 AM: --- I will

[jira] [Comment Edited] (MYFACES-4533) TCK: Spec 790: Viewstate input element's name attribute should be prefixed with naming container id

2023-01-31 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682162#comment-17682162 ] Werner Punz edited comment on MYFACES-4533 at 1/31/23 8:11 AM: --- I will