Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-21 Thread Volodymyr Siedlecki
Thank you as always. Let me know if I can help port over any tests, so we can split the work. Volodymyr On 2023/02/21 15:31:30 Werner Punz wrote: > Yes... I will work on them, I just converted the first one. > This is indeed the usual Rhino Problem. > I tackled for the Ajax parts of the TCK! >

[GitHub] [myfaces] melloware opened a new pull request, #532: MYFACES-4571: 2.3-next substitute tag url in native mode

2023-02-21 Thread via GitHub
melloware opened a new pull request, #532: URL: https://github.com/apache/myfaces/pull/532 This handles it as cleanly as I could find where it substitutes the Facelet Tag Creation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3781: Feat: Using lit-html in TypeScript

2023-02-21 Thread via GitHub
lofwyr14 merged PR #3781: URL: https://github.com/apache/myfaces-tobago/pull/3781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] lofwyr14 opened a new pull request, #3781: Feat: Using lit-html in TypeScript

2023-02-21 Thread via GitHub
lofwyr14 opened a new pull request, #3781: URL: https://github.com/apache/myfaces-tobago/pull/3781 because of better security issue: TOBAGO-2197 # Conflicts: #tobago-theme/tobago-theme-standard/src/main/js/tobago.js #

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3780: build: update jquery version of demo

2023-02-21 Thread via GitHub
lofwyr14 merged PR #3780: URL: https://github.com/apache/myfaces-tobago/pull/3780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3777: Lit html

2023-02-21 Thread via GitHub
lofwyr14 merged PR #3777: URL: https://github.com/apache/myfaces-tobago/pull/3777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3779: build(deps): bump log4j.version from 2.19.0 to 2.20.0

2023-02-21 Thread via GitHub
lofwyr14 merged PR #3779: URL: https://github.com/apache/myfaces-tobago/pull/3779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3778: build: update jquery version of demo

2023-02-21 Thread via GitHub
lofwyr14 merged PR #3778: URL: https://github.com/apache/myfaces-tobago/pull/3778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (MYFACES-4572) faces.getProjectStage() does not return Production

2023-02-21 Thread Volodymyr Siedlecki (Jira)
Volodymyr Siedlecki created MYFACES-4572: Summary: faces.getProjectStage() does not return Production Key: MYFACES-4572 URL: https://issues.apache.org/jira/browse/MYFACES-4572 Project: MyFaces

[GitHub] [myfaces-tobago] dependabot[bot] opened a new pull request, #3779: build(deps): bump log4j.version from 2.19.0 to 2.20.0

2023-02-21 Thread via GitHub
dependabot[bot] opened a new pull request, #3779: URL: https://github.com/apache/myfaces-tobago/pull/3779 Bumps `log4j.version` from 2.19.0 to 2.20.0. Updates `log4j-core` from 2.19.0 to 2.20.0 Commits

[jira] [Commented] (MYFACES-4571) Quarkus: GraalVM Native never use JAR resource

2023-02-21 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691701#comment-17691701 ] Thomas Andraschko commented on MYFACES-4571: TBH: no idea i would check how the paths are

[jira] [Created] (MYFACES-4571) Quarkus: GraalVM Native never use JAR resource

2023-02-21 Thread Melloware (Jira)
Melloware created MYFACES-4571: -- Summary: Quarkus: GraalVM Native never use JAR resource Key: MYFACES-4571 URL: https://issues.apache.org/jira/browse/MYFACES-4571 Project: MyFaces Core Issue

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-21 Thread Werner Punz
Yes... I will work on them, I just converted the first one. This is indeed the usual Rhino Problem. I tackled for the Ajax parts of the TCK! Expect the fixed scripts to hit the TCK this week, I will simply will fix it in the evening. Vacation or not! Werner Am Di., 21. Feb. 2023 um 16:25 Uhr

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-21 Thread Thomas Andraschko
it would be really great if we just fix the new failing tests, this are only ~10 test classes. the new scripts are really a great benefit for the future Am Di., 21. Feb. 2023 um 16:10 Uhr schrieb Werner Punz < werner.p...@gmail.com>: > Sorry I missed this thread. > I will work on the list.

Re: faces_ts plans for post 4.0.0 release

2023-02-21 Thread Werner Punz
Btw. sorry for missing the revert thread earlier. Werner Am Di., 21. Feb. 2023 um 16:14 Uhr schrieb Werner Punz < werner.p...@gmail.com>: > Sure I will work on them. Will take a few days though, given that I am on > vacation the next 3 days. > Either late this week or early next week I will

Re: faces_ts plans for post 4.0.0 release

2023-02-21 Thread Werner Punz
Sure I will work on them. Will take a few days though, given that I am on vacation the next 3 days. Either late this week or early next week I will issue a pull request. Is the list complete or are there other tests missing? Am Di., 21. Feb. 2023 um 16:04 Uhr schrieb Paul Nicolucci <

Re: Requesting Revert of MYFACES-4466 (PR #514)

2023-02-21 Thread Werner Punz
Sorry I missed this thread. I will work on the list. Problem is I am not working until next monday. But I will see what I can do in my sparetime. Thing is, this entire Rhino situation makes me somewhat uneasy if there is a huge time pressure. We probably should postpone the big switch to a 4.1

Re: faces_ts plans for post 4.0.0 release

2023-02-21 Thread Paul Nicolucci
Can you help with the Selenium updates as you did previously? Regards, Paul Nicolucci On Tue, Feb 21, 2023 at 10:01 AM Werner Punz wrote: > Hi...the failing tests, if they are Rhino related need to be ported over > to Selenium. > Rhino simply is not up to the task anymore. > > Also we can

Re: faces_ts plans for post 4.0.0 release

2023-02-21 Thread Werner Punz
Hi...the failing tests, if they are Rhino related need to be ported over to Selenium. Rhino simply is not up to the task anymore. Also we can revert the scripts back and make 4.0 with the old ones, And maybe make a later release with the new ones. I am open for that as well. Whatever you feel is

[jira] [Created] (TOBAGO-2197) Using lit-html in TypeScript

2023-02-21 Thread Udo Schnurpfeil (Jira)
Udo Schnurpfeil created TOBAGO-2197: --- Summary: Using lit-html in TypeScript Key: TOBAGO-2197 URL: https://issues.apache.org/jira/browse/TOBAGO-2197 Project: MyFaces Tobago Issue Type:

Re: faces_ts plans for post 4.0.0 release

2023-02-21 Thread Paul Nicolucci
Hey Werner! Thanks! I hate to hijack this thread but wanted to make sure you were aware of the issues we're facing with the TCK and the new JS. We have a thread started yesterday: https://markmail.org/message/ebpszw2hqyovp6ue#query:+page:1+mid:pvnqrp7oqkh24aud+state:results Regards, Paul

[jira] [Resolved] (MYFACES-4570) FacesJSResourceLoader.getResourceInputStream NPE

2023-02-21 Thread Paul Nicolucci (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Nicolucci resolved MYFACES-4570. - Resolution: Fixed > FacesJSResourceLoader.getResourceInputStream NPE >

[GitHub] [myfaces] melloware merged pull request #531: MYFACES-4570: fix NPE

2023-02-21 Thread via GitHub
melloware merged PR #531: URL: https://github.com/apache/myfaces/pull/531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] melloware commented on pull request #531: MYFACES-4570: fix NPE

2023-02-21 Thread via GitHub
melloware commented on PR #531: URL: https://github.com/apache/myfaces/pull/531#issuecomment-1438523227 Yep and I sent @bohmber a note its saying something about Drone only supporting Chrome 108 and I bet GitHub Actions Linux is is on Chrome 110. I don't fully understand the Drone stuff.

[jira] [Commented] (MYFACES-4567) JavaScript Doc Errors For New Scripts

2023-02-21 Thread Werner Punz (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691610#comment-17691610 ] Werner Punz commented on MYFACES-4567: -- Thanks for resolving it > JavaScript Doc Errors For New

[GitHub] [myfaces] pnicolucci commented on pull request #531: MYFACES-4570: fix NPE

2023-02-21 Thread via GitHub
pnicolucci commented on PR #531: URL: https://github.com/apache/myfaces/pull/531#issuecomment-1438519836 @melloware should have been obvious to me :) Thanks! Look good now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [myfaces] melloware commented on a diff in pull request #531: MYFACES-4570: fix NPE

2023-02-21 Thread via GitHub
melloware commented on code in PR #531: URL: https://github.com/apache/myfaces/pull/531#discussion_r1113056200 ## impl/src/main/java/org/apache/myfaces/resource/FacesJSResourceLoader.java: ## @@ -95,7 +96,7 @@ public InputStream getResourceInputStream(ResourceMeta

[GitHub] [myfaces] pnicolucci commented on pull request #531: MYFACES-4570: fix NPE

2023-02-21 Thread via GitHub
pnicolucci commented on PR #531: URL: https://github.com/apache/myfaces/pull/531#issuecomment-1438485746 @tandraschko look better? Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (MYFACES-4569) Quarkus: Register java types for reflection

2023-02-21 Thread Melloware (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Melloware resolved MYFACES-4569. Resolution: Fixed > Quarkus: Register java types for reflection >

[GitHub] [myfaces] melloware merged pull request #529: MYFACES-4589: Quarkus classes registered for reflection

2023-02-21 Thread via GitHub
melloware merged PR #529: URL: https://github.com/apache/myfaces/pull/529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] melloware merged pull request #530: MYFACES-4589: 2.3-next Quarkus classes registered for reflection

2023-02-21 Thread via GitHub
melloware merged PR #530: URL: https://github.com/apache/myfaces/pull/530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] pnicolucci commented on pull request #531: MYFACES-4570: fix NPE

2023-02-21 Thread via GitHub
pnicolucci commented on PR #531: URL: https://github.com/apache/myfaces/pull/531#issuecomment-1438474981 fyi looks like our integration tests are broken (unrelated to this PR): `Error:IntegrationTest.testPlainHtml » Runtime Unable to instantiate Drone via

[GitHub] [myfaces] melloware commented on pull request #529: MYFACES-4589: Quarkus classes registered for reflection

2023-02-21 Thread via GitHub
melloware commented on PR #529: URL: https://github.com/apache/myfaces/pull/529#issuecomment-1438474349 I also found an issue in OmniFaces parsing web.xml missing Xpath classes so I migrated those changes here too. Switched the java classes from String to Class.getName() -- This is an

[GitHub] [myfaces] tandraschko commented on pull request #529: MYFACES-4589: Quarkus classes registered for reflection

2023-02-21 Thread via GitHub
tandraschko commented on PR #529: URL: https://github.com/apache/myfaces/pull/529#issuecomment-1438474076 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [myfaces] pnicolucci commented on pull request #531: MYFACES-4570: fix NPE

2023-02-21 Thread via GitHub
pnicolucci commented on PR #531: URL: https://github.com/apache/myfaces/pull/531#issuecomment-1438471599 > +1 we could do a Objects.equals instead? sure, let me push up a change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [myfaces] melloware commented on a diff in pull request #529: MYFACES-4589: Quarkus classes registered for reflection

2023-02-21 Thread via GitHub
melloware commented on code in PR #529: URL: https://github.com/apache/myfaces/pull/529#discussion_r1113011444 ## extensions/quarkus/deployment/src/main/java/org/apache/myfaces/core/extensions/quarkus/deployment/MyFacesProcessor.java: ## @@ -462,6 +464,25 @@ void

[jira] [Resolved] (MYFACES-4567) JavaScript Doc Errors For New Scripts

2023-02-21 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4567. Resolution: Fixed > JavaScript Doc Errors For New Scripts >

[GitHub] [myfaces] tandraschko merged pull request #526: Fix for https://issues.apache.org/jira/browse/MYFACES-4567

2023-02-21 Thread via GitHub
tandraschko merged PR #526: URL: https://github.com/apache/myfaces/pull/526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] tandraschko commented on a diff in pull request #529: MYFACES-4589: Quarkus classes registered for reflection

2023-02-21 Thread via GitHub
tandraschko commented on code in PR #529: URL: https://github.com/apache/myfaces/pull/529#discussion_r1112994647 ## extensions/quarkus/deployment/src/main/java/org/apache/myfaces/core/extensions/quarkus/deployment/MyFacesProcessor.java: ## @@ -462,6 +464,25 @@ void

[GitHub] [myfaces] tandraschko commented on pull request #531: MYFACES-4570: fix NPE

2023-02-21 Thread via GitHub
tandraschko commented on PR #531: URL: https://github.com/apache/myfaces/pull/531#issuecomment-1438406777 +1 we could do a Objects.equals instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [myfaces] pnicolucci opened a new pull request, #531: MYFACES-4570: fix NPE

2023-02-21 Thread via GitHub
pnicolucci opened a new pull request, #531: URL: https://github.com/apache/myfaces/pull/531 https://issues.apache.org/jira/browse/MYFACES-4570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (MYFACES-4568) Migrate Quarkus PrimeFaces Support out of MyFaces

2023-02-21 Thread Paul Nicolucci (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691575#comment-17691575 ] Paul Nicolucci commented on MYFACES-4568: - Yes, that is exactly what I was in the process of

[jira] [Created] (MYFACES-4570) FacesJSResourceLoader.getResourceInputStream NPE

2023-02-21 Thread Paul Nicolucci (Jira)
Paul Nicolucci created MYFACES-4570: --- Summary: FacesJSResourceLoader.getResourceInputStream NPE Key: MYFACES-4570 URL: https://issues.apache.org/jira/browse/MYFACES-4570 Project: MyFaces Core

[jira] [Commented] (MYFACES-4568) Migrate Quarkus PrimeFaces Support out of MyFaces

2023-02-21 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691573#comment-17691573 ] Thomas Andraschko commented on MYFACES-4568: It was committed after RC5, so it Targets RC6

[jira] [Commented] (MYFACES-4568) Migrate Quarkus PrimeFaces Support out of MyFaces

2023-02-21 Thread Paul Nicolucci (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691567#comment-17691567 ] Paul Nicolucci commented on MYFACES-4568: - [~melloware]  [~tandraschko]  was this done for RC5

[GitHub] [myfaces-homepage] henningn merged pull request #53: update tobago-vm setup.sh

2023-02-21 Thread via GitHub
henningn merged PR #53: URL: https://github.com/apache/myfaces-homepage/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: