Re: [PR] Spec 1584 - Rely on CDI Class Scanning [myfaces]

2023-10-10 Thread via GitHub
volosied commented on PR #615: URL: https://github.com/apache/myfaces/pull/615#issuecomment-1756085115 As for removing the Annotation Provider, does the quarkus extension need it? I see there's a QuarkusAnnotationProvider. -- This is an automated message from the Apache Git Service. To r

Re: [PR] Spec 1584 - Rely on CDI Class Scanning [myfaces]

2023-10-10 Thread via GitHub
volosied commented on code in PR #615: URL: https://github.com/apache/myfaces/pull/615#discussion_r1353137293 ## impl/src/main/java/org/apache/myfaces/config/annotation/DefaultAnnotationProvider.java: ## @@ -128,21 +128,23 @@ public DefaultAnnotationProvider() @Override

[jira] [Comment Edited] (MYFACES-4631) DuplicateIdException via addComponentResource

2023-10-10 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773764#comment-17773764 ] Volodymyr Siedlecki edited comment on MYFACES-4631 at 10/10/23 5:52 PM: -

[jira] [Comment Edited] (MYFACES-4631) DuplicateIdException via addComponentResource

2023-10-10 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773764#comment-17773764 ] Volodymyr Siedlecki edited comment on MYFACES-4631 at 10/10/23 5:51 PM: -

Re: [PR] MYFACES-4631 [myfaces]

2023-10-10 Thread via GitHub
volosied commented on PR #614: URL: https://github.com/apache/myfaces/pull/614#issuecomment-1755941400 I'm not able to recreate a simple test here, but the fix looks right as far I can tell. I will also preform TCK testing later on to verify no regressions occur. -- This is an autom

[jira] [Commented] (MYFACES-4631) DuplicateIdException via addComponentResource

2023-10-10 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773764#comment-17773764 ] Volodymyr Siedlecki commented on MYFACES-4631: -- Some more information I di

[jira] [Commented] (MYFACES-4628) Disabled Value Bug in 4.0 (Erroneous 'value is required' message)

2023-10-10 Thread Volodymyr Siedlecki (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17773756#comment-17773756 ] Volodymyr Siedlecki commented on MYFACES-4628: -- TODO: Port to 4.1 > Disab

[PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.13.0 to 4.14.0 [myfaces-tobago]

2023-10-10 Thread via GitHub
dependabot[bot] opened a new pull request, #4375: URL: https://github.com/apache/myfaces-tobago/pull/4375 Bumps [org.seleniumhq.selenium:selenium-java](https://github.com/SeleniumHQ/selenium) from 4.13.0 to 4.14.0. Release notes Sourced from https://github.com/SeleniumHQ/selenium/

[PR] build(deps): bump org.eclipse.jetty:jetty-maven-plugin from 9.4.52.v20230823 to 9.4.53.v20231009 [myfaces-tobago]

2023-10-10 Thread via GitHub
dependabot[bot] opened a new pull request, #4374: URL: https://github.com/apache/myfaces-tobago/pull/4374 Bumps [org.eclipse.jetty:jetty-maven-plugin](https://github.com/eclipse/jetty.project) from 9.4.52.v20230823 to 9.4.53.v20231009. Release notes Sourced from https://github.com

[PR] build(deps): bump org.eclipse.jetty:jetty-maven-plugin from 9.4.52.v20230823 to 9.4.53.v20231009 [myfaces-tobago]

2023-10-10 Thread via GitHub
dependabot[bot] opened a new pull request, #4373: URL: https://github.com/apache/myfaces-tobago/pull/4373 Bumps [org.eclipse.jetty:jetty-maven-plugin](https://github.com/eclipse/jetty.project) from 9.4.52.v20230823 to 9.4.53.v20231009. Release notes Sourced from https://github.com

[PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.13.0 to 4.14.0 [myfaces-tobago]

2023-10-10 Thread via GitHub
dependabot[bot] opened a new pull request, #4372: URL: https://github.com/apache/myfaces-tobago/pull/4372 Bumps [org.seleniumhq.selenium:selenium-java](https://github.com/SeleniumHQ/selenium) from 4.13.0 to 4.14.0. Release notes Sourced from https://github.com/SeleniumHQ/selenium/

[PR] build(deps): bump org.eclipse.jetty:jetty-maven-plugin from 11.0.16 to 11.0.17 [myfaces-tobago]

2023-10-10 Thread via GitHub
dependabot[bot] opened a new pull request, #4371: URL: https://github.com/apache/myfaces-tobago/pull/4371 Bumps [org.eclipse.jetty:jetty-maven-plugin](https://github.com/eclipse/jetty.project) from 11.0.16 to 11.0.17. Release notes Sourced from https://github.com/eclipse/jetty.pro

[jira] [Resolved] (TOBAGO-2250) Ajax request adds a new meta tag

2023-10-10 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2250. -- Fix Version/s: 6.0.0 Resolution: Fixed > Ajax request adds a new meta tag > ---

Re: [PR] fix: ajax request add new meta tag [myfaces-tobago]

2023-10-10 Thread via GitHub
henningn merged PR #4370: URL: https://github.com/apache/myfaces-tobago/pull/4370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myface

[PR] fix: ajax request add new meta tag [myfaces-tobago]

2023-10-10 Thread via GitHub
henningn opened a new pull request, #4370: URL: https://github.com/apache/myfaces-tobago/pull/4370 * fix subscribe to PreRenderViewEvent if ajax request Issue affect meta, style and script tags. Issue: TOBAGO-2250 -- This is an automated message from the Apache Git Service. To resp