Re: [PR] MYFACES-4623 check for duplicate ids [myfaces]

2023-10-17 Thread via GitHub
volosied commented on PR #607: URL: https://github.com/apache/myfaces/pull/607#issuecomment-1767128386 Tried to create a simple scenario, but so far so luck. This DupId Exception is also difficult to replicate easily. Requirements for this bug to occur are - Composite Compo

Re: [PR] MYFACES-4623 check for duplicate ids [myfaces]

2023-10-17 Thread via GitHub
tandraschko commented on PR #607: URL: https://github.com/apache/myfaces/pull/607#issuecomment-1766566921 i would like to have some tests before merging such a change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (MYFACES-4631) DuplicateIdException via addComponentResource

2023-10-17 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4631. Resolution: Fixed > DuplicateIdException via addComponentResource > -

Re: [PR] MYFACES-4631 [myfaces]

2023-10-17 Thread via GitHub
tandraschko merged PR #614: URL: https://github.com/apache/myfaces/pull/614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apac

Re: [PR] MYFACES-4631 (4.0.x) [myfaces]

2023-10-17 Thread via GitHub
tandraschko merged PR #628: URL: https://github.com/apache/myfaces/pull/628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apac

Re: [PR] Spec 1263: Add rowStatePreserved property to UIRepeat [myfaces]

2023-10-17 Thread via GitHub
tandraschko merged PR #629: URL: https://github.com/apache/myfaces/pull/629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apac

Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-10-17 Thread via GitHub
volosied commented on PR #630: URL: https://github.com/apache/myfaces/pull/630#issuecomment-1766546891 Haven't run the the full tck yet, but the one test that failed is now passing. I should have all the results by tomorrow. I think the changes should be fine. Can you get a PR for t

Re: [PR] fix(toast): update toast content [myfaces-tobago]

2023-10-17 Thread via GitHub
henningn merged PR #4383: URL: https://github.com/apache/myfaces-tobago/pull/4383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myface

Re: [PR] chore: npm audit fix [myfaces-tobago]

2023-10-17 Thread via GitHub
henningn merged PR #4386: URL: https://github.com/apache/myfaces-tobago/pull/4386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myface

Re: [PR] fix(toast): update toast content [myfaces-tobago]

2023-10-17 Thread via GitHub
henningn merged PR #4384: URL: https://github.com/apache/myfaces-tobago/pull/4384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myface

Re: [PR] chore: npm audit fix [myfaces-tobago]

2023-10-17 Thread via GitHub
henningn merged PR #4385: URL: https://github.com/apache/myfaces-tobago/pull/4385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myface

[PR] chore: npm audit fix [myfaces-tobago]

2023-10-17 Thread via GitHub
henningn opened a new pull request, #4386: URL: https://github.com/apache/myfaces-tobago/pull/4386 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] chore: npm audit fix [myfaces-tobago]

2023-10-17 Thread via GitHub
henningn opened a new pull request, #4385: URL: https://github.com/apache/myfaces-tobago/pull/4385 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] fix(toast): update toast content [myfaces-tobago]

2023-10-17 Thread via GitHub
henningn opened a new pull request, #4383: URL: https://github.com/apache/myfaces-tobago/pull/4383 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] fix(toast): update toast content [myfaces-tobago]

2023-10-17 Thread via GitHub
henningn opened a new pull request, #4384: URL: https://github.com/apache/myfaces-tobago/pull/4384 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri