[jira] Commented: (TOMAHAWK-516) JSCookMenu problems in a Trinidad project

2006-09-19 Thread Cosma Colanicchia (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-516?page=comments#action_12435832 ] Cosma Colanicchia commented on TOMAHAWK-516: Sorry guys, sources for my test projects was on a pc that now is in assistance, and my schedule

[jira] Commented: (TOMAHAWK-516) JSCookMenu problems in a Trinidad project

2006-07-18 Thread Cosma Colanicchia (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-516?page=comments#action_12421993 ] Cosma Colanicchia commented on TOMAHAWK-516: The findNestingForm refactoring has already been coded and committed in the meantime by Martin

Re: Client Validation Design Discussion

2006-07-12 Thread Cosma Colanicchia
It seems to me that both ways lead to inheritance :) I think that an interface should be used, especially if the *only* goal of an abstract base class would be defining those two abstract methods. This is also more flexible because multiple interfaces inheritance is allowed: suppose you have a v

Re: JSCookMenu, dummy form and Trinidad problems

2006-07-06 Thread Cosma Colanicchia
Yes, finally I used that approach (don't add the FacesContext attribute and get it with the static method) in RenderUtils, in HtmlJSCookMenuRenderer and in SubFormRenderer. I'm doing some test (thought more testing will be required), then I'll upload the new patch in JIRA. Ciao Cosma 2006/7/6,

Re: JSCookMenu, dummy form and Trinidad problems

2006-07-06 Thread Cosma Colanicchia
About RenderUtils I'm in doubt.. I changed the return type and added the FacesContex argument, so its really a "new" method, I think that it is useless to mark it as deprecated.. also because it actually does a thin wrapping for the _ComponentUtils method, as it extracts the UIComponent from the F

Re: JSCookMenu, dummy form and Trinidad problems

2006-07-06 Thread Cosma Colanicchia
Ok, I'm doing it right now. Please correct if I'm wrong: references to shared class must be done using the "shared" package for classes in shared package itself, and using "shared_tomahawk" from the external tomahawk classes? 2006/7/6, Mario Ivankovits <[EMAI

Re: JSCookMenu, dummy form and Trinidad problems

2006-07-06 Thread Cosma Colanicchia
Okay, but 1 and 4 returns an UIForm, while 2 returns an UIComponent. How to deal with this? 2006/7/6, Mario Ivankovits <[EMAIL PROTECTED]>: Hi Cosma! > Maybe we can do some cleanout, removing the RenderUtils.findParentForm > and making SubFormRenderer and HtmlTabbedPaneRenderer use the > _Com

Re: JSCookMenu, dummy form and Trinidad problems

2006-07-06 Thread Cosma Colanicchia
Okay, I've done a little research about those findNestingForm / findParentForm methods. An implementation is actually provided by: 1) public static UIForm findParentForm(...) in shared.renderkit.RenderUtils 2) public static FormInfo findNestingForm(...) in shared.util._ComponentUtils 3) public st

Re: JSCookMenu, dummy form and Trinidad problems

2006-07-05 Thread Cosma Colanicchia
Thank for your review Mario, using findNestingForm may be good, but I don't know if it is used elsewhere. Maybe other objects "rely" on the component returned to be an UIForm? I went with a conservative approach. Moreover, the original code itself didn't make use of that utility method. Anyway,

[jira] Updated: (TOMAHAWK-516) JSCookMenu problems in a Trinidad project

2006-07-05 Thread Cosma Colanicchia (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-516?page=all ] Cosma Colanicchia updated TOMAHAWK-516: --- Status: Patch Available (was: Open) > JSCookMenu problems in a Trinidad project > - > >

[jira] Created: (TOMAHAWK-516) JSCookMenu problems in a Trinidad project

2006-07-05 Thread Cosma Colanicchia (JIRA)
both Trinidad and MyFaces Tomahawk Reporter: Cosma Colanicchia Using JSCookMenu in a MyFaces+Trinidad project leads to some problems. 1) HtmlJSCookMenuRenderer tries to find the parent form searching for an UIForm component, but the Trinidad CoreForm doesn't extend UIForm. The enclosi

Re: JSCookMenu, dummy form and Trinidad problems

2006-07-05 Thread Cosma Colanicchia
Okey, done. Here is the patched patch :) Cosma 2006/7/5, Cosma Colanicchia <[EMAIL PROTECTED]>: Hi Mario, thanks for the good observation. Trinidad's CoreForm uses the family "org.apache.myfaces.adf.Form", while UIForm is "javax.faces.Form". It is much

Re: JSCookMenu, dummy form and Trinidad problems

2006-07-05 Thread Cosma Colanicchia
Hi Mario, thanks for the good observation. Trinidad's CoreForm uses the family "org.apache.myfaces.adf.Form", while UIForm is "javax.faces.Form". It is much better to look at this property instead of using instanceof or class name. I'm modifying the code right now. Ciao Cosma 2006/7/5, Mario I

Re: JSCookMenu, dummy form and Trinidad problems

2006-07-05 Thread Cosma Colanicchia
d to the DOM when it is missing. I tried the code in IE6 and FireFox, but it shoud work also with IE5. I have attached a patch file, can any committer take a look? Thank you Cosma 2006/7/5, Cosma Colanicchia <[EMAIL PROTECTED]>: Hello, I'm trying to use the Tomahawk JSCookMenu in my

JSCookMenu, dummy form and Trinidad problems

2006-07-05 Thread Cosma Colanicchia
Hello, I'm trying to use the Tomahawk JSCookMenu in my MyFaces/Trinidad/Facelets project, but I have some troubles. Note that I use an "home.jspx" page with an iframe. I want my menu on the outer page, and links opened in the iframe. First attemp: Simply put the inside my . Problem: all the dum

Re: Problems building myfaces

2006-06-29 Thread Cosma Colanicchia
it out again and it seems that the real sources are now being downloaded.. thank you Wendy. Cosma 2006/6/29, Wendy Smoak <[EMAIL PROTECTED]>: On 6/28/06, Cosma Colanicchia <[EMAIL PROTECTED]> wrote: > I have done a fresh checkout of latest myfaces, and just installed > maven 2

Problems building myfaces

2006-06-28 Thread Cosma Colanicchia
Hi, I have done a fresh checkout of latest myfaces, and just installed maven 2.0.4. I cant build myfaces, mvn install gives me this error: D:\Sviluppo\myfaces>mvn install [INFO] Scanning for projects... [INFO] [ERROR] FATAL

Re: redirect navigation rule and request scoped data

2006-06-23 Thread Cosma Colanicchia
Note that I was thinking more about request parameters than request-scoped objects.. not really the same thing :-) Bye Cosma 2006/6/23, Cosma Colanicchia <[EMAIL PROTECTED]>: I had in mind something like this: * gotoEditPerson /person/edit.jspx(personId) See the : tha

Re: redirect navigation rule and request scoped data

2006-06-23 Thread Cosma Colanicchia
I had in mind something like this: * gotoEditPerson /person/edit.jspx(personId) See the : that view declares that it "wants" a personId parameter. The place where this syntax should be interpreted is the NavigationHandler, which is also the place where redirection caused by tag is

Re: redirect navigation rule and request scoped data

2006-06-23 Thread Cosma Colanicchia
It would be better to have a context initialization parameter to enable this behaviour.. sometimes it is "expected" to drop request scoped stuff on redirects :). BTW, nice idea.. Some days ago I was thinking about something similar but "selective", with an extended navigation rule syntax allowing

Re: t:columns and input fields

2006-06-15 Thread Cosma Colanicchia
Have you tried to set the forceIdIndexFormula of t:dataTable to a proper field? Cosma 2006/6/15, Daniele Bernardini <[EMAIL PROTECTED]>: Hi people, maybe this is old news for you but I stumbled upon a problem with input fields inside t:columns. Namely the generated id is equal across the whole

Re: [jira] Commented: (MYFACES-1103) Access to NavigationCases in NavigationHandlerImpl

2006-06-14 Thread Cosma Colanicchia
I put a vote on JSF issue #179.. maybe other java.net registered users here could do the same :-) Cosma 2006/6/14, Matthias Weßendorf (JIRA) : [ http://issues.apache.org/jira/browse/MYFACES-1103?page=comments#action_12416126 ] Matthias Weßendorf commented on MYFACES-1103: ---