[GitHub] [myfaces] tandraschko commented on pull request #473: MYFACES-4543: Use Flash Cookies When In Client Window URL Default Mode

2023-01-13 Thread GitBox
tandraschko commented on PR #473: URL: https://github.com/apache/myfaces/pull/473#issuecomment-1381912442 I would do the following: 1) change your IF to "isUrlMode", also when the user sets it 2) please add a comment and link to the issue number -- This is an automated message from

[GitHub] [myfaces] tandraschko commented on pull request #473: MYFACES-4543: Use Flash Cookies When In Client Window URL Default Mode

2023-01-11 Thread GitBox
tandraschko commented on PR #473: URL: https://github.com/apache/myfaces/pull/473#issuecomment-1379062865 i think we need to dig a bit deeper i understand your problem as URL ClientWindow doesnt do something like a initialRedirect, so when you visit the view and press f5, the

[GitHub] [myfaces] tandraschko commented on pull request #473: MYFACES-4543: Use Flash Cookies When In Client Window URL Default Mode

2023-01-11 Thread GitBox
tandraschko commented on PR #473: URL: https://github.com/apache/myfaces/pull/473#issuecomment-1378940652 Yeah, seems so -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [myfaces] tandraschko commented on pull request #473: MYFACES-4543: Use Flash Cookies When In Client Window URL Default Mode

2023-01-11 Thread GitBox
tandraschko commented on PR #473: URL: https://github.com/apache/myfaces/pull/473#issuecomment-1378737971 is this really correct? wouldnt it be better to check if there currently is a ClientWindow available for the current request? -- This is an automated message from the Apache Git