tandraschko commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-140211
As i said, i would skip the whole checks on dev stage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tandraschko commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1400733706
I would just change it to dev mode only, it doesnt make sense in production
We can still revert it If require or skip this test
--
This is an automated message from the Apache Git
tandraschko commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1397245565
i should we should also only check this if projecstage == development
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tandraschko commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1396901570
yep but IMO the myfaces checkstyle is not configured hard enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tandraschko commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1396634133
the indentations are looking bit weird/to small? otherwise +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
tandraschko commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1386601234
Actually this is a exception which already fails in development mode
I would not increase the buffer size in general for this
--
This is an automated message from the Apache
