[GitHub] [myfaces] volosied commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory

2023-03-21 Thread via GitHub
volosied commented on PR #354: URL: https://github.com/apache/myfaces/pull/354#issuecomment-1477863978 I see my error. I left out `facesContextPurgeMethod = getPurgeMethod(facesContext, "purgeFacesContext", NO_PARAMETER_TYPES);` Builds passes now. If no objections, I will merge

[GitHub] [myfaces] volosied commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory

2023-03-20 Thread via GitHub
volosied commented on PR #354: URL: https://github.com/apache/myfaces/pull/354#issuecomment-1476762678 Build failed due to : ``` Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) on project myfaces-impl: Compilation failure

[GitHub] [myfaces] volosied commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory

2022-12-06 Thread GitBox
volosied commented on PR #354: URL: https://github.com/apache/myfaces/pull/354#issuecomment-1340349512 Thanks for the reviews. The user who reported this error says they encountered some problem with this fix. Not sure why, but I'm trying to get more information from them before I merge.