volosied commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1404009715
Added check for development stage -- merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
volosied commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1400712721
@melloware @tandraschko
Challenge hasn't had any movement -- I'd like to merge this PR for now for
RC4 and we can switch this check to development depending on throw the
volosied commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1397250048
We would need to address that via a TCK challenge since Mojarra checks it by
default.
But I agree that that this check makes sense during development, not
production.
--
This
volosied commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1397208218
Indented some of the nested statements / blocks so it should look better.
Will merge once the CI build completes.
--
This is an automated message from the Apache Git Service.
To
volosied commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1397205447
Not a fan of the formatting either, but I get check style exceptions if the
bracket's aren't on a new line.
--
This is an automated message from the Apache Git Service.
To respond to
volosied commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1387176556
What do you mean? An exception is thrown in our code already if the project
is set to development mode? I tested this, but still received a 200 response?
Here's the output:
volosied commented on PR #484:
URL: https://github.com/apache/myfaces/pull/484#issuecomment-1386094408
Need to run this against the TCK before merging. Also, the TCK needs to
increase the jakarta.faces.FACELETS_BUFFER_SIZE param since we commit the
response before the exception.
--
