[GitHub] [myfaces] volosied commented on pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

2023-01-27 Thread via GitHub
volosied commented on PR #492: URL: https://github.com/apache/myfaces/pull/492#issuecomment-1407101177 All checks passed -- merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [myfaces] volosied commented on pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

2023-01-27 Thread via GitHub
volosied commented on PR #492: URL: https://github.com/apache/myfaces/pull/492#issuecomment-1407090761 Last commit update -- Empty string / null means there is no value -- do not convert them for ui select one. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [myfaces] volosied commented on pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

2023-01-25 Thread via GitHub
volosied commented on PR #492: URL: https://github.com/apache/myfaces/pull/492#issuecomment-1404185814 Need to check on more edge case before merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [myfaces] volosied commented on pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

2023-01-23 Thread via GitHub
volosied commented on PR #492: URL: https://github.com/apache/myfaces/pull/492#issuecomment-1400715662 I'd also like to merge this for RC4, unless there are objections? Any follow up / improvements can be done in a future RC release. @melloware @tandraschko -- This is an

[GitHub] [myfaces] volosied commented on pull request #492: MYFACES-4551: Allow group validation for uiselectone elements

2023-01-20 Thread GitBox
volosied commented on PR #492: URL: https://github.com/apache/myfaces/pull/492#issuecomment-1398707459 Mojarra's steps: 1) MenuRenderer#decodeGroup -- submitted value is set to RIConstants.NO_VALUE ("") -