[GitHub] [myfaces] volosied commented on pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-16 Thread via GitHub
volosied commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1433182916 I agree. What about `always, dev-only, never`as the three options? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [myfaces] volosied commented on pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-14 Thread via GitHub
volosied commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1430297468 @tandraschko Let me know what you think of the new changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [myfaces] volosied commented on pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-14 Thread via GitHub
volosied commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1429987506 I think I'm following you now. So here's the new behavior for these _info_ message: auto - logs in dev mode only (not prod) (fine messages still logged in prod when trace is spe

[GitHub] [myfaces] volosied commented on pull request #520: MYFACES-4561 Change Context Parameter Logging

2023-02-14 Thread via GitHub
volosied commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1429970835 I can keep the new logging code as is, but undo my LOG_WEB_CONTEXT_PARAMS changes. Although, "auto" doesn't seem to make much sense since now it only applies to dev mode (true / fal